liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: don't use 'out' in IDiscordCache methods

Browse Source 
this change is required for async cache (.NET doesn't support async ref/out params)
This commit is contained in:
spiral
2021-11-18 13:11:02 -05:00
parent 3ba46ff456
commit 0efaab6d95
11 changed files with 48 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
Myriad/Cache/MemoryDiscordCache.cs
View File

@@ -124,34 +124,36 @@ namespace Myriad.Cache
return default;
}
public Task<bool> TryGetGuild(ulong guildId, out Guild guild)
public Task<Guild?> TryGetGuild(ulong guildId)
{
if (_guilds.TryGetValue(guildId, out var cg))
{
guild = cg.Guild;
return Task.FromResult(true);
}
guild = null!;
return Task.FromResult(false);
_guilds.TryGetValue(guildId, out var cg);
return Task.FromResult(cg?.Guild);
}
public Task<bool> TryGetChannel(ulong channelId, out Channel channel) =>
Task.FromResult(_channels.TryGetValue(channelId, out channel!));
public Task<bool> TryGetDmChannel(ulong userId, out Channel channel)
public Task<Channel?> TryGetChannel(ulong channelId)
{
_channels.TryGetValue(channelId, out var channel);
return Task.FromResult(channel);
}
public Task<Channel?> TryGetDmChannel(ulong userId)
{
channel = default!;
if (!_dmChannels.TryGetValue(userId, out var channelId))
return Task.FromResult(false);
return TryGetChannel(channelId, out channel);
return Task.FromResult((Channel?) null);
return TryGetChannel(channelId);
}
public Task<bool> TryGetUser(ulong userId, out User user) =>
Task.FromResult(_users.TryGetValue(userId, out user!));
public Task<User?> TryGetUser(ulong userId)
{
_users.TryGetValue(userId, out var user);
return Task.FromResult(user);
}
public Task<bool> TryGetRole(ulong roleId, out Role role) =>
Task.FromResult(_roles.TryGetValue(roleId, out role!));
public Task<Role?> TryGetRole(ulong roleId)
{
_roles.TryGetValue(roleId, out var role);
return Task.FromResult(role);
}
public IAsyncEnumerable<Guild> GetAllGuilds()
{