liz/PluralKit
liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: don't write raw sql queries to influxdb metrics

Browse Source
This commit is contained in:
spiral 2022-11-17 02:51:04 +00:00
parent 2745ee6156
commit 12323f3662
No known key found for this signature in database
GPG Key ID: 244A11E4B0BCF40E
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
PluralKit.Core/Database/Database.cs
View File

@ -87,6 +87,7 @@ internal partial class Database: IDatabase
NpgsqlConnection.GlobalTypeMapper.MapEnum<PrivacyLevel>("privacy_level"); NpgsqlConnection.GlobalTypeMapper.MapEnum<PrivacyLevel>("privacy_level");
} }
// TODO: make sure every SQL query is behind a logged query method
public async Task<IPKConnection> Obtain() public async Task<IPKConnection> Obtain()
{ {
// Mark the request (for a handle, I guess) in the metrics // Mark the request (for a handle, I guess) in the metrics

7
PluralKit.Core/Database/Wrappers/PKCommand.cs
View File

@ -124,9 +124,10 @@ internal class PKCommand: DbCommand, IPKCommand
elapsed, _ourConnection.ConnectionId); elapsed, _ourConnection.ConnectionId);
// One "BCL compatible tick" is 100 nanoseconds // One "BCL compatible tick" is 100 nanoseconds
var micros = elapsed.BclCompatibleTicks / 10;
_metrics.Provider.Timer.Instance(CoreMetrics.DatabaseQuery, new MetricTags("query", CommandText)) // var micros = elapsed.BclCompatibleTicks / 10;
.Record(micros, TimeUnit.Microseconds, CommandText); // _metrics.Provider.Timer.Instance(CoreMetrics.DatabaseQuery, new MetricTags("query", CommandText))
// .Record(micros, TimeUnit.Microseconds, CommandText);
} }
} }