liz/PluralKit
liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: add config setting to disable sending errors

Browse Source 
we've disabled/re-enabled these a few times in code now...
This commit is contained in:
spiral 2021-11-09 01:50:09 -05:00
parent ec3795f9d0
commit 35bbf199f6
No known key found for this signature in database
GPG Key ID: A6059F0CA0E1BD31
2 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
PluralKit.Bot/Bot.cs
View File

@ -37,6 +37,7 @@ namespace PluralKit.Bot
private readonly ILifetimeScope _services; private readonly ILifetimeScope _services;
private readonly PeriodicStatCollector _collector; private readonly PeriodicStatCollector _collector;
private readonly IMetrics _metrics; private readonly IMetrics _metrics;
private readonly BotConfig _config;
private readonly ErrorMessageService _errorMessageService; private readonly ErrorMessageService _errorMessageService;
private readonly CommandMessageService _commandMessageService; private readonly CommandMessageService _commandMessageService;
private readonly IDiscordCache _cache; private readonly IDiscordCache _cache;
@ -44,13 +45,14 @@ namespace PluralKit.Bot
private bool _hasReceivedReady = false; private bool _hasReceivedReady = false;
private Timer _periodicTask; // Never read, just kept here for GC reasons private Timer _periodicTask; // Never read, just kept here for GC reasons
public Bot(ILifetimeScope services, ILogger logger, PeriodicStatCollector collector, IMetrics metrics, public Bot(ILifetimeScope services, ILogger logger, PeriodicStatCollector collector, IMetrics metrics, BotConfig config,
ErrorMessageService errorMessageService, CommandMessageService commandMessageService, Cluster cluster, DiscordApiClient rest, IDiscordCache cache) ErrorMessageService errorMessageService, CommandMessageService commandMessageService, Cluster cluster, DiscordApiClient rest, IDiscordCache cache)
{ {
_logger = logger.ForContext<Bot>(); _logger = logger.ForContext<Bot>();
_services = services; _services = services;
_collector = collector; _collector = collector;
_metrics = metrics; _metrics = metrics;
_config = config;
_errorMessageService = errorMessageService; _errorMessageService = errorMessageService;
_commandMessageService = commandMessageService; _commandMessageService = commandMessageService;
_cluster = cluster; _cluster = cluster;
@ -252,16 +254,18 @@ namespace PluralKit.Bot
SentrySdk.CaptureEvent(sentryEvent, sentryScope); SentrySdk.CaptureEvent(sentryEvent, sentryScope);
// most of these errors aren't useful... // most of these errors aren't useful...
if (_config.DisableErrorReporting)
return;
// // Once we've sent it to Sentry, report it to the user (if we have permission to) // Once we've sent it to Sentry, report it to the user (if we have permission to)
// var reportChannel = handler.ErrorChannelFor(evt); var reportChannel = handler.ErrorChannelFor(evt);
// if (reportChannel == null) if (reportChannel == null)
// return; return;
// var botPerms = PermissionsIn(reportChannel.Value); var botPerms = PermissionsIn(reportChannel.Value);
// if (botPerms.HasFlag(PermissionSet.SendMessages | PermissionSet.EmbedLinks)) if (botPerms.HasFlag(PermissionSet.SendMessages | PermissionSet.EmbedLinks))
// await _errorMessageService.SendErrorMessage(reportChannel.Value, sentryEvent.EventId.ToString()); await _errorMessageService.SendErrorMessage(reportChannel.Value, sentryEvent.EventId.ToString());
} }
} }

2
PluralKit.Bot/BotConfig.cs
View File

@ -22,6 +22,8 @@ namespace PluralKit.Bot
public string? DiscordBaseUrl { get; set; } public string? DiscordBaseUrl { get; set; }
public bool DisableErrorReporting { get; set; } = false;
public record ClusterSettings public record ClusterSettings
{ {
public string NodeName { get; set; } public string NodeName { get; set; }