liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: better entity resolving in group member endpoints

Browse Source
This commit is contained in:
spiral
2022-04-07 03:48:32 -04:00
parent 36873e08ee
commit 70cf472fb5
2 changed files with 45 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
PluralKit.API/Controllers/v2/GroupMemberControllerV2.cs
View File

@@ -53,7 +53,7 @@ public class GroupMemberControllerV2: PKControllerBase
foreach (var JmemberRef in memberRefs)
{
var memberRef = JmemberRef.Value<string>();
var member = await ResolveMember(memberRef);
var member = await ResolveMember(memberRef, cache: true);
// todo: have a list of these errors instead of immediately throwing
@@ -93,7 +93,7 @@ public class GroupMemberControllerV2: PKControllerBase
foreach (var JmemberRef in memberRefs)
{
var memberRef = JmemberRef.Value<string>();
var member = await ResolveMember(memberRef);
var member = await ResolveMember(memberRef, cache: true);
if (member == null)
throw Errors.MemberNotFoundWithRef(memberRef);
@@ -124,7 +124,7 @@ public class GroupMemberControllerV2: PKControllerBase
foreach (var JmemberRef in memberRefs)
{
var memberRef = JmemberRef.Value<string>();
var member = await ResolveMember(memberRef);
var member = await ResolveMember(memberRef, cache: true);
if (member == null)
throw Errors.MemberNotFoundWithRef(memberRef);
@@ -182,7 +182,7 @@ public class GroupMemberControllerV2: PKControllerBase
foreach (var JgroupRef in groupRefs)
{
var groupRef = JgroupRef.Value<string>();
var group = await ResolveGroup(groupRef);
var group = await ResolveGroup(groupRef, cache: true);
if (group == null)
throw Errors.GroupNotFound;
@@ -220,7 +220,7 @@ public class GroupMemberControllerV2: PKControllerBase
foreach (var JgroupRef in groupRefs)
{
var groupRef = JgroupRef.Value<string>();
var group = await ResolveGroup(groupRef);
var group = await ResolveGroup(groupRef, cache: true);
if (group == null)
throw Errors.GroupNotFoundWithRef(groupRef);
@@ -251,7 +251,7 @@ public class GroupMemberControllerV2: PKControllerBase
foreach (var JgroupRef in groupRefs)
{
var groupRef = JgroupRef.Value<string>();
var group = await ResolveGroup(groupRef);
var group = await ResolveGroup(groupRef, cache: true);
if (group == null)
throw Errors.GroupNotFoundWithRef(groupRef);