Fix various bugs and regressions

PluralKit.Bot/Commands/ImportExport.cs

@@ -144,7 +144,6 @@ namespace PluralKit.Bot
             try
             {
                 var dm = await ctx.RestNew.CreateDm(ctx.AuthorNew.Id);
-                // TODO: send file
 
                 var msg = await ctx.RestNew.CreateMessage(dm.Id,
                     new MessageRequest {Content = $"{Emojis.Success} Here you go!"},

PluralKit.Bot/Commands/Misc.cs

@@ -84,8 +84,7 @@ namespace PluralKit.Bot {
             var totalSwitches = _metrics.Snapshot.GetForContext("Application").Gauges.FirstOrDefault(m => m.MultidimensionalName == CoreMetrics.SwitchCount.Name)?.Value ?? 0;
             var totalMessages = _metrics.Snapshot.GetForContext("Application").Gauges.FirstOrDefault(m => m.MultidimensionalName == CoreMetrics.MessageCount.Name)?.Value ?? 0;
 
-            // TODO: shard stuff
-            var shardId = ctx.ShardNew.ShardInfo?.ShardId ?? -1;
+            var shardId = ctx.ShardNew.ShardInfo.ShardId;
             var shardTotal = ctx.Cluster.Shards.Count;
             var shardUpTotal = _shards.Shards.Where(x => x.Connected).Count();
             var shardInfo = _shards.GetShardInfo(ctx.ShardNew);

PluralKit.Bot/Commands/SystemFront.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Linq;
+using System.Text;
 using System.Threading.Tasks;
 
 using NodaTime;
@@ -70,6 +71,7 @@ namespace PluralKit.Bot
                 embedTitle,
                 async (builder, switches) =>
                 {
+                    var sb = new StringBuilder();
                     foreach (var entry in switches)
                     {
                         var lastSw = entry.LastTime;
@@ -98,17 +100,13 @@ namespace PluralKit.Bot
                             stringToAdd =
                                 $"**{membersStr}** ({sw.Timestamp.FormatZoned(system.Zone)}, {switchSince.FormatDuration()} ago)\n";
                         }
-                        
-                        try // Unfortunately the only way to test DiscordEmbedBuilder.Description max length is this
-                        {
-                            // TODO: what is this??
-                            // builder.Description += stringToAdd;
-                        }
-                        catch (ArgumentException)
-                        {
+
+                        if (sb.Length + stringToAdd.Length >= 1024)
                             break;
-                        }// TODO: Make sure this works
+                        sb.Append(stringToAdd);
                     }
+
+                    builder.Description(sb.ToString());
                 }
             );
         }