liz/PluralKit
liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add more error reporting for Discord errors

Browse Source
This commit is contained in:
Ske 2020-05-12 21:23:05 +02:00
parent 60018bf69d
commit 8ea02dae81
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
PluralKit.Bot/Bot.cs
View File

@ -1,4 +1,5 @@
using System; using System;
using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Net.WebSockets; using System.Net.WebSockets;
using System.Threading; using System.Threading;
@ -129,8 +130,6 @@ namespace PluralKit.Bot
{ {
// Make this beforehand so we can access the event ID for logging // Make this beforehand so we can access the event ID for logging
var sentryEvent = new SentryEvent(exc); var sentryEvent = new SentryEvent(exc);
if (exc is BadRequestException bre)
sentryEvent.SetExtra("errors", MiscUtils.ExtractError(bre));
_logger.Error(exc, "Exception in bot event handler (Sentry ID: {SentryEventId})", sentryEvent.EventId); _logger.Error(exc, "Exception in bot event handler (Sentry ID: {SentryEventId})", sentryEvent.EventId);
@ -140,6 +139,15 @@ namespace PluralKit.Bot
// Report error to Sentry // Report error to Sentry
// This will just no-op if there's no URL set // This will just no-op if there's no URL set
var sentryScope = serviceScope.Resolve<Scope>(); var sentryScope = serviceScope.Resolve<Scope>();
// Add some specific info about Discord error responses, as a breadcrumb
if (exc is BadRequestException bre)
sentryScope.AddBreadcrumb(bre.WebResponse.Response, "response.error", data: new Dictionary<string, string>(bre.WebResponse.Headers));
if (exc is NotFoundException nfe)
sentryScope.AddBreadcrumb(nfe.WebResponse.Response, "response.error", data: new Dictionary<string, string>(nfe.WebResponse.Headers));
if (exc is UnauthorizedException ue)
sentryScope.AddBreadcrumb(ue.WebResponse.Response, "response.error", data: new Dictionary<string, string>(ue.WebResponse.Headers));
SentrySdk.CaptureEvent(sentryEvent, sentryScope); SentrySdk.CaptureEvent(sentryEvent, sentryScope);
// Once we've sent it to Sentry, report it to the user (if we have permission to) // Once we've sent it to Sentry, report it to the user (if we have permission to)

5
PluralKit.Bot/Utils/MiscUtils.cs
View File

@ -49,10 +49,5 @@ namespace PluralKit.Bot
// This may expanded at some point. // This may expanded at some point.
return true; return true;
} }
public static string ExtractError(BadRequestException e)
{
return e.WebResponse.Response;
}
} }
} }