liz/PluralKit
liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly pass exceptions to Sentry

Browse Source
This commit is contained in:
Ske 2020-05-05 16:42:14 +02:00
parent 0f64086c75
commit a052c8331c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PluralKit.Bot/Bot.cs
View File

@ -97,14 +97,16 @@ namespace PluralKit.Bot
private async Task HandleError<T>(IEventHandler<T> handler, T evt, ILifetimeScope serviceScope, Exception exc) private async Task HandleError<T>(IEventHandler<T> handler, T evt, ILifetimeScope serviceScope, Exception exc)
where T: DiscordEventArgs where T: DiscordEventArgs
{ {
_logger.Error(exc, "Exception in bot event handler"); // Make this beforehand so we can access the event ID for logging
var sentryEvent = new SentryEvent(exc);
_logger.Error(exc, "Exception in bot event handler (Sentry ID: {SentryEventId})", sentryEvent.EventId);
var shouldReport = exc.IsOurProblem(); var shouldReport = exc.IsOurProblem();
if (shouldReport) if (shouldReport)
{ {
// Report error to Sentry // Report error to Sentry
// This will just no-op if there's no URL set // This will just no-op if there's no URL set
var sentryEvent = new SentryEvent();
var sentryScope = serviceScope.Resolve<Scope>(); var sentryScope = serviceScope.Resolve<Scope>();
SentrySdk.CaptureEvent(sentryEvent, sentryScope); SentrySdk.CaptureEvent(sentryEvent, sentryScope);