From be5bf0cfb781cd4efb1b367c5d9b11f5b80f69a4 Mon Sep 17 00:00:00 2001
From: spiral <spiral@spiral.sh>
Date: Fri, 29 Oct 2021 13:28:27 -0400
Subject: [PATCH] feat: misc pk;log channel changes

- show currently set log channel if no arguments are present
- throw error if someone tries to set the log channel to an invalid channel type
- throw error if bot is missing permissions to log in the new channel
---
 PluralKit.Bot/Commands/ServerConfig.cs | 27 ++++++++++++++++++++++----
 docs/content/command-list.md           |  1 +
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/PluralKit.Bot/Commands/ServerConfig.cs b/PluralKit.Bot/Commands/ServerConfig.cs
index 7849e190..3640d4dd 100644
--- a/PluralKit.Bot/Commands/ServerConfig.cs
+++ b/PluralKit.Bot/Commands/ServerConfig.cs
@@ -18,18 +18,20 @@ namespace PluralKit.Bot
         private readonly ModelRepository _repo;
         private readonly IDiscordCache _cache;
         private readonly LoggerCleanService _cleanService;
-        public ServerConfig(LoggerCleanService cleanService, IDatabase db, ModelRepository repo, IDiscordCache cache)
+        private readonly Bot _bot;
+        public ServerConfig(LoggerCleanService cleanService, IDatabase db, ModelRepository repo, IDiscordCache cache, Bot bot)
         {
             _cleanService = cleanService;
             _db = db;
             _repo = repo;
             _cache = cache;
+            _bot = bot;
         }
 
         public async Task SetLogChannel(Context ctx)
         {
             ctx.CheckGuildContext().CheckAuthorPermission(PermissionSet.ManageGuild, "Manage Server");
-            await _repo.GetGuild(ctx.Guild.Id);
+            var settings = await _repo.GetGuild(ctx.Guild.Id);
 
             if (await ctx.MatchClear("the server log channel"))
             {
@@ -39,15 +41,32 @@ namespace PluralKit.Bot
             }
 
             if (!ctx.HasNext())
-                throw new PKSyntaxError("You must pass a #channel to set, or `clear` to clear it.");
+            {
+                if (settings.LogChannel == null)
+                {
+                    await ctx.Reply("This server does not have a log channel set.");
+                    return;
+                }
+
+                await ctx.Reply($"This server's log channel is currently set to <#{settings.LogChannel}>.");
+                return;
+            }
 
             Channel channel = null;
             var channelString = ctx.PeekArgument();
             channel = await ctx.MatchChannel();
             if (channel == null || channel.GuildId != ctx.Guild.Id) throw Errors.ChannelNotFound(channelString);
+            if (channel.Type != Channel.ChannelType.GuildText)
+                throw new PKError("PluralKit cannot log messages to this type of channel.");
+
+            var perms = _bot.PermissionsIn(channel.Id);
+            if (!perms.HasFlag(PermissionSet.SendMessages))
+                throw new PKError("PluralKit is missing **Send Messages** permissions in the new log channel.");
+            if (!perms.HasFlag(PermissionSet.EmbedLinks))
+                throw new PKError("PluralKit is missing **Embed Links** permissions in the new log channel.");
 
             await _repo.UpdateGuild(ctx.Guild.Id, new() { LogChannel = channel.Id });
-            await ctx.Reply($"{Emojis.Success} Proxy logging channel set to #{channel.Name}.");
+            await ctx.Reply($"{Emojis.Success} Proxy logging channel set to <#{channel.Id}>.");
         }
 
         public async Task SetLogEnabled(Context ctx, bool enable)
diff --git a/docs/content/command-list.md b/docs/content/command-list.md
index 621510ee..bea27c4e 100644
--- a/docs/content/command-list.md
+++ b/docs/content/command-list.md
@@ -112,6 +112,7 @@ Some arguments indicate the use of specific Discord features. These include:
 
 ## Server owner commands
 *(all commands here require Manage Server permission)*
+- `pk;log channel` - Shows the currently set log channel
 - `pk;log channel <channel>` - Sets the given channel to log all proxied messages.
 - `pk;log channel -clear` - Clears the currently set log channel.
 - `pk;log disable <#channel> [#channel...]` - Disables logging messages posted in the given channel(s) (useful for staff channels and such).