feat: split out messages table from main database

PluralKit.Core/Database/Repository/ModelRepository.Member.cs

@@ -89,4 +89,12 @@ public partial class ModelRepository
         if (oldMember != null)
             _ = _dispatch.Dispatch(oldMember.System, oldMember.Uuid, DispatchEvent.DELETE_MEMBER);
     }
+
+    public async Task<bool> IsMemberOwnedByAccount(MemberId id, ulong userId)
+    {
+        return await _db.QueryFirst<bool>(
+            "select true from accounts, members where members.id = @member and accounts.uid = @account and members.system = accounts.system",
+            new { member = id, account = userId }
+        );
+    }
 }

PluralKit.Core/Database/Repository/ModelRepository.Message.cs

@@ -20,29 +20,38 @@ public partial class ModelRepository
         _logger.Debug("Stored message {@StoredMessage} in channel {Channel}", msg, msg.Channel);
 
         // "on conflict do nothing" in the (pretty rare) case of duplicate events coming in from Discord, which would lead to a DB error before
-        return _db.ExecuteQuery(query, "on conflict do nothing");
+        return _db.ExecuteQuery(query, "on conflict do nothing", messages: true);
     }
 
-    // todo: add a Mapper to QuerySingle and move this to SqlKata
-    public async Task<FullMessage?> GetMessage(IPKConnection conn, ulong id)
+    public async Task<PKMessage?> GetMessage(ulong id)
     {
-        FullMessage Mapper(PKMessage msg, PKMember member, PKSystem system) =>
-            new() { Message = msg, System = system, Member = member };
+        return await _db.QueryFirst<PKMessage?>(
+            "select * from messages where mid = @Id",
+            new { Id = id },
+            messages: true
+        );
+    }
 
-        var query = "select * from messages"
-            + " left join members on messages.member = members.id"
-            + " left join systems on members.system = systems.id"
-            + " where (mid = @Id or original_mid = @Id)";
+    public async Task<FullMessage?> GetFullMessage(ulong id)
+    {
+        var rawMessage = await GetMessage(id);
+        if (rawMessage == null) return null;
 
-        var result = await conn.QueryAsync<PKMessage, PKMember, PKSystem, FullMessage>(
-            query, Mapper, new { Id = id });
-        return result.FirstOrDefault();
+        var member = rawMessage.Member == null ? null : await GetMember(rawMessage.Member.Value);
+        var system = member == null ? null : await GetSystem(member.System);
+
+        return new FullMessage
+        {
+            Message = rawMessage,
+            Member = member,
+            System = system,
+        };
     }
 
     public async Task DeleteMessage(ulong id)
     {
         var query = new Query("messages").AsDelete().Where("mid", id);
-        var rowCount = await _db.ExecuteQuery(query);
+        var rowCount = await _db.ExecuteQuery(query, messages: true);
         if (rowCount > 0)
             _logger.Information("Deleted message {MessageId} from database", id);
     }
@@ -52,22 +61,9 @@ public partial class ModelRepository
         // Npgsql doesn't support ulongs in general - we hacked around it for plain ulongs but tbh not worth it for collections of ulong
         // Hence we map them to single longs, which *are* supported (this is ok since they're Technically (tm) stored as signed longs in the db anyway)
         var query = new Query("messages").AsDelete().WhereIn("mid", ids.Select(id => (long)id).ToArray());
-        var rowCount = await _db.ExecuteQuery(query);
+        var rowCount = await _db.ExecuteQuery(query, messages: true);
         if (rowCount > 0)
             _logger.Information("Bulk deleted messages ({FoundCount} found) from database: {MessageIds}", rowCount,
                 ids);
     }
-
-    public Task<PKMessage?> GetLastMessage(ulong guildId, ulong channelId, ulong accountId)
-    {
-        // Want to index scan on the (guild, sender, mid) index so need the additional constraint
-        var query = new Query("messages")
-            .Where("guild", guildId)
-            .Where("channel", channelId)
-            .Where("sender", accountId)
-            .OrderByDesc("mid")
-            .Limit(1);
-
-        return _db.QueryFirst<PKMessage?>(query);
-    }
 }