From cb1c44a27fbad43e05f9999f65118f6ff6f26d1c Mon Sep 17 00:00:00 2001 From: Ske Date: Wed, 8 Jan 2020 12:16:27 +0100 Subject: [PATCH] Bail early if we don't have send message permission when proxying --- PluralKit.Bot/Services/ProxyService.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/PluralKit.Bot/Services/ProxyService.cs b/PluralKit.Bot/Services/ProxyService.cs index f3410e3a..56252d07 100644 --- a/PluralKit.Bot/Services/ProxyService.cs +++ b/PluralKit.Bot/Services/ProxyService.cs @@ -167,6 +167,10 @@ namespace PluralKit.Bot var guildUser = await channel.Guild.GetCurrentUserAsync(); var permissions = guildUser.GetPermissions(channel); + // If we can't send messages at all, just bail immediately. + // TODO: can you have ManageMessages and *not* SendMessages? What happens then? + if (!permissions.SendMessages && !permissions.ManageMessages) return false; + if (!permissions.ManageWebhooks) { // todo: PKError-ify these