Naming and coding style convention, new linter tool. (#945)

* Makefile, Scripts: new linter
* About: remove ID from IC
* Firmware: remove double define for DIVC/DIVR
* Scripts: check folder names too. Docker: replace syntax check with make lint.
* Reformat Sources and Migrate to new file naming convention
* Docker: symlink clang-format-12 to clang-format
* Add coding style guide

applications/ibutton/helpers/cyfral_decoder.cpp

@@ -1,4 +1,4 @@
-#include "cyfral-decoder.h"
+#include "cyfral_decoder.h"
 #include <furi.h>
 
 void CyfralDecoder::reset_state() {

applications/ibutton/helpers/key_emulator.cpp

@@ -1,4 +1,4 @@
-#include "key-emulator.h"
+#include "key_emulator.h"
 #include <callback-connector.h>
 
 KeyEmulator::~KeyEmulator() {

applications/ibutton/helpers/key_emulator.h

@@ -1,6 +1,6 @@
 #pragma once
-#include "pulse-sequencer.h"
-#include "../ibutton-key.h"
+#include "pulse_sequencer.h"
+#include "../ibutton_key.h"
 #include <one_wire_slave.h>
 #include <one_wire_device_ds_1990.h>
 #include <atomic>

applications/ibutton/helpers/key_reader.cpp

@@ -1,5 +1,5 @@
-#include "key-reader.h"
-#include "key-commands.h"
+#include "key_reader.h"
+#include "key_commands.h"
 #include <callback-connector.h>
 #include <maxim_crc.h>
 

applications/ibutton/helpers/key_reader.h

@@ -1,10 +1,10 @@
 #pragma once
 #include <stdint.h>
 #include <furi.h>
-#include "cyfral-decoder.h"
+#include "cyfral_decoder.h"
 #pragma once
-#include "metakom-decoder.h"
-#include "../ibutton-key.h"
+#include "metakom_decoder.h"
+#include "../ibutton_key.h"
 #include <one_wire_master.h>
 #include <one_wire_slave.h>
 

applications/ibutton/helpers/key_worker.cpp

@@ -1,4 +1,4 @@
-#include "key-worker.h"
+#include "key_worker.h"
 #include <callback-connector.h>
 #include <maxim_crc.h>
 

applications/ibutton/helpers/key_worker.h

@@ -1,10 +1,10 @@
 #pragma once
 #include <furi.h>
-#include "key-info.h"
-#include "key-reader.h"
-#include "key-emulator.h"
-#include "key-writer.h"
-#include "../ibutton-key.h"
+#include "key_info.h"
+#include "key_reader.h"
+#include "key_emulator.h"
+#include "key_writer.h"
+#include "../ibutton_key.h"
 #include <one_wire_master.h>
 #include <one_wire_slave.h>
 

applications/ibutton/helpers/key_writer.cpp

@@ -1,5 +1,5 @@
-#include "key-writer.h"
-#include "key-commands.h"
+#include "key_writer.h"
+#include "key_commands.h"
 
 KeyWriter::KeyWriter(OneWireMaster* _onewire_master) {
     onewire_master = _onewire_master;

applications/ibutton/helpers/key_writer.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "../ibutton-key.h"
+#include "../ibutton_key.h"
 #include <one_wire_master.h>
 
 class KeyWriter {

applications/ibutton/helpers/metakom_decoder.cpp

@@ -1,4 +1,4 @@
-#include "metakom-decoder.h"
+#include "metakom_decoder.h"
 #include <furi.h>
 
 bool MetakomDecoder::read(uint8_t* _data, uint8_t data_size) {

applications/ibutton/helpers/pulse_sequencer.cpp

@@ -1,7 +1,7 @@
-#include "pulse-sequencer.h"
+#include "pulse_sequencer.h"
 #include <furi.h>
 #include <callback-connector.h>
-#include <furi-hal-resources.h>
+#include <furi_hal_resources.h>
 
 void PulseSequencer::set_periods(
     uint32_t* _periods,

applications/ibutton/ibutton.cpp

@@ -1,4 +1,4 @@
-#include "ibutton-app.h"
+#include "ibutton_app.h"
 
 // app enter function
 extern "C" int32_t ibutton_app(void* p) {

applications/ibutton/ibutton_app.cpp

@@ -1,4 +1,4 @@
-#include "ibutton-app.h"
+#include "ibutton_app.h"
 #include <stdarg.h>
 #include <callback-connector.h>
 #include <m-string.h>

applications/ibutton/ibutton_app.h

@@ -2,38 +2,38 @@
 #include <map>
 #include <list>
 
-#include "ibutton-view-manager.h"
-#include "scene/ibutton-scene-generic.h"
-#include "scene/ibutton-scene-start.h"
-#include "scene/ibutton-scene-read.h"
-#include "scene/ibutton-scene-read-crc-error.h"
-#include "scene/ibutton-scene-read-not-key-error.h"
-#include "scene/ibutton-scene-read-success.h"
-#include "scene/ibutton-scene-readed-key-menu.h"
-#include "scene/ibutton-scene-write.h"
-#include "scene/ibutton-scene-write-success.h"
-#include "scene/ibutton-scene-saved-key-menu.h"
-#include "scene/ibutton-scene-delete-confirm.h"
-#include "scene/ibutton-scene-delete-success.h"
-#include "scene/ibutton-scene-emulate.h"
-#include "scene/ibutton-scene-save-name.h"
-#include "scene/ibutton-scene-save-success.h"
-#include "scene/ibutton-scene-info.h"
-#include "scene/ibutton-scene-select-key.h"
-#include "scene/ibutton-scene-add-type.h"
-#include "scene/ibutton-scene-add-value.h"
+#include "ibutton_view_manager.h"
+#include "scene/ibutton_scene_generic.h"
+#include "scene/ibutton_scene_start.h"
+#include "scene/ibutton_scene_read.h"
+#include "scene/ibutton_scene_read_crc_error.h"
+#include "scene/ibutton_scene_read_not_key_error.h"
+#include "scene/ibutton_scene_read_success.h"
+#include "scene/ibutton_scene_readed_key_menu.h"
+#include "scene/ibutton_scene_write.h"
+#include "scene/ibutton_scene_write_success.h"
+#include "scene/ibutton_scene_saved_key_menu.h"
+#include "scene/ibutton_scene_delete_confirm.h"
+#include "scene/ibutton_scene_delete_success.h"
+#include "scene/ibutton_scene_emulate.h"
+#include "scene/ibutton_scene_save_name.h"
+#include "scene/ibutton_scene_save_success.h"
+#include "scene/ibutton_scene_info.h"
+#include "scene/ibutton_scene_select_key.h"
+#include "scene/ibutton_scene_add_type.h"
+#include "scene/ibutton_scene_add_value.h"
 
-#include "helpers/key-worker.h"
+#include "helpers/key_worker.h"
 
 #include "one_wire_master.h"
 #include "maxim_crc.h"
-#include "ibutton-key.h"
+#include "ibutton_key.h"
 
-#include <notification/notification-messages.h>
+#include <notification/notification_messages.h>
 #include <storage/storage.h>
 #include <dialogs/dialogs.h>
 
-#include <record-controller.hpp>
+#include <record_controller.hpp>
 
 class iButtonApp {
 public:

applications/ibutton/ibutton_cli.cpp

@@ -1,11 +1,11 @@
 #include <furi.h>
-#include <furi-hal.h>
+#include <furi_hal.h>
 #include <stdarg.h>
 #include <cli/cli.h>
 #include <lib/toolbox/args.h>
 
-#include "helpers/key-info.h"
-#include "helpers/key-worker.h"
+#include "helpers/key_info.h"
+#include "helpers/key_worker.h"
 
 #include <memory>
 

applications/ibutton/ibutton_key.cpp

@@ -1,4 +1,4 @@
-#include "ibutton-key.h"
+#include "ibutton_key.h"
 #include <furi.h>
 
 uint8_t iButtonKey::get_size() {

applications/ibutton/ibutton_key.h

@@ -1,6 +1,6 @@
 #pragma once
 #include <stdint.h>
-#include "helpers/key-info.h"
+#include "helpers/key_info.h"
 
 class iButtonKey {
 public:

applications/ibutton/ibutton_view_manager.cpp

@@ -1,5 +1,5 @@
-#include "ibutton-view-manager.h"
-#include "ibutton-event.h"
+#include "ibutton_view_manager.h"
+#include "ibutton_event.h"
 #include <callback-connector.h>
 
 iButtonAppViewManager::iButtonAppViewManager() {

applications/ibutton/ibutton_view_manager.h

@@ -7,7 +7,7 @@
 #include <gui/modules/byte_input.h>
 #include <gui/modules/popup.h>
 #include <gui/modules/widget.h>
-#include "ibutton-event.h"
+#include "ibutton_event.h"
 
 class iButtonAppViewManager {
 public:

applications/ibutton/scene/ibutton_scene_add_type.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-add-type.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_add_type.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 typedef enum {

applications/ibutton/scene/ibutton_scene_add_type.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneAddType : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_add_value.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-add-value.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_add_value.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 void iButtonSceneAddValue::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_add_value.h

@@ -1,6 +1,6 @@
 #pragma once
-#include "ibutton-scene-generic.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_generic.h"
+#include "../ibutton_key.h"
 
 class iButtonSceneAddValue : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_delete_confirm.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-delete-confirm.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_delete_confirm.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 void iButtonSceneDeleteConfirm::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_delete_confirm.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneDeleteConfirm : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_delete_success.cpp

@@ -1,8 +1,8 @@
-#include "ibutton-scene-delete-success.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_delete_success.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 #include <callback-connector.h>
 
 void iButtonSceneDeleteSuccess::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_delete_success.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneDeleteSuccess : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_emulate.cpp

@@ -1,8 +1,8 @@
-#include "ibutton-scene-emulate.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_emulate.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 #include <callback-connector.h>
 
 void iButtonSceneEmulate::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_emulate.h

@@ -1,6 +1,6 @@
 #pragma once
-#include "ibutton-scene-generic.h"
-#include "../helpers/key-emulator.h"
+#include "ibutton_scene_generic.h"
+#include "../helpers/key_emulator.h"
 
 class iButtonSceneEmulate : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_generic.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "../ibutton-event.h"
+#include "../ibutton_event.h"
 
 class iButtonApp;
 

applications/ibutton/scene/ibutton_scene_info.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-info.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_info.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 void iButtonSceneInfo::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_info.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneInfo : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_read.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-read.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_read.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 
 void iButtonSceneRead::on_enter(iButtonApp* app) {
     iButtonAppViewManager* view_manager = app->get_view_manager();

applications/ibutton/scene/ibutton_scene_read.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneRead : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_read_crc_error.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-read-crc-error.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_read_crc_error.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 void iButtonSceneReadCRCError::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_read_crc_error.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 #include <gui/modules/dialog_ex.h>
 
 class iButtonSceneReadCRCError : public iButtonScene {

applications/ibutton/scene/ibutton_scene_read_not_key_error.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-read-not-key-error.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_read_not_key_error.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 void iButtonSceneReadNotKeyError::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_read_not_key_error.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 #include <gui/modules/dialog_ex.h>
 
 class iButtonSceneReadNotKeyError : public iButtonScene {

applications/ibutton/scene/ibutton_scene_read_success.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-read-success.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_read_success.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 void iButtonSceneReadSuccess::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_read_success.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 #include <gui/modules/dialog_ex.h>
 
 class iButtonSceneReadSuccess : public iButtonScene {

applications/ibutton/scene/ibutton_scene_readed_key_menu.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-readed-key-menu.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_readed_key_menu.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 typedef enum {

applications/ibutton/scene/ibutton_scene_readed_key_menu.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneReadedKeyMenu : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_save_name.cpp

@@ -1,8 +1,8 @@
-#include "ibutton-scene-save-name.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_save_name.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 #include <callback-connector.h>
 #include <lib/toolbox/random_name.h>
 

applications/ibutton/scene/ibutton_scene_save_name.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneSaveName : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_save_success.cpp

@@ -1,8 +1,8 @@
-#include "ibutton-scene-save-success.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_save_success.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 #include <callback-connector.h>
 
 void iButtonSceneSaveSuccess::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_save_success.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneSaveSuccess : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_saved_key_menu.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-saved-key-menu.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_saved_key_menu.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 typedef enum {

applications/ibutton/scene/ibutton_scene_saved_key_menu.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneSavedKeyMenu : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_select_key.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-select-key.h"
-#include "../ibutton-app.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_select_key.h"
+#include "../ibutton_app.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 
 void iButtonSceneSelectKey::on_enter(iButtonApp* app) {
     // Process file_select return

applications/ibutton/scene/ibutton_scene_select_key.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneSelectKey : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_start.cpp

@@ -1,7 +1,7 @@
-#include "ibutton-scene-start.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
+#include "ibutton_scene_start.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
 #include <callback-connector.h>
 
 typedef enum {

applications/ibutton/scene/ibutton_scene_start.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneStart : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_write.cpp

@@ -1,8 +1,8 @@
-#include "ibutton-scene-write.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_write.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 
 void iButtonSceneWrite::on_enter(iButtonApp* app) {
     iButtonAppViewManager* view_manager = app->get_view_manager();

applications/ibutton/scene/ibutton_scene_write.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneWrite : public iButtonScene {
 public:

applications/ibutton/scene/ibutton_scene_write_success.cpp

@@ -1,8 +1,8 @@
-#include "ibutton-scene-write-success.h"
-#include "../ibutton-app.h"
-#include "../ibutton-view-manager.h"
-#include "../ibutton-event.h"
-#include "../ibutton-key.h"
+#include "ibutton_scene_write_success.h"
+#include "../ibutton_app.h"
+#include "../ibutton_view_manager.h"
+#include "../ibutton_event.h"
+#include "../ibutton_key.h"
 #include <callback-connector.h>
 
 void iButtonSceneWriteSuccess::on_enter(iButtonApp* app) {

applications/ibutton/scene/ibutton_scene_write_success.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "ibutton-scene-generic.h"
+#include "ibutton_scene_generic.h"
 
 class iButtonSceneWriteSuccess : public iButtonScene {
 public: