Naming and coding style convention, new linter tool. (#945)

* Makefile, Scripts: new linter
* About: remove ID from IC
* Firmware: remove double define for DIVC/DIVR
* Scripts: check folder names too. Docker: replace syntax check with make lint.
* Reformat Sources and Migrate to new file naming convention
* Docker: symlink clang-format-12 to clang-format
* Add coding style guide
This commit is contained in:
あく
2022-01-05 19:10:18 +03:00
committed by GitHub
parent c98e54da10
commit 389ff92cc1
899 changed files with 379245 additions and 373421 deletions
@@ -1,6 +1,6 @@
#include "decoder-analyzer.h"
#include "decoder_analyzer.h"
#include <furi.h>
#include <furi-hal.h>
#include <furi_hal.h>
bool DecoderAnalyzer::read(uint8_t* _data, uint8_t _data_size) {
bool result = false;
@@ -1,7 +1,7 @@
#include "emmarin.h"
#include "decoder-emmarin.h"
#include "decoder_emmarin.h"
#include <furi.h>
#include <furi-hal.h>
#include <furi_hal.h>
constexpr uint32_t clocks_in_us = 64;
constexpr uint32_t short_time = 255 * clocks_in_us;
@@ -1,8 +1,8 @@
#pragma once
#include <stdint.h>
#include <atomic>
#include <lib/toolbox/manchester-decoder.h>
#include "protocols/protocol-emmarin.h"
#include <lib/toolbox/manchester_decoder.h>
#include "protocols/protocol_emmarin.h"
class DecoderEMMarin {
public:
bool read(uint8_t* data, uint8_t data_size);
@@ -1,6 +1,6 @@
#include "decoder-gpio-out.h"
#include "decoder_gpio_out.h"
#include <furi.h>
#include <furi-hal.h>
#include <furi_hal.h>
void DecoderGpioOut::process_front(bool polarity, uint32_t time) {
hal_gpio_write(&gpio_ext_pa7, polarity);
@@ -1,5 +1,5 @@
#include "decoder-hid26.h"
#include <furi-hal.h>
#include "decoder_hid26.h"
#include <furi_hal.h>
constexpr uint32_t clocks_in_us = 64;
@@ -1,7 +1,7 @@
#pragma once
#include <stdint.h>
#include <atomic>
#include "protocols/protocol-hid-h10301.h"
#include "protocols/protocol_hid_h10301.h"
class DecoderHID26 {
public:
@@ -1,5 +1,5 @@
#include "decoder-indala.h"
#include <furi-hal.h>
#include "decoder_indala.h"
#include <furi_hal.h>
constexpr uint32_t clocks_in_us = 64;
constexpr uint32_t us_per_bit = 255;
@@ -2,7 +2,7 @@
#include <stdint.h>
#include <limits.h>
#include <atomic>
#include "protocols/protocol-indala-40134.h"
#include "protocols/protocol_indala_40134.h"
class DecoderIndala {
public:
@@ -1,5 +1,5 @@
#include "encoder-emmarin.h"
#include "protocols/protocol-emmarin.h"
#include "encoder_emmarin.h"
#include "protocols/protocol_emmarin.h"
#include <furi.h>
void EncoderEM::init(const uint8_t* data, const uint8_t data_size) {
@@ -1,5 +1,5 @@
#pragma once
#include "encoder-generic.h"
#include "encoder_generic.h"
class EncoderEM : public EncoderGeneric {
public:
@@ -1,5 +1,5 @@
#include "encoder-hid-h10301.h"
#include "protocols/protocol-hid-h10301.h"
#include "encoder_hid_h10301.h"
#include "protocols/protocol_hid_h10301.h"
#include <furi.h>
void EncoderHID_H10301::init(const uint8_t* data, const uint8_t data_size) {
@@ -1,6 +1,6 @@
#pragma once
#include "encoder-generic.h"
#include "osc-fsk.h"
#include "encoder_generic.h"
#include "osc_fsk.h"
class EncoderHID_H10301 : public EncoderGeneric {
public:
@@ -1,5 +1,5 @@
#include "encoder-indala-40134.h"
#include "protocols/protocol-indala-40134.h"
#include "encoder_indala_40134.h"
#include "protocols/protocol_indala_40134.h"
#include <furi.h>
void EncoderIndala_40134::init(const uint8_t* data, const uint8_t data_size) {
@@ -1,5 +1,5 @@
#pragma once
#include "encoder-generic.h"
#include "encoder_generic.h"
class EncoderIndala_40134 : public EncoderGeneric {
public:
@@ -1,4 +1,4 @@
#include "key-info.h"
#include "key_info.h"
#include <string.h>
const char* lfrfid_key_get_type_string(LfrfidKeyType type) {
@@ -1,4 +1,4 @@
#include "osc-fsk.h"
#include "osc_fsk.h"
OscFSK::OscFSK(uint16_t _freq_low, uint16_t _freq_hi, uint16_t _osc_phase_max)
: freq{_freq_low, _freq_hi}
@@ -1,4 +1,4 @@
#include "protocol-emmarin.h"
#include "protocol_emmarin.h"
#include <furi.h>
#define EM_HEADER_POS 55
@@ -1,5 +1,5 @@
#pragma once
#include "protocol-generic.h"
#include "protocol_generic.h"
class ProtocolEMMarin : public ProtocolGeneric {
public:
@@ -1,4 +1,4 @@
#include "protocol-hid-h10301.h"
#include "protocol_hid_h10301.h"
#include <furi.h>
typedef uint32_t HID10301CardData;
@@ -1,5 +1,5 @@
#pragma once
#include "protocol-generic.h"
#include "protocol_generic.h"
class ProtocolHID10301 : public ProtocolGeneric {
public:
@@ -1,4 +1,4 @@
#include "protocol-indala-40134.h"
#include "protocol_indala_40134.h"
#include <furi.h>
typedef uint64_t Indala40134CardData;
@@ -1,5 +1,5 @@
#pragma once
#include "protocol-generic.h"
#include "protocol_generic.h"
class ProtocolIndala40134 : public ProtocolGeneric {
public:
@@ -1,4 +1,4 @@
#include "pulse-joiner.h"
#include "pulse_joiner.h"
#include <furi.h>
bool PulseJoiner::push_pulse(bool polarity, uint16_t period, uint16_t pulse) {
@@ -1,4 +1,4 @@
#include "rfid-key.h"
#include "rfid_key.h"
#include <furi/check.h>
#include <string.h>
@@ -1,5 +1,5 @@
#pragma once
#include "key-info.h"
#include "key_info.h"
#include <array>
class RfidKey {
@@ -1,6 +1,6 @@
#include "rfid-reader.h"
#include "rfid_reader.h"
#include <furi.h>
#include <furi-hal.h>
#include <furi_hal.h>
#include <stm32wbxx_ll_cortex.h>
#include <tim.h>
@@ -1,10 +1,10 @@
#pragma once
//#include "decoder-analyzer.h"
#include "decoder-gpio-out.h"
#include "decoder-emmarin.h"
#include "decoder-hid26.h"
#include "decoder-indala.h"
#include "key-info.h"
//#include "decoder_analyzer.h"
#include "decoder_gpio_out.h"
#include "decoder_emmarin.h"
#include "decoder_hid26.h"
#include "decoder_indala.h"
#include "key_info.h"
//#define RFID_GPIO_DEBUG 1
@@ -1,4 +1,4 @@
#include "rfid-timer-emulator.h"
#include "rfid_timer_emulator.h"
extern TIM_HandleTypeDef htim1;
@@ -1,11 +1,11 @@
#pragma once
#include <furi-hal.h>
#include "key-info.h"
#include "encoder-generic.h"
#include "encoder-emmarin.h"
#include "encoder-hid-h10301.h"
#include "encoder-indala-40134.h"
#include "pulse-joiner.h"
#include <furi_hal.h>
#include "key_info.h"
#include "encoder_generic.h"
#include "encoder_emmarin.h"
#include "encoder_hid_h10301.h"
#include "encoder_indala_40134.h"
#include "pulse_joiner.h"
#include <map>
class RfidTimerEmulator {
@@ -1,4 +1,4 @@
#include "rfid-worker.h"
#include "rfid_worker.h"
RfidWorker::RfidWorker() {
}
@@ -1,10 +1,10 @@
#pragma once
#include "key-info.h"
#include "rfid-reader.h"
#include "rfid-writer.h"
#include "rfid-timer-emulator.h"
#include "rfid-key.h"
#include "state-sequencer.h"
#include "key_info.h"
#include "rfid_reader.h"
#include "rfid_writer.h"
#include "rfid_timer_emulator.h"
#include "rfid_key.h"
#include "state_sequencer.h"
class RfidWorker {
public:
@@ -1,8 +1,8 @@
#include "rfid-writer.h"
#include <furi-hal.h>
#include "protocols/protocol-emmarin.h"
#include "protocols/protocol-hid-h10301.h"
#include "protocols/protocol-indala-40134.h"
#include "rfid_writer.h"
#include <furi_hal.h>
#include "protocols/protocol_emmarin.h"
#include "protocols/protocol_hid_h10301.h"
#include "protocols/protocol_indala_40134.h"
extern COMP_HandleTypeDef hcomp1;
@@ -1,4 +1,4 @@
#include "state-sequencer.h"
#include "state_sequencer.h"
#include "stdio.h"
TickSequencer::TickSequencer() {
@@ -1,20 +1,20 @@
#include "lfrfid-app.h"
#include "scene/lfrfid-app-scene-start.h"
#include "scene/lfrfid-app-scene-read.h"
#include "scene/lfrfid-app-scene-read-success.h"
#include "scene/lfrfid-app-scene-readed-menu.h"
#include "scene/lfrfid-app-scene-write.h"
#include "scene/lfrfid-app-scene-write-success.h"
#include "scene/lfrfid-app-scene-emulate.h"
#include "scene/lfrfid-app-scene-save-name.h"
#include "scene/lfrfid-app-scene-save-success.h"
#include "scene/lfrfid-app-scene-select-key.h"
#include "scene/lfrfid-app-scene-saved-key-menu.h"
#include "scene/lfrfid-app-scene-save-data.h"
#include "scene/lfrfid-app-scene-save-type.h"
#include "scene/lfrfid-app-scene-saved-info.h"
#include "scene/lfrfid-app-scene-delete-confirm.h"
#include "scene/lfrfid-app-scene-delete-success.h"
#include "lfrfid_app.h"
#include "scene/lfrfid_app_scene_start.h"
#include "scene/lfrfid_app_scene_read.h"
#include "scene/lfrfid_app_scene_read_success.h"
#include "scene/lfrfid_app_scene_readed_menu.h"
#include "scene/lfrfid_app_scene_write.h"
#include "scene/lfrfid_app_scene_write_success.h"
#include "scene/lfrfid_app_scene_emulate.h"
#include "scene/lfrfid_app_scene_save_name.h"
#include "scene/lfrfid_app_scene_save_success.h"
#include "scene/lfrfid_app_scene_select_key.h"
#include "scene/lfrfid_app_scene_saved_key_menu.h"
#include "scene/lfrfid_app_scene_save_data.h"
#include "scene/lfrfid_app_scene_save_type.h"
#include "scene/lfrfid_app_scene_saved_info.h"
#include "scene/lfrfid_app_scene_delete_confirm.h"
#include "scene/lfrfid_app_scene_delete_success.h"
#include <toolbox/path.h>
#include <flipper_file/flipper_file.h>
@@ -1,25 +1,25 @@
#pragma once
#include <furi.h>
#include <furi-hal.h>
#include <furi_hal.h>
#include <generic-scene.hpp>
#include <scene-controller.hpp>
#include <view-controller.hpp>
#include <record-controller.hpp>
#include <text-store.h>
#include <generic_scene.hpp>
#include <scene_controller.hpp>
#include <view_controller.hpp>
#include <record_controller.hpp>
#include <text_store.h>
#include <view-modules/submenu-vm.h>
#include <view-modules/popup-vm.h>
#include <view-modules/dialog-ex-vm.h>
#include <view-modules/text-input-vm.h>
#include <view-modules/byte-input-vm.h>
#include "view/container-vm.h"
#include <view_modules/submenu_vm.h>
#include <view_modules/popup_vm.h>
#include <view_modules/dialog_ex_vm.h>
#include <view_modules/text_input_vm.h>
#include <view_modules/byte_input_vm.h>
#include "view/container_vm.h"
#include <notification/notification-messages.h>
#include <notification/notification_messages.h>
#include <storage/storage.h>
#include <dialogs/dialogs.h>
#include "helpers/rfid-worker.h"
#include "helpers/rfid_worker.h"
class LfRfidApp {
public:
@@ -86,4 +86,4 @@ public:
bool save_key_data(const char* path, RfidKey* key);
void make_app_folder();
};
};
@@ -1,4 +1,4 @@
#include "lfrfid-app.h"
#include "lfrfid_app.h"
// app enter function
extern "C" int32_t lfrfid_app(void* args) {
@@ -1,11 +1,11 @@
#include <furi.h>
#include <furi-hal.h>
#include <furi_hal.h>
#include <stdarg.h>
#include <cli/cli.h>
#include <lib/toolbox/args.h>
#include "helpers/rfid-reader.h"
#include "helpers/rfid-timer-emulator.h"
#include "helpers/rfid_reader.h"
#include "helpers/rfid_timer_emulator.h"
void lfrfid_cli(Cli* cli, string_t args, void* context);
@@ -1,7 +1,7 @@
#include "lfrfid-app-scene-delete-confirm.h"
#include "../view/elements/button-element.h"
#include "../view/elements/icon-element.h"
#include "../view/elements/string-element.h"
#include "lfrfid_app_scene_delete_confirm.h"
#include "../view/elements/button_element.h"
#include "../view/elements/icon_element.h"
#include "../view/elements/string_element.h"
void LfRfidAppSceneDeleteConfirm::on_enter(LfRfidApp* app, bool need_restore) {
string_init(string_data);
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneDeleteConfirm : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-delete-success.h"
#include "lfrfid_app_scene_delete_success.h"
void LfRfidAppSceneDeleteSuccess::on_enter(LfRfidApp* app, bool need_restore) {
auto popup = app->view_controller.get<PopupVM>();
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneDeleteSuccess : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-emulate.h"
#include "lfrfid_app_scene_emulate.h"
void LfRfidAppSceneEmulate::on_enter(LfRfidApp* app, bool need_restore) {
string_init(data_string);
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneEmulate : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-read.h"
#include "lfrfid_app_scene_read.h"
void LfRfidAppSceneRead::on_enter(LfRfidApp* app, bool need_restore) {
auto popup = app->view_controller.get<PopupVM>();
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneRead : public GenericScene<LfRfidApp> {
public:
@@ -1,7 +1,7 @@
#include "lfrfid-app-scene-read-success.h"
#include "../view/elements/button-element.h"
#include "../view/elements/icon-element.h"
#include "../view/elements/string-element.h"
#include "lfrfid_app_scene_read_success.h"
#include "../view/elements/button_element.h"
#include "../view/elements/icon_element.h"
#include "../view/elements/string_element.h"
void LfRfidAppSceneReadSuccess::on_enter(LfRfidApp* app, bool need_restore) {
string_init(string[0]);
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneReadSuccess : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-readed-menu.h"
#include "lfrfid_app_scene_readed_menu.h"
typedef enum {
SubmenuWrite,
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneReadedMenu : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-save-data.h"
#include "lfrfid_app_scene_save_data.h"
static void print_buffer(const uint8_t* buffer) {
for(uint8_t i = 0; i < LFRFID_KEY_SIZE; i++) {
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSaveData : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-save-name.h"
#include "lfrfid_app_scene_save_name.h"
#include <lib/toolbox/random_name.h>
void LfRfidAppSceneSaveName::on_enter(LfRfidApp* app, bool need_restore) {
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSaveName : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-save-success.h"
#include "lfrfid_app_scene_save_success.h"
void LfRfidAppSceneSaveSuccess::on_enter(LfRfidApp* app, bool need_restore) {
auto popup = app->view_controller.get<PopupVM>();
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSaveSuccess : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-save-type.h"
#include "lfrfid_app_scene_save_type.h"
void LfRfidAppSceneSaveType::on_enter(LfRfidApp* app, bool need_restore) {
auto submenu = app->view_controller.get<SubmenuVM>();
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSaveType : public GenericScene<LfRfidApp> {
public:
@@ -1,7 +1,7 @@
#include "lfrfid-app-scene-saved-info.h"
#include "../view/elements/button-element.h"
#include "../view/elements/icon-element.h"
#include "../view/elements/string-element.h"
#include "lfrfid_app_scene_saved_info.h"
#include "../view/elements/button_element.h"
#include "../view/elements/icon_element.h"
#include "../view/elements/string_element.h"
void LfRfidAppSceneSavedInfo::on_enter(LfRfidApp* app, bool need_restore) {
string_init(string_data);
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSavedInfo : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-saved-key-menu.h"
#include "lfrfid_app_scene_saved_key_menu.h"
typedef enum {
SubmenuEmulate,
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSavedKeyMenu : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-select-key.h"
#include "lfrfid_app_scene_select_key.h"
void LfRfidAppSceneSelectKey::on_enter(LfRfidApp* app, bool need_restore) {
if(app->load_key_from_file_select(need_restore)) {
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneSelectKey : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-start.h"
#include "lfrfid_app_scene_start.h"
typedef enum {
SubmenuRead,
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneStart : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-write.h"
#include "lfrfid_app_scene_write.h"
void LfRfidAppSceneWrite::on_enter(LfRfidApp* app, bool need_restore) {
card_not_supported = false;
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneWrite : public GenericScene<LfRfidApp> {
public:
@@ -1,4 +1,4 @@
#include "lfrfid-app-scene-write-success.h"
#include "lfrfid_app_scene_write_success.h"
void LfRfidAppSceneWriteSuccess::on_enter(LfRfidApp* app, bool need_restore) {
auto popup = app->view_controller.get<PopupVM>();
@@ -1,5 +1,5 @@
#pragma once
#include "../lfrfid-app.h"
#include "../lfrfid_app.h"
class LfRfidAppSceneWriteSuccess : public GenericScene<LfRfidApp> {
public:
@@ -1,8 +1,8 @@
#include "container-vm.h"
#include "elements/generic-element.h"
#include "elements/string-element.h"
#include "elements/icon-element.h"
#include "elements/button-element.h"
#include "container_vm.h"
#include "elements/generic_element.h"
#include "elements/string_element.h"
#include "elements/icon_element.h"
#include "elements/button_element.h"
#include <list>
class ContainerVMData {
@@ -1,5 +1,5 @@
#pragma once
#include <view-modules/generic-view-module.h>
#include <view_modules/generic_view_module.h>
class ContainerVM : public GenericViewModule {
public:
@@ -14,4 +14,4 @@ private:
View* view;
static void view_draw_callback(Canvas* canvas, void* model);
static bool view_input_callback(InputEvent* event, void* context);
};
};
@@ -1,4 +1,4 @@
#include "button-element.h"
#include "button_element.h"
#include <gui/elements.h>
ButtonElement::ButtonElement() {
@@ -1,5 +1,5 @@
#pragma once
#include "generic-element.h"
#include "generic_element.h"
typedef void (*ButtonElementCallback)(void* context);
@@ -1,4 +1,4 @@
#include "generic-element.h"
#include "generic_element.h"
void GenericElement::lock_model() {
furi_assert(view != nullptr);
@@ -1,4 +1,4 @@
#include "icon-element.h"
#include "icon_element.h"
IconElement::IconElement() {
}
@@ -1,5 +1,5 @@
#pragma once
#include "generic-element.h"
#include "generic_element.h"
class IconElement : public GenericElement {
public:
@@ -1,4 +1,4 @@
#include "string-element.h"
#include "string_element.h"
#include <gui/elements.h>
StringElement::StringElement() {
@@ -1,5 +1,5 @@
#pragma once
#include "generic-element.h"
#include "generic_element.h"
class StringElement : public GenericElement {
public: