Naming and coding style convention, new linter tool. (#945)

* Makefile, Scripts: new linter
* About: remove ID from IC
* Firmware: remove double define for DIVC/DIVR
* Scripts: check folder names too. Docker: replace syntax check with make lint.
* Reformat Sources and Migrate to new file naming convention
* Docker: symlink clang-format-12 to clang-format
* Add coding style guide

applications/lfrfid/helpers/decoder_analyzer.cpp

@@ -1,6 +1,6 @@
-#include "decoder-analyzer.h"
+#include "decoder_analyzer.h"
 #include <furi.h>
-#include <furi-hal.h>
+#include <furi_hal.h>
 
 bool DecoderAnalyzer::read(uint8_t* _data, uint8_t _data_size) {
     bool result = false;

applications/lfrfid/helpers/decoder_emmarin.cpp

@@ -1,7 +1,7 @@
 #include "emmarin.h"
-#include "decoder-emmarin.h"
+#include "decoder_emmarin.h"
 #include <furi.h>
-#include <furi-hal.h>
+#include <furi_hal.h>
 
 constexpr uint32_t clocks_in_us = 64;
 constexpr uint32_t short_time = 255 * clocks_in_us;

applications/lfrfid/helpers/decoder_emmarin.h

@@ -1,8 +1,8 @@
 #pragma once
 #include <stdint.h>
 #include <atomic>
-#include <lib/toolbox/manchester-decoder.h>
-#include "protocols/protocol-emmarin.h"
+#include <lib/toolbox/manchester_decoder.h>
+#include "protocols/protocol_emmarin.h"
 class DecoderEMMarin {
 public:
     bool read(uint8_t* data, uint8_t data_size);

applications/lfrfid/helpers/decoder_gpio_out.cpp

@@ -1,6 +1,6 @@
-#include "decoder-gpio-out.h"
+#include "decoder_gpio_out.h"
 #include <furi.h>
-#include <furi-hal.h>
+#include <furi_hal.h>
 
 void DecoderGpioOut::process_front(bool polarity, uint32_t time) {
     hal_gpio_write(&gpio_ext_pa7, polarity);

applications/lfrfid/helpers/decoder_hid26.cpp

@@ -1,5 +1,5 @@
-#include "decoder-hid26.h"
-#include <furi-hal.h>
+#include "decoder_hid26.h"
+#include <furi_hal.h>
 
 constexpr uint32_t clocks_in_us = 64;
 

applications/lfrfid/helpers/decoder_hid26.h

@@ -1,7 +1,7 @@
 #pragma once
 #include <stdint.h>
 #include <atomic>
-#include "protocols/protocol-hid-h10301.h"
+#include "protocols/protocol_hid_h10301.h"
 
 class DecoderHID26 {
 public:

applications/lfrfid/helpers/decoder_indala.cpp

@@ -1,5 +1,5 @@
-#include "decoder-indala.h"
-#include <furi-hal.h>
+#include "decoder_indala.h"
+#include <furi_hal.h>
 
 constexpr uint32_t clocks_in_us = 64;
 constexpr uint32_t us_per_bit = 255;

applications/lfrfid/helpers/decoder_indala.h

@@ -2,7 +2,7 @@
 #include <stdint.h>
 #include <limits.h>
 #include <atomic>
-#include "protocols/protocol-indala-40134.h"
+#include "protocols/protocol_indala_40134.h"
 
 class DecoderIndala {
 public:

applications/lfrfid/helpers/encoder_emmarin.cpp

@@ -1,5 +1,5 @@
-#include "encoder-emmarin.h"
-#include "protocols/protocol-emmarin.h"
+#include "encoder_emmarin.h"
+#include "protocols/protocol_emmarin.h"
 #include <furi.h>
 
 void EncoderEM::init(const uint8_t* data, const uint8_t data_size) {

applications/lfrfid/helpers/encoder_emmarin.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "encoder-generic.h"
+#include "encoder_generic.h"
 
 class EncoderEM : public EncoderGeneric {
 public:

applications/lfrfid/helpers/encoder_hid_h10301.cpp

@@ -1,5 +1,5 @@
-#include "encoder-hid-h10301.h"
-#include "protocols/protocol-hid-h10301.h"
+#include "encoder_hid_h10301.h"
+#include "protocols/protocol_hid_h10301.h"
 #include <furi.h>
 
 void EncoderHID_H10301::init(const uint8_t* data, const uint8_t data_size) {

applications/lfrfid/helpers/encoder_hid_h10301.h

@@ -1,6 +1,6 @@
 #pragma once
-#include "encoder-generic.h"
-#include "osc-fsk.h"
+#include "encoder_generic.h"
+#include "osc_fsk.h"
 
 class EncoderHID_H10301 : public EncoderGeneric {
 public:

applications/lfrfid/helpers/encoder_indala_40134.cpp

@@ -1,5 +1,5 @@
-#include "encoder-indala-40134.h"
-#include "protocols/protocol-indala-40134.h"
+#include "encoder_indala_40134.h"
+#include "protocols/protocol_indala_40134.h"
 #include <furi.h>
 
 void EncoderIndala_40134::init(const uint8_t* data, const uint8_t data_size) {

applications/lfrfid/helpers/encoder_indala_40134.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "encoder-generic.h"
+#include "encoder_generic.h"
 
 class EncoderIndala_40134 : public EncoderGeneric {
 public:

applications/lfrfid/helpers/key_info.cpp

@@ -1,4 +1,4 @@
-#include "key-info.h"
+#include "key_info.h"
 #include <string.h>
 
 const char* lfrfid_key_get_type_string(LfrfidKeyType type) {

applications/lfrfid/helpers/osc_fsk.cpp

@@ -1,4 +1,4 @@
-#include "osc-fsk.h"
+#include "osc_fsk.h"
 
 OscFSK::OscFSK(uint16_t _freq_low, uint16_t _freq_hi, uint16_t _osc_phase_max)
     : freq{_freq_low, _freq_hi}

applications/lfrfid/helpers/protocols/protocol_emmarin.cpp

@@ -1,4 +1,4 @@
-#include "protocol-emmarin.h"
+#include "protocol_emmarin.h"
 #include <furi.h>
 
 #define EM_HEADER_POS 55

applications/lfrfid/helpers/protocols/protocol_emmarin.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "protocol-generic.h"
+#include "protocol_generic.h"
 
 class ProtocolEMMarin : public ProtocolGeneric {
 public:

applications/lfrfid/helpers/protocols/protocol_hid_h10301.cpp

@@ -1,4 +1,4 @@
-#include "protocol-hid-h10301.h"
+#include "protocol_hid_h10301.h"
 #include <furi.h>
 
 typedef uint32_t HID10301CardData;

applications/lfrfid/helpers/protocols/protocol_hid_h10301.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "protocol-generic.h"
+#include "protocol_generic.h"
 
 class ProtocolHID10301 : public ProtocolGeneric {
 public:

applications/lfrfid/helpers/protocols/protocol_indala_40134.cpp

@@ -1,4 +1,4 @@
-#include "protocol-indala-40134.h"
+#include "protocol_indala_40134.h"
 #include <furi.h>
 
 typedef uint64_t Indala40134CardData;

applications/lfrfid/helpers/protocols/protocol_indala_40134.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "protocol-generic.h"
+#include "protocol_generic.h"
 
 class ProtocolIndala40134 : public ProtocolGeneric {
 public:

applications/lfrfid/helpers/pulse_joiner.cpp

@@ -1,4 +1,4 @@
-#include "pulse-joiner.h"
+#include "pulse_joiner.h"
 #include <furi.h>
 
 bool PulseJoiner::push_pulse(bool polarity, uint16_t period, uint16_t pulse) {

applications/lfrfid/helpers/rfid_key.cpp

@@ -1,4 +1,4 @@
-#include "rfid-key.h"
+#include "rfid_key.h"
 #include <furi/check.h>
 #include <string.h>
 

applications/lfrfid/helpers/rfid_key.h

@@ -1,5 +1,5 @@
 #pragma once
-#include "key-info.h"
+#include "key_info.h"
 #include <array>
 
 class RfidKey {

applications/lfrfid/helpers/rfid_reader.cpp

@@ -1,6 +1,6 @@
-#include "rfid-reader.h"
+#include "rfid_reader.h"
 #include <furi.h>
-#include <furi-hal.h>
+#include <furi_hal.h>
 #include <stm32wbxx_ll_cortex.h>
 #include <tim.h>
 

applications/lfrfid/helpers/rfid_reader.h

@@ -1,10 +1,10 @@
 #pragma once
-//#include "decoder-analyzer.h"
-#include "decoder-gpio-out.h"
-#include "decoder-emmarin.h"
-#include "decoder-hid26.h"
-#include "decoder-indala.h"
-#include "key-info.h"
+//#include "decoder_analyzer.h"
+#include "decoder_gpio_out.h"
+#include "decoder_emmarin.h"
+#include "decoder_hid26.h"
+#include "decoder_indala.h"
+#include "key_info.h"
 
 //#define RFID_GPIO_DEBUG 1
 

applications/lfrfid/helpers/rfid_timer_emulator.cpp

@@ -1,4 +1,4 @@
-#include "rfid-timer-emulator.h"
+#include "rfid_timer_emulator.h"
 
 extern TIM_HandleTypeDef htim1;
 

applications/lfrfid/helpers/rfid_timer_emulator.h

@@ -1,11 +1,11 @@
 #pragma once
-#include <furi-hal.h>
-#include "key-info.h"
-#include "encoder-generic.h"
-#include "encoder-emmarin.h"
-#include "encoder-hid-h10301.h"
-#include "encoder-indala-40134.h"
-#include "pulse-joiner.h"
+#include <furi_hal.h>
+#include "key_info.h"
+#include "encoder_generic.h"
+#include "encoder_emmarin.h"
+#include "encoder_hid_h10301.h"
+#include "encoder_indala_40134.h"
+#include "pulse_joiner.h"
 #include <map>
 
 class RfidTimerEmulator {

applications/lfrfid/helpers/rfid_worker.cpp

@@ -1,4 +1,4 @@
-#include "rfid-worker.h"
+#include "rfid_worker.h"
 
 RfidWorker::RfidWorker() {
 }

applications/lfrfid/helpers/rfid_worker.h

@@ -1,10 +1,10 @@
 #pragma once
-#include "key-info.h"
-#include "rfid-reader.h"
-#include "rfid-writer.h"
-#include "rfid-timer-emulator.h"
-#include "rfid-key.h"
-#include "state-sequencer.h"
+#include "key_info.h"
+#include "rfid_reader.h"
+#include "rfid_writer.h"
+#include "rfid_timer_emulator.h"
+#include "rfid_key.h"
+#include "state_sequencer.h"
 
 class RfidWorker {
 public:

applications/lfrfid/helpers/rfid_writer.cpp

@@ -1,8 +1,8 @@
-#include "rfid-writer.h"
-#include <furi-hal.h>
-#include "protocols/protocol-emmarin.h"
-#include "protocols/protocol-hid-h10301.h"
-#include "protocols/protocol-indala-40134.h"
+#include "rfid_writer.h"
+#include <furi_hal.h>
+#include "protocols/protocol_emmarin.h"
+#include "protocols/protocol_hid_h10301.h"
+#include "protocols/protocol_indala_40134.h"
 
 extern COMP_HandleTypeDef hcomp1;
 

applications/lfrfid/helpers/state_sequencer.cpp

@@ -1,4 +1,4 @@
-#include "state-sequencer.h"
+#include "state_sequencer.h"
 #include "stdio.h"
 
 TickSequencer::TickSequencer() {