[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

applications/infrared/cli/infrared_cli.cpp

@@ -60,6 +60,8 @@ static void signal_received_callback(void* context, InfraredWorkerSignal* receiv
 }
 
 static void infrared_cli_start_ir_rx(Cli* cli, string_t args) {
+    UNUSED(cli);
+    UNUSED(args);
     InfraredWorker* worker = infrared_worker_alloc();
     infrared_worker_rx_start(worker);
     infrared_worker_rx_set_received_signal_callback(worker, signal_received_callback, cli);
@@ -140,6 +142,7 @@ static bool parse_signal_raw(
 }
 
 static void infrared_cli_start_ir_tx(Cli* cli, string_t args) {
+    UNUSED(cli);
     InfraredMessage message;
     const char* str = string_get_cstr(args);
     uint32_t frequency;
@@ -160,6 +163,7 @@ static void infrared_cli_start_ir_tx(Cli* cli, string_t args) {
 }
 
 static void infrared_cli_start_ir(Cli* cli, string_t args, void* context) {
+    UNUSED(context);
     if(furi_hal_infrared_is_busy()) {
         printf("INFRARED is busy. Exit.");
         return;

applications/infrared/infrared_app_event.h

@@ -36,6 +36,7 @@ public:
     };
 
     union {
+        int32_t dummy;
         /** Menu selected event type payload. Selected index. */
         int32_t menu_index;
         /** DialogEx view module event type payload */

applications/infrared/infrared_app_view_manager.cpp

@@ -148,7 +148,7 @@ void InfraredAppViewManager::send_event(InfraredAppEvent* event) {
     osMessageQueuePut(event_queue, event, 0, timeout);
 }
 
-uint32_t InfraredAppViewManager::previous_view_callback(void* context) {
+uint32_t InfraredAppViewManager::previous_view_callback(void*) {
     if(event_queue != NULL) {
         InfraredAppEvent event;
         event.type = InfraredAppEvent::Type::Back;

applications/infrared/scene/infrared_app_scene_ask_back.cpp

@@ -69,5 +69,5 @@ bool InfraredAppSceneAskBack::on_event(InfraredApp* app, InfraredAppEvent* event
     return consumed;
 }
 
-void InfraredAppSceneAskBack::on_exit(InfraredApp* app) {
+void InfraredAppSceneAskBack::on_exit(InfraredApp*) {
 }

applications/infrared/scene/infrared_app_scene_edit_delete.cpp

@@ -96,5 +96,5 @@ bool InfraredAppSceneEditDelete::on_event(InfraredApp* app, InfraredAppEvent* ev
     return consumed;
 }
 
-void InfraredAppSceneEditDelete::on_exit(InfraredApp* app) {
+void InfraredAppSceneEditDelete::on_exit(InfraredApp*) {
 }

applications/infrared/scene/infrared_app_scene_edit_rename_done.cpp

@@ -26,5 +26,5 @@ bool InfraredAppSceneEditRenameDone::on_event(InfraredApp* app, InfraredAppEvent
     return consumed;
 }
 
-void InfraredAppSceneEditRenameDone::on_exit(InfraredApp* app) {
+void InfraredAppSceneEditRenameDone::on_exit(InfraredApp*) {
 }

applications/infrared/scene/infrared_app_scene_learn_enter_name.cpp

@@ -56,5 +56,5 @@ bool InfraredAppSceneLearnEnterName::on_event(InfraredApp* app, InfraredAppEvent
     return consumed;
 }
 
-void InfraredAppSceneLearnEnterName::on_exit(InfraredApp* app) {
+void InfraredAppSceneLearnEnterName::on_exit(InfraredApp*) {
 }

applications/infrared/scene/infrared_app_scene_remote_list.cpp

@@ -40,11 +40,9 @@ void InfraredAppSceneRemoteList::on_enter(InfraredApp* app) {
     }
 }
 
-bool InfraredAppSceneRemoteList::on_event(InfraredApp* app, InfraredAppEvent* event) {
-    bool consumed = false;
-
-    return consumed;
+bool InfraredAppSceneRemoteList::on_event(InfraredApp*, InfraredAppEvent*) {
+    return false;
 }
 
-void InfraredAppSceneRemoteList::on_exit(InfraredApp* app) {
+void InfraredAppSceneRemoteList::on_exit(InfraredApp*) {
 }

applications/infrared/scene/infrared_app_scene_universal_common.cpp

@@ -25,6 +25,7 @@ static void infrared_progress_back_callback(void* context) {
     auto app = static_cast<InfraredApp*>(context);
 
     InfraredAppEvent infrared_event = {
+        .payload = {.dummy = 0},
         .type = InfraredAppEvent::Type::Back,
     };
     app->get_view_manager()->clear_events();
@@ -57,7 +58,10 @@ bool InfraredAppSceneUniversalCommon::on_event(InfraredApp* app, InfraredAppEven
         if(event->type == InfraredAppEvent::Type::Tick) {
             auto view_manager = app->get_view_manager();
             app->notify_blink_send();
-            InfraredAppEvent tick_event = {.type = InfraredAppEvent::Type::Tick};
+            InfraredAppEvent tick_event = {
+                .payload = {.dummy = 0},
+                .type = InfraredAppEvent::Type::Tick,
+            };
             view_manager->send_event(&tick_event);
             bool result = brute_force.send_next_bruteforce();
             if(result) {