[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

applications/nfc/scenes/nfc_scene_delete_success.c

@@ -37,4 +37,4 @@ void nfc_scene_delete_success_on_exit(void* context) {
 
     // Clear view
     popup_reset(nfc->popup);
-}
+}

applications/nfc/scenes/nfc_scene_device_info.c

@@ -21,6 +21,7 @@ void nfc_scene_device_info_dialog_callback(DialogExResult result, void* context)
 }
 
 void nfc_scene_device_info_bank_card_callback(GuiButtonType result, InputType type, void* context) {
+    UNUSED(result);
     Nfc* nfc = context;
     if(type == InputTypeShort) {
         view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventViewExit);

applications/nfc/scenes/nfc_scene_emulate_mifare_ul.c

@@ -5,6 +5,7 @@
 #define NFC_MF_UL_DATA_CHANGED (1UL)
 
 void nfc_emulate_mifare_ul_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     Nfc* nfc = context;
 
     scene_manager_set_scene_state(

applications/nfc/scenes/nfc_scene_emulate_uid.c

@@ -9,6 +9,7 @@ enum {
 };
 
 void nfc_emulate_uid_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     furi_assert(context);
     Nfc* nfc = context;
     view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventWorkerExit);

applications/nfc/scenes/nfc_scene_field.c

@@ -19,6 +19,8 @@ void nfc_scene_field_on_enter(void* context) {
 }
 
 bool nfc_scene_field_on_event(void* context, SceneManagerEvent event) {
+    UNUSED(context);
+    UNUSED(event);
     return false;
 }
 

applications/nfc/scenes/nfc_scene_file_select.c

@@ -11,8 +11,11 @@ void nfc_scene_file_select_on_enter(void* context) {
 }
 
 bool nfc_scene_file_select_on_event(void* context, SceneManagerEvent event) {
+    UNUSED(context);
+    UNUSED(event);
     return false;
 }
 
 void nfc_scene_file_select_on_exit(void* context) {
+    UNUSED(context);
 }

applications/nfc/scenes/nfc_scene_mifare_desfire_app.c

@@ -11,7 +11,7 @@ MifareDesfireApplication* nfc_scene_mifare_desfire_app_get_app(Nfc* nfc) {
     uint32_t app_idx =
         scene_manager_get_scene_state(nfc->scene_manager, NfcSceneMifareDesfireApp) >> 1;
     MifareDesfireApplication* app = nfc->dev->dev_data.mf_df_data.app_head;
-    for(int i = 0; i < app_idx && app; i++) {
+    for(uint32_t i = 0; i < app_idx && app; i++) {
         app = app->next;
     }
     return app;

applications/nfc/scenes/nfc_scene_read_card.c

@@ -2,6 +2,7 @@
 #include <dolphin/dolphin.h>
 
 void nfc_read_card_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     Nfc* nfc = context;
     view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventWorkerExit);
 }

applications/nfc/scenes/nfc_scene_read_emv_app.c

@@ -2,6 +2,7 @@
 #include <dolphin/dolphin.h>
 
 void nfc_read_emv_app_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     Nfc* nfc = context;
     view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventWorkerExit);
 }

applications/nfc/scenes/nfc_scene_read_emv_data.c

@@ -2,6 +2,7 @@
 #include <dolphin/dolphin.h>
 
 void nfc_read_emv_data_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     Nfc* nfc = context;
     view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventWorkerExit);
 }

applications/nfc/scenes/nfc_scene_read_mifare_desfire.c

@@ -2,6 +2,7 @@
 #include <dolphin/dolphin.h>
 
 void nfc_read_mifare_desfire_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     Nfc* nfc = context;
     view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventWorkerExit);
 }

applications/nfc/scenes/nfc_scene_read_mifare_ul.c

@@ -2,6 +2,7 @@
 #include <dolphin/dolphin.h>
 
 void nfc_read_mifare_ul_worker_callback(NfcWorkerEvent event, void* context) {
+    UNUSED(event);
     Nfc* nfc = context;
     view_dispatcher_send_custom_event(nfc->view_dispatcher, NfcCustomEventWorkerExit);
 }