[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

applications/rpc/rpc.c

@@ -102,7 +102,7 @@ static size_t rpc_sprintf_msg_file(
     size_t msg_files_size) {
     size_t cnt = 0;
 
-    for(int i = 0; i < msg_files_size; ++i, ++msg_file) {
+    for(size_t i = 0; i < msg_files_size; ++i, ++msg_file) {
         string_cat_printf(
             str,
             "%s[%c] size: %5ld",
@@ -136,7 +136,7 @@ void rpc_print_data(const char* prefix, uint8_t* buffer, size_t size) {
     string_reserve(str, 100 + size * 5);
 
     string_cat_printf(str, "\r\n%s DEC(%d): {", prefix, size);
-    for(int i = 0; i < size; ++i) {
+    for(size_t i = 0; i < size; ++i) {
         string_cat_printf(str, "%d, ", buffer[i]);
     }
     string_cat_printf(str, "}\r\n");
@@ -146,7 +146,7 @@ void rpc_print_data(const char* prefix, uint8_t* buffer, size_t size) {
     string_reserve(str, 100 + size * 3);
 
     string_cat_printf(str, "%s HEX(%d): {", prefix, size);
-    for(int i = 0; i < size; ++i) {
+    for(size_t i = 0; i < size; ++i) {
         string_cat_printf(str, "%02X", buffer[i]);
     }
     string_cat_printf(str, "}\r\n\r\n");
@@ -573,7 +573,7 @@ static void rpc_session_free_callback(FuriThreadState thread_state, void* contex
     RpcSession* session = (RpcSession*)context;
 
     if(thread_state == FuriThreadStateStopped) {
-        for(int i = 0; i < COUNT_OF(rpc_systems); ++i) {
+        for(size_t i = 0; i < COUNT_OF(rpc_systems); ++i) {
             if(rpc_systems[i].free) {
                 rpc_systems[i].free(session->system_contexts[i]);
             }
@@ -611,7 +611,7 @@ RpcSession* rpc_session_open(Rpc* rpc) {
     session->decoded_message->cb_content.arg = session;
 
     session->system_contexts = malloc(COUNT_OF(rpc_systems) * sizeof(void*));
-    for(int i = 0; i < COUNT_OF(rpc_systems); ++i) {
+    for(size_t i = 0; i < COUNT_OF(rpc_systems); ++i) {
         session->system_contexts[i] = rpc_systems[i].alloc(session);
     }
 
@@ -647,6 +647,7 @@ void rpc_session_close(RpcSession* session) {
 }
 
 int32_t rpc_srv(void* p) {
+    UNUSED(p);
     Rpc* rpc = malloc(sizeof(Rpc));
 
     rpc->busy_mutex = osMutexNew(NULL);

applications/rpc/rpc_cli.c

@@ -38,6 +38,7 @@ static void rpc_session_terminated_callback(void* context) {
 }
 
 void rpc_cli_command_start_session(Cli* cli, string_t args, void* context) {
+    UNUSED(args);
     Rpc* rpc = context;
 
     uint32_t mem_before = memmgr_get_free_heap();

applications/rpc/rpc_storage.c

@@ -31,8 +31,6 @@ typedef struct {
     uint32_t current_command_id;
 } RpcStorageSystem;
 
-void rpc_print_message(const PB_Main* message);
-
 static void rpc_system_storage_reset_state(
     RpcStorageSystem* rpc_storage,
     RpcSession* session,