[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

applications/subghz/scenes/subghz_scene_config.h

@@ -21,4 +21,4 @@ ADD_SCENE(subghz, frequency_analyzer, FrequencyAnalyzer)
 ADD_SCENE(subghz, read_raw, ReadRAW)
 ADD_SCENE(subghz, more_raw, MoreRAW)
 ADD_SCENE(subghz, delete_raw, DeleteRAW)
-ADD_SCENE(subghz, need_saving, NeedSaving)
+ADD_SCENE(subghz, need_saving, NeedSaving)

applications/subghz/scenes/subghz_scene_receiver.c

@@ -191,5 +191,5 @@ bool subghz_scene_receiver_on_event(void* context, SceneManagerEvent event) {
 }
 
 void subghz_scene_receiver_on_exit(void* context) {
-    // SubGhz* subghz = context;
+    UNUSED(context);
 }

applications/subghz/scenes/subghz_scene_receiver_config.c

@@ -61,6 +61,7 @@ uint8_t subghz_scene_receiver_config_hopper_value_index(
     uint8_t values_count,
     void* context) {
     furi_assert(context);
+    UNUSED(values_count);
     SubGhz* subghz = context;
 
     if(value == values[0]) {
@@ -188,7 +189,8 @@ void subghz_scene_receiver_config_on_enter(void* context) {
 }
 
 bool subghz_scene_receiver_config_on_event(void* context, SceneManagerEvent event) {
-    //SubGhz* subghz = context;
+    UNUSED(context);
+    UNUSED(event);
     return false;
 }
 

applications/subghz/scenes/subghz_scene_saved.c

@@ -16,10 +16,11 @@ void subghz_scene_saved_on_enter(void* context) {
 }
 
 bool subghz_scene_saved_on_event(void* context, SceneManagerEvent event) {
-    // SubGhz* subghz = context;
+    UNUSED(context);
+    UNUSED(event);
     return false;
 }
 
 void subghz_scene_saved_on_exit(void* context) {
-    // SubGhz* subghz = context;
+    UNUSED(context);
 }

applications/subghz/scenes/subghz_scene_show_only_rx.c

@@ -26,7 +26,7 @@ void subghz_scene_show_only_rx_on_enter(void* context) {
     view_dispatcher_switch_to_view(subghz->view_dispatcher, SubGhzViewIdPopup);
 }
 
-const bool subghz_scene_show_only_rx_on_event(void* context, SceneManagerEvent event) {
+bool subghz_scene_show_only_rx_on_event(void* context, SceneManagerEvent event) {
     SubGhz* subghz = context;
     if(event.type == SceneManagerEventTypeCustom) {
         if(event.event == SubGhzCustomEventSceneShowOnlyRX) {

applications/subghz/scenes/subghz_scene_test_carrier.c

@@ -26,5 +26,5 @@ bool subghz_scene_test_carrier_on_event(void* context, SceneManagerEvent event)
 }
 
 void subghz_scene_test_carrier_on_exit(void* context) {
-    // SubGhz* subghz = context;
+    UNUSED(context);
 }

applications/subghz/scenes/subghz_scene_test_packet.c

@@ -26,5 +26,5 @@ bool subghz_scene_test_packet_on_event(void* context, SceneManagerEvent event) {
 }
 
 void subghz_scene_test_packet_on_exit(void* context) {
-    // SubGhz* subghz = context;
+    UNUSED(context);
 }

applications/subghz/scenes/subghz_scene_test_static.c

@@ -26,5 +26,5 @@ bool subghz_scene_test_static_on_event(void* context, SceneManagerEvent event) {
 }
 
 void subghz_scene_test_static_on_exit(void* context) {
-    // SubGhz* subghz = context;
+    UNUSED(context);
 }