[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

applications/updater/cli/updater_cli.c

@@ -65,6 +65,8 @@ static const CliSubcommand update_cli_subcommands[] = {
 };
 
 static void updater_cli_ep(Cli* cli, string_t args, void* context) {
+    UNUSED(cli);
+    UNUSED(context);
     string_t subcommand;
     string_init(subcommand);
     if(!args_read_string_and_trim(args, subcommand) || string_empty_p(args)) {
@@ -85,6 +87,7 @@ static void updater_cli_ep(Cli* cli, string_t args, void* context) {
 }
 
 static int32_t updater_spawner_thread_worker(void* arg) {
+    UNUSED(arg);
     Loader* loader = furi_record_open("loader");
     loader_start(loader, "UpdaterApp", NULL);
     furi_record_close("loader");

applications/updater/scenes/updater_scene_config.h

@@ -2,4 +2,4 @@ ADD_SCENE(updater, main, Main)
 #ifndef FURI_RAM_EXEC
 ADD_SCENE(updater, loadcfg, LoadCfg)
 ADD_SCENE(updater, error, Error)
-#endif
+#endif

applications/updater/scenes/updater_scene_loadcfg.c

@@ -102,4 +102,4 @@ void updater_scene_loadcfg_on_exit(void* context) {
 
     widget_reset(updater->widget);
     free(updater->pending_update);
-}
+}

applications/updater/updater.c

@@ -133,4 +133,4 @@ int32_t updater_srv(void* p) {
     updater_free(updater);
 
     return 0;
-}
+}

applications/updater/updater_i.h

@@ -64,4 +64,4 @@ void updater_free(Updater* updater);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

applications/updater/util/update_task.c

@@ -227,4 +227,4 @@ UpdateTaskState const* update_task_get_state(UpdateTask* update_task) {
 UpdateManifest const* update_task_get_manifest(UpdateTask* update_task) {
     furi_assert(update_task);
     return update_task->manifest;
-}
+}

applications/updater/util/update_task.h

@@ -67,4 +67,4 @@ UpdateManifest const* update_task_get_manifest(UpdateTask* update_task);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

applications/updater/util/update_task_worker_flasher.c

@@ -360,4 +360,4 @@ int32_t update_task_worker_flash_writer(void* context) {
     } while(false);
 
     return success ? UPDATE_TASK_NOERR : UPDATE_TASK_FAILED;
-}
+}

applications/updater/views/updater_main.h

@@ -25,4 +25,4 @@ void updater_main_set_storage_pubsub(UpdaterMainView* main_view, FuriPubSubSubsc
 
 FuriPubSubSubscription* updater_main_get_storage_pubsub(UpdaterMainView* main_view);
 
-void updater_main_set_view_dispatcher(UpdaterMainView* main_view, ViewDispatcher* view_dispatcher);
+void updater_main_set_view_dispatcher(UpdaterMainView* main_view, ViewDispatcher* view_dispatcher);