[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

lib/app-scened-template/file_worker.c

@@ -232,6 +232,7 @@ bool file_worker_write_hex(FileWorker* file_worker, const uint8_t* buffer, uint1
 }
 
 void file_worker_show_error(FileWorker* file_worker, const char* error_text) {
+    UNUSED(file_worker);
     DialogsApp* dialogs = furi_record_open("dialogs");
 
     DialogMessage* message = dialog_message_alloc();
@@ -251,6 +252,7 @@ bool file_worker_file_select(
     char* result,
     uint8_t result_size,
     const char* selected_filename) {
+    UNUSED(file_worker);
     DialogsApp* dialogs = furi_record_open("dialogs");
     bool ret =
         dialog_file_select_show(dialogs, path, extension, result, result_size, selected_filename);
@@ -259,6 +261,7 @@ bool file_worker_file_select(
 }
 
 bool file_worker_check_common_errors(FileWorker* file_worker) {
+    UNUSED(file_worker);
     //TODO remove
     /* TODO: [FL-1431] Add return value to file_parser.get_sd_api().check_error() and replace get_fs_info(). */
     return true;

lib/app-scened-template/generic_scene.hpp

@@ -6,4 +6,4 @@ public:
     virtual ~GenericScene(){};
 
 private:
-};
+};

lib/app-scened-template/record_controller.hpp

@@ -43,4 +43,4 @@ public:
 private:
     const char* name;
     TRecordClass* value;
-};
+};

lib/app-scened-template/scene_controller.hpp

@@ -141,7 +141,7 @@ public:
      * @param tick_length_ms tick event length in milliseconds
      */
     void process(
-        uint32_t tick_length_ms = 100,
+        uint32_t /* tick_length_ms */ = 100,
         typename TApp::SceneType start_scene_index = TApp::SceneType::Start) {
         typename TApp::Event event;
         bool consumed;
@@ -240,4 +240,4 @@ private:
 
         return scene_index;
     }
-};
+};

lib/app-scened-template/text_store.h

@@ -9,4 +9,4 @@ public:
     void set(const char* text...);
     const uint8_t text_size;
     char* text;
-};
+};

lib/app-scened-template/typeindex_no_rtti.hpp

@@ -118,4 +118,4 @@ template <> struct std::hash<ext::type_index> {
     result_type operator()(argument_type const& t) const noexcept {
         return t.hash_code();
     }
-};
+};

lib/app-scened-template/view_modules/byte_input_vm.h

@@ -34,4 +34,4 @@ public:
 
 private:
     ByteInput* byte_input;
-};
+};

lib/app-scened-template/view_modules/dialog_ex_vm.h

@@ -70,4 +70,4 @@ public:
 
 private:
     DialogEx* dialog_ex;
-};
+};

lib/app-scened-template/view_modules/generic_view_module.h

@@ -7,4 +7,4 @@ public:
     virtual ~GenericViewModule(){};
     virtual View* get_view() = 0;
     virtual void clean() = 0;
-};
+};

lib/app-scened-template/view_modules/popup_vm.h

@@ -65,4 +65,4 @@ public:
 
 private:
     Popup* popup;
-};
+};

lib/app-scened-template/view_modules/submenu_vm.h

@@ -39,4 +39,4 @@ public:
 
 private:
     Submenu* submenu;
-};
+};

lib/app-scened-template/view_modules/text_input_vm.h

@@ -38,4 +38,4 @@ public:
 
 private:
     TextInput* text_input;
-};
+};