[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

lib/nfc_protocols/mifare_classic.c

@@ -36,6 +36,7 @@ uint8_t mf_classic_get_total_sectors_num(MfClassicReader* reader) {
 }
 
 bool mf_classic_check_card_type(uint8_t ATQA0, uint8_t ATQA1, uint8_t SAK) {
+    UNUSED(ATQA1);
     if((ATQA0 == 0x44 || ATQA0 == 0x04) && (SAK == 0x08)) {
         return true;
     } else if((ATQA0 == 0x42 || ATQA0 == 0x02) && (SAK == 0x18)) {
@@ -52,6 +53,7 @@ bool mf_classic_get_type(
     uint8_t ATQA1,
     uint8_t SAK,
     MfClassicReader* reader) {
+    UNUSED(ATQA1);
     furi_assert(uid);
     furi_assert(reader);
     memset(reader, 0, sizeof(MfClassicReader));
@@ -204,7 +206,6 @@ bool mf_classic_read_block(
     MfClassicBlock* block) {
     furi_assert(tx_rx);
     furi_assert(crypto);
-    furi_assert(block_num < MF_CLASSIC_TOTAL_BLOCKS_MAX);
     furi_assert(block);
 
     bool read_block_success = false;

lib/nfc_protocols/mifare_desfire.c

@@ -444,4 +444,4 @@ bool mf_df_parse_read_data_response(uint8_t* buf, uint16_t len, MifareDesfireFil
     out->contents = malloc(len);
     memcpy(out->contents, buf, len);
     return true;
-}
+}

lib/nfc_protocols/mifare_ultralight.h

@@ -123,4 +123,4 @@ bool mf_ul_prepare_emulation_response(
     uint8_t* buff_tx,
     uint16_t* buff_tx_len,
     uint32_t* data_type,
-    void* context);
+    void* context);

lib/nfc_protocols/nfc_util.c

@@ -45,19 +45,3 @@ uint8_t nfc_util_even_parity32(uint32_t data) {
 uint8_t nfc_util_odd_parity8(uint8_t data) {
     return nfc_util_odd_byte_parity[data];
 }
-
-void nfc_util_merge_data_and_parity(
-    uint8_t* data,
-    uint16_t data_len,
-    uint8_t* parity,
-    uint16_t parity_len,
-    uint8_t* res,
-    uint16_t* res_len);
-
-void nfc_util_split_data_and_parity(
-    uint8_t* data,
-    uint16_t data_len,
-    uint8_t* parity,
-    uint16_t parity_len,
-    uint8_t* res,
-    uint16_t* res_len);

lib/nfc_protocols/nfc_util.h

@@ -9,19 +9,3 @@ uint64_t nfc_util_bytes2num(uint8_t* src, uint8_t len);
 uint8_t nfc_util_even_parity32(uint32_t data);
 
 uint8_t nfc_util_odd_parity8(uint8_t data);
-
-void nfc_util_merge_data_and_parity(
-    uint8_t* data,
-    uint16_t data_len,
-    uint8_t* parity,
-    uint16_t parity_len,
-    uint8_t* res,
-    uint16_t* res_len);
-
-void nfc_util_split_data_and_parity(
-    uint8_t* data,
-    uint16_t data_len,
-    uint8_t* parity,
-    uint16_t parity_len,
-    uint8_t* res,
-    uint16_t* res_len);

lib/nfc_protocols/nfca.c

@@ -52,4 +52,4 @@ bool nfca_emulation_handler(
     }
 
     return sleep;
-}
+}