[FL-2520] FW build with -Wextra (#1185)

* Fixing compiler warnings with -Wextra
* More warnings suppression, WIP
* Even more warning fixes
* Added new lines at end of text files.
* Padding fix
* Additional fixes to warnings on different build configurations; added -Wextra to default build pipeline
* Fixes for Secplus v1
* -additional warnings
* +-Wredundant-decls fixes
* FuriHal: print stack overflow task name in console
* FuriHal: add missing include

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

lib/one_wire/ibutton/encoder/encoder_cyfral.h

@@ -51,4 +51,4 @@ void encoder_cyfral_get_pulse(EncoderCyfral* cyfral, bool* polarity, uint32_t* l
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/encoder/encoder_metakom.h

@@ -51,4 +51,4 @@ void encoder_metakom_get_pulse(EncoderMetakom* metakom, bool* polarity, uint32_t
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/ibutton_key.c

@@ -118,4 +118,4 @@ bool ibutton_key_dallas_crc_is_valid(iButtonKey* key) {
 
 bool ibutton_key_dallas_is_1990_key(iButtonKey* key) {
     return (key->data[0] == 0x01);
-}
+}

lib/one_wire/ibutton/ibutton_key.h

@@ -142,4 +142,4 @@ bool ibutton_key_dallas_is_1990_key(iButtonKey* key);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/ibutton_key_command.h

@@ -25,4 +25,4 @@
 #define TM01_CMD_SWITCH_TO_CYFRAL 0xCA
 #define TM01_CMD_SWITCH_TO_METAKOM 0xCB
 
-#define DS1990_CMD_READ_ROM 0x33
+#define DS1990_CMD_READ_ROM 0x33

lib/one_wire/ibutton/ibutton_worker.h

@@ -110,4 +110,4 @@ void ibutton_worker_stop(iButtonWorker* worker);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/ibutton_worker_i.h

@@ -27,9 +27,9 @@ typedef enum {
 
 typedef struct {
     const uint32_t quant;
-    const void (*start)(iButtonWorker* worker);
-    const void (*tick)(iButtonWorker* worker);
-    const void (*stop)(iButtonWorker* worker);
+    void (*const start) (iButtonWorker* worker);
+    void (*const tick) (iButtonWorker* worker);
+    void (*const stop) (iButtonWorker* worker);
 } iButtonWorkerModeType;
 
 typedef enum {
@@ -76,4 +76,4 @@ void ibutton_worker_switch_mode(iButtonWorker* worker, iButtonWorkerMode mode);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/ibutton_worker_modes.c

@@ -49,12 +49,15 @@ const iButtonWorkerModeType ibutton_worker_modes[] = {
 /*********************** IDLE ***********************/
 
 void ibutton_worker_mode_idle_start(iButtonWorker* worker) {
+    UNUSED(worker);
 }
 
 void ibutton_worker_mode_idle_tick(iButtonWorker* worker) {
+    UNUSED(worker);
 }
 
 void ibutton_worker_mode_idle_stop(iButtonWorker* worker) {
+    UNUSED(worker);
 }
 
 /*********************** READ ***********************/
@@ -151,6 +154,7 @@ bool ibutton_worker_read_dallas(iButtonWorker* worker) {
 }
 
 void ibutton_worker_mode_read_start(iButtonWorker* worker) {
+    UNUSED(worker);
     furi_hal_power_enable_otg();
 }
 
@@ -172,6 +176,7 @@ void ibutton_worker_mode_read_tick(iButtonWorker* worker) {
 }
 
 void ibutton_worker_mode_read_stop(iButtonWorker* worker) {
+    UNUSED(worker);
     furi_hal_power_disable_otg();
 }
 
@@ -251,6 +256,7 @@ void ibutton_worker_emulate_timer_start(iButtonWorker* worker) {
 }
 
 void ibutton_worker_emulate_timer_stop(iButtonWorker* worker) {
+    UNUSED(worker);
     furi_hal_ibutton_emulate_stop();
 }
 
@@ -272,6 +278,7 @@ void ibutton_worker_mode_emulate_start(iButtonWorker* worker) {
 }
 
 void ibutton_worker_mode_emulate_tick(iButtonWorker* worker) {
+    UNUSED(worker);
 }
 
 void ibutton_worker_mode_emulate_stop(iButtonWorker* worker) {
@@ -327,4 +334,4 @@ void ibutton_worker_mode_write_tick(iButtonWorker* worker) {
 void ibutton_worker_mode_write_stop(iButtonWorker* worker) {
     furi_hal_power_disable_otg();
     onewire_host_stop(worker->host);
-}
+}

lib/one_wire/ibutton/ibutton_writer.h

@@ -57,4 +57,4 @@ void ibutton_writer_stop(iButtonWriter* writer);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/pulse_protocols/protocol_cyfral.h

@@ -35,4 +35,4 @@ PulseProtocol* protocol_cyfral_get_protocol(ProtocolCyfral* cyfral);
 
 #ifdef __cplusplus
 }
-#endif
+#endif

lib/one_wire/ibutton/pulse_protocols/protocol_metakom.h

@@ -35,4 +35,4 @@ PulseProtocol* protocol_metakom_get_protocol(ProtocolMetakom* metakom);
 
 #ifdef __cplusplus
 }
-#endif
+#endif