Release Candidate 0.48.0 Bug Fixes (#991)

* Power: wait a little bit till message displayed on screen when executing power off. FuriCore: do not use bkpt in release builds(causing HardFault when SPI is active).
* Cleanup BSS section: add more consty consts to be more constish.
* Desktop: properly handle autostarted applications.

lib/ST25RFAL002/platform.c

@@ -4,7 +4,12 @@
 #include <furi.h>
 #include <furi_hal_spi.h>
 
-static osThreadAttr_t platform_irq_thread_attr;
+static const osThreadAttr_t platform_irq_thread_attr = {
+    .name = "RfalIrqWorker",
+    .stack_size = 1024,
+    .priority = osPriorityRealtime,
+};
+
 static volatile osThreadId_t platform_irq_thread_id = NULL;
 static volatile PlatformIrqCallback platform_irq_callback = NULL;
 static const GpioPin pin = {ST25R_INT_PORT, ST25R_INT_PIN};
@@ -36,9 +41,6 @@ void platformDisableIrqCallback() {
 
 void platformSetIrqCallback(PlatformIrqCallback callback) {
     platform_irq_callback = callback;
-    platform_irq_thread_attr.name = "RfalIrqWorker";
-    platform_irq_thread_attr.stack_size = 1024;
-    platform_irq_thread_attr.priority = osPriorityRealtime;
     platform_irq_thread_id = osThreadNew(platformIrqWorker, NULL, &platform_irq_thread_attr);
     hal_gpio_add_int_callback(&pin, nfc_isr, NULL);
     // Disable interrupt callback as the pin is shared between 2 apps

lib/flipper_file/flipper_file_helper.c

@@ -1,7 +1,7 @@
 #include "flipper_file_helper.h"
 
-const char* flipper_file_filetype_key = "Filetype";
-const char* flipper_file_version_key = "Version";
+const char* const flipper_file_filetype_key = "Filetype";
+const char* const flipper_file_version_key = "Version";
 const char flipper_file_delimiter = ':';
 const char flipper_file_comment = '#';
 

lib/flipper_file/flipper_file_helper.h

@@ -8,8 +8,8 @@
 extern "C" {
 #endif
 
-extern const char* flipper_file_filetype_key;
-extern const char* flipper_file_version_key;
+extern const char* const flipper_file_filetype_key;
+extern const char* const flipper_file_version_key;
 extern const char flipper_file_delimiter;
 extern const char flipper_file_comment;
 

lib/nfc_protocols/emv_decoder.c

@@ -21,7 +21,7 @@ const PDOLValue pdol_transaction_cert = {0x98, {0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
                                                 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}}; // Transaction cert
 const PDOLValue pdol_unpredict_number = {0x9F37, {0x82, 0x3D, 0xDE, 0x7A}}; // Unpredictable number
 
-const PDOLValue* pdol_values[] = {
+const PDOLValue* const pdol_values[] = {
     &pdol_term_info,
     &pdol_term_type,
     &pdol_merchant_type,

lib/nfc_protocols/emv_decoder.h

@@ -26,7 +26,7 @@ typedef struct {
     uint8_t data[];
 } PDOLValue;
 
-extern const PDOLValue* pdol_values[];
+extern const PDOLValue* const pdol_values[];
 
 typedef struct {
     uint8_t size;