[FL-1929, FL-2164] IR App migrate to FFF (#949)

* IR app move to FFF
* [FL-2164] Hide unimplemented submenus
* Fix brute force fail
* Fix FFF endless reading
* Reformat TV bruteforce lib to FFF
* fixes & cleanup
* Infrared: switch to constexpr.

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>

lib/app-scened-template/file_worker.c

@@ -435,5 +435,6 @@ bool file_worker_is_file_exist(FileWorker* file_worker, const char* filename, bo
     storage_file_close(file);
     storage_file_free(file);
 
-    return file_worker_check_common_errors(file_worker);
+    bool result = file_worker_check_common_errors(file_worker);
+    return result;
 }

lib/flipper_file/flipper_file.c

@@ -159,7 +159,7 @@ bool flipper_file_get_value_count(FlipperFile* flipper_file, const char* key, ui
             if(last) break;
         }
 
-    } while(true);
+    } while(false);
 
     if(!storage_file_seek(flipper_file->file, position, true)) {
         result = false;

lib/irda/encoder_decoder/irda.h

@@ -7,8 +7,8 @@
 extern "C" {
 #endif
 
-#define IRDA_COMMON_CARRIER_FREQUENCY 38000
-#define IRDA_COMMON_DUTY_CYCLE 0.33
+#define IRDA_COMMON_CARRIER_FREQUENCY ((uint32_t)38000)
+#define IRDA_COMMON_DUTY_CYCLE ((float)0.33)
 
 /* if we want to see splitted raw signals during brutforce,
  * we have to have RX raw timing delay less than TX */

lib/irda/worker/irda_worker.c

@@ -326,7 +326,6 @@ void irda_worker_tx_start(IrdaWorker* instance) {
 
     osEventFlagsClear(instance->events, IRDA_WORKER_ALL_EVENTS);
     furi_thread_set_callback(instance->thread, irda_worker_tx_thread);
-    furi_thread_start(instance->thread);
 
     instance->tx.steady_signal_sent = false;
     instance->tx.need_reinitialization = false;
@@ -335,6 +334,7 @@ void irda_worker_tx_start(IrdaWorker* instance) {
         irda_worker_furi_hal_message_sent_isr_callback, instance);
 
     instance->state = IrdaWorkerStateStartTx;
+    furi_thread_start(instance->thread);
 }
 
 static void irda_worker_furi_hal_message_sent_isr_callback(void* context) {