liz/flipperzero-firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Furi: core refactoring and CMSIS removal part 2 (#1410)

Browse Source 
* Furi: rename and move core
* Furi: drop CMSIS_OS header and unused api, partially refactor and cleanup the rest
* Furi: CMSIS_OS drop and refactoring.
* Furi: refactoring, remove cmsis legacy
* Furi: fix incorrect assert on queue deallocation, cleanup timer
* Furi: improve delay api, get rid of floats
* hal: dropped furi_hal_crc
* Furi: move DWT based delay to cortex HAL
* Furi: update core documentation

Co-authored-by: hedger <hedger@nanode.su>
This commit is contained in:
あく
2022-07-20 13:56:33 +03:00
committed by GitHub
parent f9c2287ea7
commit e3c7201a20
264 changed files with 2569 additions and 3883 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
applications/rpc/rpc.c
View File

@@ -68,7 +68,7 @@ struct RpcSession {
void** system_contexts;
bool decode_error;
osMutexId_t callbacks_mutex;
FuriMutex* callbacks_mutex;
RpcSendBytesCallback send_bytes_callback;
RpcBufferIsEmptyCallback buffer_is_empty_callback;
RpcSessionClosedCallback closed_callback;
@@ -77,7 +77,7 @@ struct RpcSession {
};
struct Rpc {
osMutexId_t busy_mutex;
FuriMutex* busy_mutex;
};
static bool content_callback(pb_istream_t* stream, const pb_field_t* field, void** arg);
@@ -89,13 +89,13 @@ static void rpc_close_session_process(const PB_Main* request, void* context) {
furi_assert(session);
rpc_send_and_release_empty(session, request->command_id, PB_CommandStatus_OK);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
if(session->closed_callback) {
session->closed_callback(session->context);
} else {
FURI_LOG_W(TAG, "Session stop isn't processed by transport layer");
}
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
static size_t rpc_sprintf_msg_file(
@@ -359,25 +359,25 @@ void rpc_print_message(const PB_Main* message) {
void rpc_session_set_context(RpcSession* session, void* context) {
furi_assert(session);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->context = context;
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
void rpc_session_set_close_callback(RpcSession* session, RpcSessionClosedCallback callback) {
furi_assert(session);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->closed_callback = callback;
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
void rpc_session_set_send_bytes_callback(RpcSession* session, RpcSendBytesCallback callback) {
furi_assert(session);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->send_bytes_callback = callback;
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
void rpc_session_set_buffer_is_empty_callback(
@@ -385,9 +385,9 @@ void rpc_session_set_buffer_is_empty_callback(
RpcBufferIsEmptyCallback callback) {
furi_assert(session);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->buffer_is_empty_callback = callback;
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
void rpc_session_set_terminated_callback(
@@ -395,9 +395,9 @@ void rpc_session_set_terminated_callback(
RpcSessionTerminatedCallback callback) {
furi_assert(session);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->terminated_callback = callback;
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
/* Doesn't forbid using rpc_feed_bytes() after session close - it's safe.
@@ -444,7 +444,7 @@ bool rpc_pb_stream_read(pb_istream_t* istream, pb_byte_t* buf, size_t count) {
if(count == bytes_received) {
break;
} else {
flags = furi_thread_flags_wait(RPC_ALL_EVENTS, osFlagsWaitAny, osWaitForever);
flags = furi_thread_flags_wait(RPC_ALL_EVENTS, FuriFlagWaitAny, FuriWaitForever);
if(flags & RpcEvtDisconnect) {
if(xStreamBufferIsEmpty(session->stream)) {
session->terminate = true;
@@ -508,9 +508,9 @@ static int32_t rpc_session_worker(void* context) {
RpcHandlerDict_get(session->handlers, session->decoded_message->which_content);
if(handler && handler->message_handler) {
furi_check(osMutexAcquire(rpc->busy_mutex, osWaitForever) == osOK);
furi_check(furi_mutex_acquire(rpc->busy_mutex, FuriWaitForever) == FuriStatusOk);
handler->message_handler(session->decoded_message, handler->context);
furi_check(osMutexRelease(rpc->busy_mutex) == osOK);
furi_check(furi_mutex_release(rpc->busy_mutex) == FuriStatusOk);
} else if(session->decoded_message->which_content == 0) {
/* Receiving zeroes means message is 0-length, which
* is valid for proto3: all fields are filled with default values.
@@ -551,11 +551,11 @@ static int32_t rpc_session_worker(void* context) {
FURI_LOG_E(TAG, "Decode failed, error: \'%.128s\'", PB_GET_ERROR(&istream));
session->decode_error = true;
rpc_send_and_release_empty(session, 0, PB_CommandStatus_ERROR_DECODE);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
if(session->closed_callback) {
session->closed_callback(session->context);
}
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
}
}
@@ -586,13 +586,13 @@ static void rpc_session_free_callback(FuriThreadState thread_state, void* contex
RpcHandlerDict_clear(session->handlers);
vStreamBufferDelete(session->stream);
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
if(session->terminated_callback) {
session->terminated_callback(session->context);
}
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
osMutexDelete(session->callbacks_mutex);
furi_mutex_free(session->callbacks_mutex);
furi_thread_free(session->thread);
free(session);
}
@@ -602,7 +602,7 @@ RpcSession* rpc_session_open(Rpc* rpc) {
furi_assert(rpc);
RpcSession* session = malloc(sizeof(RpcSession));
session->callbacks_mutex = osMutexNew(NULL);
session->callbacks_mutex = furi_mutex_alloc(FuriMutexTypeNormal);
session->stream = xStreamBufferCreate(RPC_BUFFER_SIZE, 1);
session->rpc = rpc;
session->terminate = false;
@@ -653,7 +653,7 @@ int32_t rpc_srv(void* p) {
UNUSED(p);
Rpc* rpc = malloc(sizeof(Rpc));
rpc->busy_mutex = osMutexNew(NULL);
rpc->busy_mutex = furi_mutex_alloc(FuriMutexTypeNormal);
Cli* cli = furi_record_open("cli");
cli_add_command(
@@ -693,11 +693,11 @@ void rpc_send(RpcSession* session, PB_Main* message) {
rpc_print_data("OUTPUT", buffer, ostream.bytes_written);
#endif
osMutexAcquire(session->callbacks_mutex, osWaitForever);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
if(session->send_bytes_callback) {
session->send_bytes_callback(session->context, buffer, ostream.bytes_written);
}
osMutexRelease(session->callbacks_mutex);
furi_mutex_release(session->callbacks_mutex);
free(buffer);
}

15
applications/rpc/rpc_app.c
View File

@@ -1,6 +1,5 @@
#include "cmsis_os2.h"
#include "flipper.pb.h"
#include "furi/record.h"
#include <core/record.h>
#include "rpc_i.h"
#include <furi.h>
#include <loader/loader.h>
@@ -13,7 +12,7 @@ struct RpcAppSystem {
RpcSession* session;
RpcAppSystemCallback app_callback;
void* app_context;
osTimerId_t timer;
FuriTimer* timer;
};
static void rpc_system_app_timer_callback(void* context) {
@@ -111,7 +110,7 @@ static void rpc_system_app_exit(const PB_Main* request, void* context) {
if(rpc_app->app_callback) {
if(rpc_app->app_callback(RpcAppEventAppExit, NULL, rpc_app->app_context)) {
status = PB_CommandStatus_OK;
osTimerStop(rpc_app->timer);
furi_timer_stop(rpc_app->timer);
} else {
status = PB_CommandStatus_ERROR_APP_CMD_ERROR;
}
@@ -160,7 +159,7 @@ static void rpc_system_app_button_press(const PB_Main* request, void* context) {
const char* args = request->content.app_button_press_request.args;
if(rpc_app->app_callback(RpcAppEventButtonPress, args, rpc_app->app_context)) {
status = PB_CommandStatus_OK;
osTimerStart(rpc_app->timer, APP_BUTTON_TIMEOUT);
furi_timer_start(rpc_app->timer, APP_BUTTON_TIMEOUT);
} else {
status = PB_CommandStatus_ERROR_APP_CMD_ERROR;
}
@@ -184,7 +183,7 @@ static void rpc_system_app_button_release(const PB_Main* request, void* context)
if(rpc_app->app_callback) {
if(rpc_app->app_callback(RpcAppEventButtonRelease, NULL, rpc_app->app_context)) {
status = PB_CommandStatus_OK;
osTimerStop(rpc_app->timer);
furi_timer_stop(rpc_app->timer);
} else {
status = PB_CommandStatus_ERROR_APP_CMD_ERROR;
}
@@ -208,7 +207,7 @@ void* rpc_system_app_alloc(RpcSession* session) {
RpcAppSystem* rpc_app = malloc(sizeof(RpcAppSystem));
rpc_app->session = session;
rpc_app->timer = osTimerNew(rpc_system_app_timer_callback, osTimerOnce, rpc_app, NULL);
rpc_app->timer = furi_timer_alloc(rpc_system_app_timer_callback, FuriTimerTypeOnce, rpc_app);
RpcHandler rpc_handler = {
.message_handler = NULL,
@@ -242,7 +241,7 @@ void rpc_system_app_free(void* context) {
RpcSession* session = rpc_app->session;
furi_assert(session);
osTimerDelete(rpc_app->timer);
furi_timer_free(rpc_app->timer);
if(rpc_app->app_callback) {
rpc_app->app_callback(RpcAppEventSessionClose, NULL, rpc_app->app_context);

11
applications/rpc/rpc_cli.c
View File

@@ -9,7 +9,7 @@
typedef struct {
Cli* cli;
bool session_close_request;
osSemaphoreId_t terminate_semaphore;
FuriSemaphore* terminate_semaphore;
} CliRpc;
#define CLI_READ_BUFFER_SIZE 64
@@ -34,7 +34,7 @@ static void rpc_session_terminated_callback(void* context) {
furi_check(context);
CliRpc* cli_rpc = context;
osSemaphoreRelease(cli_rpc->terminate_semaphore);
furi_semaphore_release(cli_rpc->terminate_semaphore);
}
void rpc_cli_command_start_session(Cli* cli, string_t args, void* context) {
@@ -53,7 +53,7 @@ void rpc_cli_command_start_session(Cli* cli, string_t args, void* context) {
}
CliRpc cli_rpc = {.cli = cli, .session_close_request = false};
cli_rpc.terminate_semaphore = osSemaphoreNew(1, 0, NULL);
cli_rpc.terminate_semaphore = furi_semaphore_alloc(1, 0);
rpc_session_set_context(rpc_session, &cli_rpc);
rpc_session_set_send_bytes_callback(rpc_session, rpc_send_bytes_callback);
rpc_session_set_close_callback(rpc_session, rpc_session_close_callback);
@@ -77,9 +77,10 @@ void rpc_cli_command_start_session(Cli* cli, string_t args, void* context) {
rpc_session_close(rpc_session);
furi_check(osSemaphoreAcquire(cli_rpc.terminate_semaphore, osWaitForever) == osOK);
furi_check(
furi_semaphore_acquire(cli_rpc.terminate_semaphore, FuriWaitForever) == FuriStatusOk);
osSemaphoreDelete(cli_rpc.terminate_semaphore);
furi_semaphore_free(cli_rpc.terminate_semaphore);
free(buffer);
furi_hal_usb_unlock();

2
applications/rpc/rpc_gui.c
View File

@@ -50,7 +50,7 @@ static int32_t rpc_system_gui_screen_stream_frame_transmit_thread(void* context)
while(true) {
uint32_t flags =
furi_thread_flags_wait(RpcGuiWorkerFlagAny, osFlagsWaitAny, osWaitForever);
furi_thread_flags_wait(RpcGuiWorkerFlagAny, FuriFlagWaitAny, FuriWaitForever);
if(flags & RpcGuiWorkerFlagTransmit) {
rpc_send(rpc_gui->session, rpc_gui->transmit_frame);
}

6
applications/rpc/rpc_storage.c
View File

@@ -1,7 +1,7 @@
#include "flipper.pb.h"
#include "furi/common_defines.h"
#include "furi/memmgr.h"
#include "furi/record.h"
#include <core/common_defines.h>
#include <core/memmgr.h>
#include <core/record.h>
#include "pb_decode.h"
#include "rpc/rpc.h"
#include "rpc_i.h"