liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply modernize-use-nullptr

Browse Source 
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
This commit is contained in:
Flössie
2016-10-12 17:48:40 +02:00
parent 29d5329f3f
commit 0731975ff0
218 changed files with 2406 additions and 2406 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
rtgui/filebrowser.cc
View File

@@ -50,7 +50,7 @@ const Glib::ustring* getOriginalExtension (const ThumbBrowserEntryBase* entry)
const Glib::ustring::size_type pos = basename.find_last_of ('.');
if (pos >= basename.length () - 1) {
return NULL;
return nullptr;
}
const Glib::ustring extension = basename.substr (pos + 1);
@@ -62,12 +62,12 @@ const Glib::ustring* getOriginalExtension (const ThumbBrowserEntryBase* entry)
}
}
return NULL;
return nullptr;
}
ThumbBrowserEntryBase* selectOriginalEntry (ThumbBrowserEntryBase* original, ThumbBrowserEntryBase* candidate)
{
if (original == NULL) {
if (original == nullptr) {
return candidate;
}
@@ -97,7 +97,7 @@ void findOriginalEntries (const std::vector<ThumbBrowserEntryBase*>& entries)
const Glib::ustring::size_type pos = basename.find_last_of ('.');
if (pos >= basename.length () - 1) {
(*entry)->setOriginal (NULL);
(*entry)->setOriginal (nullptr);
continue;
}
@@ -109,7 +109,7 @@ void findOriginalEntries (const std::vector<ThumbBrowserEntryBase*>& entries)
// Find the original image for each bucket
for (BasenameIterator bucket = byBasename.begin (); bucket != byBasename.end (); ++bucket) {
const EntryVector& entries = bucket->second;
ThumbBrowserEntryBase* original = NULL;
ThumbBrowserEntryBase* original = nullptr;
// Select the most likely original in a first pass...
for (EntryIterator entry = entries.begin (); entry != entries.end (); ++entry) {
@@ -118,7 +118,7 @@ void findOriginalEntries (const std::vector<ThumbBrowserEntryBase*>& entries)
// ...and link all other images to it in a second pass.
for (EntryIterator entry = entries.begin (); entry != entries.end (); ++entry) {
(*entry)->setOriginal (*entry != original ? original : NULL);
(*entry)->setOriginal (*entry != original ? original : nullptr);
}
}
}
@@ -126,7 +126,7 @@ void findOriginalEntries (const std::vector<ThumbBrowserEntryBase*>& entries)
}
FileBrowser::FileBrowser ()
: tbl(NULL), numFiltered(0), partialPasteDlg(M("PARTIALPASTE_DIALOGLABEL"))
: tbl(nullptr), numFiltered(0), partialPasteDlg(M("PARTIALPASTE_DIALOGLABEL"))
{
fbih = new FileBrowserIdleHelper;
@@ -225,12 +225,12 @@ FileBrowser::FileBrowser ()
#if defined(WIN32)
Gtk::manage(miOpenDefaultViewer = new Gtk::MenuItem (M("FILEBROWSER_OPENDEFAULTVIEWER")));
#else
miOpenDefaultViewer = NULL;
miOpenDefaultViewer = nullptr;
#endif
// Build a list of menu items
mMenuExtProgs.clear();
amiExtProg = NULL;
amiExtProg = nullptr;
for (const auto& action : extProgStore->getActions ()) {
if (action.target == 1 || action.target == 2) {
@@ -239,7 +239,7 @@ FileBrowser::FileBrowser ()
}
// Attach them to menu
if (!mMenuExtProgs.empty() || miOpenDefaultViewer != NULL) {
if (!mMenuExtProgs.empty() || miOpenDefaultViewer != nullptr) {
amiExtProg = new Gtk::MenuItem*[mMenuExtProgs.size()];
int itemNo = 0;
@@ -248,7 +248,7 @@ FileBrowser::FileBrowser ()
p++;
Gtk::Menu* submenuExtProg = Gtk::manage (new Gtk::Menu());
if (miOpenDefaultViewer != NULL) {
if (miOpenDefaultViewer != nullptr) {
submenuExtProg->attach (*miOpenDefaultViewer, 0, 1, p, p + 1);
p++;
}
@@ -261,7 +261,7 @@ FileBrowser::FileBrowser ()
submenuExtProg->show_all ();
menuExtProg->set_submenu (*submenuExtProg);
} else {
if (miOpenDefaultViewer != NULL) {
if (miOpenDefaultViewer != nullptr) {
pmenu->attach (*miOpenDefaultViewer, 0, 1, p, p + 1);
p++;
}
@@ -417,7 +417,7 @@ FileBrowser::FileBrowser ()
amiExtProg[i]->signal_activate().connect (sigc::bind(sigc::mem_fun(*this, &FileBrowser::menuItemActivated), amiExtProg[i]));
}
if (miOpenDefaultViewer != NULL) {
if (miOpenDefaultViewer != nullptr) {
miOpenDefaultViewer->signal_activate().connect (sigc::bind(sigc::mem_fun(*this, &FileBrowser::menuItemActivated), miOpenDefaultViewer));
}
@@ -657,7 +657,7 @@ FileBrowserEntry* FileBrowser::delEntry (const Glib::ustring& fname)
}
if (lastClicked == entry) {
lastClicked = NULL;
lastClicked = nullptr;
}
redraw ();
@@ -665,7 +665,7 @@ FileBrowserEntry* FileBrowser::delEntry (const Glib::ustring& fname)
return (static_cast<FileBrowserEntry*>(entry));
}
return NULL;
return nullptr;
}
void FileBrowser::close ()
@@ -700,7 +700,7 @@ void FileBrowser::close ()
fd.clear ();
}
lastClicked = NULL;
lastClicked = nullptr;
}
void FileBrowser::menuColorlabelActivated (Gtk::MenuItem* m)
@@ -790,7 +790,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
else if (m == rename) {
tbl->renameRequested (mselected);
} else if (m == selall) {
lastClicked = NULL;
lastClicked = nullptr;
{
MYWRITERLOCK(l, entryRW);
@@ -821,7 +821,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
rtengine::procparams::ProcParams pp = mselected[i]->thumbnail->getProcParams();
pp.raw.df_autoselect = true;
pp.raw.dark_frame.clear();
mselected[i]->thumbnail->setProcParams(pp, NULL, FILEBROWSER, false);
mselected[i]->thumbnail->setProcParams(pp, nullptr, FILEBROWSER, false);
}
if (!mselected.empty() && bppcl) {
@@ -849,7 +849,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
rtengine::procparams::ProcParams pp = mselected[i]->thumbnail->getProcParams();
pp.raw.dark_frame = fc.get_filename();
pp.raw.df_autoselect = false;
mselected[i]->thumbnail->setProcParams(pp, NULL, FILEBROWSER, false);
mselected[i]->thumbnail->setProcParams(pp, nullptr, FILEBROWSER, false);
}
if (bppcl) {
@@ -898,7 +898,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
rtengine::procparams::ProcParams pp = mselected[i]->thumbnail->getProcParams();
pp.raw.ff_AutoSelect = true;
pp.raw.ff_file.clear();
mselected[i]->thumbnail->setProcParams(pp, NULL, FILEBROWSER, false);
mselected[i]->thumbnail->setProcParams(pp, nullptr, FILEBROWSER, false);
}
if (!mselected.empty() && bppcl) {
@@ -925,7 +925,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
rtengine::procparams::ProcParams pp = mselected[i]->thumbnail->getProcParams();
pp.raw.ff_file = fc.get_filename();
pp.raw.ff_AutoSelect = false;
mselected[i]->thumbnail->setProcParams(pp, NULL, FILEBROWSER, false);
mselected[i]->thumbnail->setProcParams(pp, nullptr, FILEBROWSER, false);
}
if (bppcl) {
@@ -987,7 +987,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
// Empty run to update the thumb
rtengine::procparams::ProcParams params = mselected[i]->thumbnail->getProcParams ();
mselected[i]->thumbnail->setProcParams (params, NULL, FILEBROWSER);
mselected[i]->thumbnail->setProcParams (params, nullptr, FILEBROWSER);
}
if (!mselected.empty() && bppcl) {
@@ -1005,7 +1005,7 @@ void FileBrowser::menuItemActivated (Gtk::MenuItem* m)
}
//queue_draw ();
} else if (miOpenDefaultViewer != NULL && m == miOpenDefaultViewer) {
} else if (miOpenDefaultViewer != nullptr && m == miOpenDefaultViewer) {
openDefaultViewer(1);
}
}
@@ -1088,7 +1088,7 @@ void FileBrowser::partPasteProfile ()
// copying read only clipboard PartialProfile to a temporary one, initialized to the thumb's ProcParams
mselected[i]->thumbnail->createProcParamsForUpdate(false, false); // this can execute customprofilebuilder to generate param file
rtengine::procparams::PartialProfile cbPartProf = clipboard.getPartialProfile();
rtengine::procparams::PartialProfile pastedPartProf(&mselected[i]->thumbnail->getProcParams (), NULL);
rtengine::procparams::PartialProfile pastedPartProf(&mselected[i]->thumbnail->getProcParams (), nullptr);
// pushing the selected values of the clipboard PartialProfile to the temporary PartialProfile
partialPasteDlg.applyPaste (pastedPartProf.pparams, pastedPartProf.pedited, cbPartProf.pparams, cbPartProf.pedited);
@@ -1438,7 +1438,7 @@ void FileBrowser::applyFilter (const BrowserFilter& filter)
selected.erase (j);
if (lastClicked == fd[i]) {
lastClicked = NULL;
lastClicked = nullptr;
}
selchanged = true;
@@ -1459,7 +1459,7 @@ bool FileBrowser::checkFilter (ThumbBrowserEntryBase* entryb) // true -> entry
FileBrowserEntry* entry = static_cast<FileBrowserEntry*>(entryb);
if (filter.showOriginal && entry->getOriginal() != NULL) {
if (filter.showOriginal && entry->getOriginal() != nullptr) {
return false;
}