Code cleanups

on behalf of Lebedev, see issue 1355
This commit is contained in:
Oliver Duis
2012-05-06 22:10:37 +02:00
parent 686188d6bb
commit 1483ecb47c
125 changed files with 750 additions and 747 deletions

View File

@@ -67,7 +67,7 @@ FavoritBrowser::FavoritBrowser () : listener (NULL), lastSelectedDir ("") {
void FavoritBrowser::selectionChanged () {
Glib::RefPtr<Gtk::TreeSelection> selection = treeView->get_selection();
Gtk::TreeModel::iterator iter = selection->get_selected();
Gtk::TreeModel::const_iterator iter = selection->get_selected();
if (iter && listener)
listener->selectDir (iter->get_value (favoritColumns.fulldir));
}
@@ -79,15 +79,15 @@ void FavoritBrowser::dirSelected (const Glib::ustring& dirname, const Glib::ustr
void FavoritBrowser::addPressed () {
if (lastSelectedDir=="")
if (lastSelectedDir.empty())
return;
// check if the dirname is already in the list. If yes, return.
Gtk::TreeModel::iterator iter = favoritModel->children ().begin();
Gtk::TreeModel::const_iterator iter = favoritModel->children ().begin();
while (iter != favoritModel->children().end()) {
if (iter->get_value (favoritColumns.fulldir) == lastSelectedDir)
return;
iter++;
++iter;
}
Glib::RefPtr<Gio::File> hfile = Gio::File::create_for_parse_name (lastSelectedDir);