liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Memory leak in RefreshMapper, fixes #5323

Browse Source
This commit is contained in:
heckflosse
2019-05-18 18:44:06 +02:00
parent 351f8f4e12
commit 159e1784f4
3 changed files with 32 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
rtgui/history.cc
View File

@@ -225,15 +225,14 @@ void History::procParamsChanged(
return;
}
selchangehist.block (true);
selchangebm.block (true);
selchangehist.block(true);
selchangebm.block(true);
if (ev == EvPhotoLoaded) {
initHistory ();
initHistory();
}
// construct formatted list content
Glib::ustring text = M(ProcEventMapper::getInstance()->getHistoryMsg(ev));
Glib::RefPtr<Gtk::TreeSelection> selection = hTreeView->get_selection();
Gtk::TreeModel::iterator iter = selection->get_selected();
@@ -243,12 +242,12 @@ void History::procParamsChanged(
++iter;
while (iter) {
iter = historyModel->erase (iter);
iter = historyModel->erase(iter);
}
}
// lookup the last remaining item in the list
int size = historyModel->children().size ();
const int size = historyModel->children().size();
Gtk::TreeModel::Row row;
if (size > 0) {
@@ -258,47 +257,43 @@ void History::procParamsChanged(
// if there is no last item or its chev!=ev, create a new one
if (size == 0 || !row || row[historyColumns.chev] != ev || ev == EvProfileChanged) {
Gtk::TreeModel::Row newrow = *(historyModel->append());
newrow[historyColumns.text] = text;
newrow[historyColumns.text] = ProcEventMapper::getInstance()->getHistoryMsg(ev);
newrow[historyColumns.value] = g_markup_escape_text(descr.c_str(), -1);
newrow[historyColumns.chev] = ev;
newrow[historyColumns.params] = *params;
newrow[historyColumns.paramsEdited] = paramsEdited ? *paramsEdited : defParamsEdited;
if (ev != EvBookmarkSelected) {
selection->select (newrow);
selection->select(newrow);
}
if (blistener && row && !blistenerLock) {
blistener->historyBeforeLineChanged (row[historyColumns.params]);
blistener->historyBeforeLineChanged(row[historyColumns.params]);
} else if (blistener && size == 0 && !blistenerLock) {
blistener->historyBeforeLineChanged (newrow[historyColumns.params]);
blistener->historyBeforeLineChanged(newrow[historyColumns.params]);
}
}
// else just update it
else {
row[historyColumns.text] = text;
} else { // else just update it
row[historyColumns.value] = g_markup_escape_text(descr.c_str(), -1);
row[historyColumns.chev] = ev;
row[historyColumns.params] = *params;
row[historyColumns.paramsEdited] = paramsEdited ? *paramsEdited : defParamsEdited;
if (ev != EvBookmarkSelected) {
selection->select (row);
selection->select(row);
}
}
if (ev != EvBookmarkSelected) {
bTreeView->get_selection()->unselect_all ();
bTreeView->get_selection()->unselect_all();
}
if (!selection->get_selected_rows().empty()) {
std::vector<Gtk::TreeModel::Path> selp = selection->get_selected_rows();
hTreeView->scroll_to_row (*selp.begin());
hTreeView->scroll_to_row(*selp.begin());
}
selchangehist.block (false);
selchangebm.block (false);
selchangehist.block(false);
selchangebm.block(false);
}
void History::clearParamChanges ()