liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve code quality for external editor settings

Browse Source
This commit is contained in:
Lawrence Lee
2023-04-09 13:52:09 -07:00
parent 19f12f3182
commit 186995acf4
3 changed files with 29 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
rtgui/externaleditorpreferences.h
View File

@@ -42,16 +42,22 @@ class FileChooserDialog;
class ExternalEditorPreferences : public Gtk::Box
{
public:
struct EditorTag {
bool selected;
EditorTag(): selected(false) {}
explicit EditorTag(bool selected): selected(selected) {}
};
/**
* Data struct containing information about an external editor.
*/
struct EditorInfo {
explicit EditorInfo(
Glib::ustring name = Glib::ustring(),
Glib::ustring command = Glib::ustring(),
Glib::ustring icon_serialized = Glib::ustring(),
const Glib::ustring &name = Glib::ustring(),
const Glib::ustring &command = Glib::ustring(),
const Glib::ustring &icon_serialized = Glib::ustring(),
bool native_command = false,
void *other_data = nullptr
EditorTag other_data = EditorTag()
);
/**
* Name of the external editor.
@@ -74,7 +80,7 @@ public:
* Holds any other data associated with the editor. For example, it can
* be used as a tag to uniquely identify the editor.
*/
void *other_data;
EditorTag other_data;
};
ExternalEditorPreferences();
@@ -102,7 +108,7 @@ private:
Gtk::TreeModelColumn<Glib::RefPtr<Gio::Icon>> icon;
Gtk::TreeModelColumn<Glib::ustring> command;
Gtk::TreeModelColumn<bool> native_command;
Gtk::TreeModelColumn<void *> other_data;
Gtk::TreeModelColumn<EditorTag> other_data;
};
ModelColumns model_columns;