Fix some issues found by cppcheck

This commit is contained in:
heckflosse
2018-11-22 18:40:09 +01:00
parent b7c04d3b08
commit 190772af5e
11 changed files with 20 additions and 31 deletions

View File

@@ -89,7 +89,7 @@ public:
void updateVolumes ();
void updateDirTree (const Gtk::TreeModel::iterator& iter);
void updateDirTreeRoot ();
void winDirChanged ();
void winDirChanged () override;
private:
void addRoot (char letter);
#endif

View File

@@ -261,7 +261,7 @@ void ExifPanel::addDirectory (const TagDirectory* dir, Gtk::TreeModel::Children
Tag* t2 = (const_cast<TagDirectory*> (dir))->getTagByIndex (j);
const TagAttrib* currAttrib = t2->getAttrib();
if (currAttrib && ((options.lastShowAllExif) || (!options.lastShowAllExif && currAttrib->action != AC_SYSTEM))) {
if (currAttrib && (options.lastShowAllExif || currAttrib->action != AC_SYSTEM)) {
addSeparator();
hasContent = true;
break;

View File

@@ -11,7 +11,7 @@
class ClutComboBox : public MyComboBox
{
public:
ClutComboBox(const Glib::ustring &path);
explicit ClutComboBox(const Glib::ustring &path);
//int fillFromDir (const Glib::ustring& path);
int foundClutsCount() const;
Glib::ustring getSelectedClut();
@@ -34,7 +34,7 @@ private:
Glib::RefPtr<Gtk::TreeStore> m_model;
ClutColumns m_columns;
int count;
ClutModel(const Glib::ustring &path);
explicit ClutModel(const Glib::ustring &path);
int parseDir (const Glib::ustring& path);
};

View File

@@ -11,7 +11,6 @@ using namespace rtengine::procparams;
Retinex::Retinex () : FoldableToolPanel (this, "retinex", M ("TP_RETINEX_LABEL"), false, true), lastmedianmap (false)
{
CurveListener::setMulti (true);
std::vector<double> defaultCurve;
std::vector<GradientMilestone> milestones;
nextmin = 0.;
nextmax = 0.;