Use _WIN32
instead of WIN32
to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here. http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
This commit is contained in:
@@ -265,7 +265,7 @@ void ExternalEditorPreferences::onFileChooserDialogResponse(
|
||||
false;
|
||||
#endif
|
||||
row[model_columns.command] =
|
||||
#ifdef WIN32
|
||||
#ifdef _WIN32
|
||||
'"' + dialog->get_filename() + '"';
|
||||
#else
|
||||
Glib::shell_quote(dialog->get_filename());
|
||||
@@ -314,7 +314,7 @@ void ExternalEditorPreferences::openFileChooserDialog()
|
||||
const auto exe_filter = Gtk::FileFilter::create();
|
||||
exe_filter->set_name(M("FILECHOOSER_FILTER_EXECUTABLE"));
|
||||
exe_filter->add_custom(Gtk::FILE_FILTER_MIME_TYPE, [](const Gtk::FileFilter::Info &info) {
|
||||
#ifdef WIN32
|
||||
#ifdef _WIN32
|
||||
return info.mime_type == "application/x-msdownload";
|
||||
#else
|
||||
return Gio::content_type_can_be_executable(info.mime_type);
|
||||
|
Reference in New Issue
Block a user