diff --git a/rtgui/cropwindow.cc b/rtgui/cropwindow.cc index ed843c3e1..b80080f69 100644 --- a/rtgui/cropwindow.cc +++ b/rtgui/cropwindow.cc @@ -269,7 +269,7 @@ void CropWindow::buttonPress (int button, int type, int bstate, int x, int y) { bool needRedraw = true; // most common case ; not redrawing are exceptions - EditSubscriber *editSubscriber = iarea->getCurrSubscriber(); + const auto editSubscriber = iarea->getCurrSubscriber(); iarea->grabFocus (this); diff --git a/rtgui/edit.cc b/rtgui/edit.cc index 87ccfde57..48b3f8437 100644 --- a/rtgui/edit.cc +++ b/rtgui/edit.cc @@ -747,7 +747,7 @@ void Rectangle::drawToMOChannel(Cairo::RefPtr &cr, unsigned shor } } -void OPIcon::drivenPointToRectangle(rtengine::Coord &pos, +void OPIcon::drivenPointToRectangle(const rtengine::Coord &pos, rtengine::Coord &topLeft, rtengine::Coord &bottomRight, int W, int H) { switch (drivenPoint) { @@ -801,37 +801,37 @@ void OPIcon::drivenPointToRectangle(rtengine::Coord &pos, bottomRight.y = topLeft.y + H - 1; } -OPIcon::OPIcon(Cairo::RefPtr *normal, - Cairo::RefPtr *active, - Cairo::RefPtr *prelight, - Cairo::RefPtr *dragged, - Cairo::RefPtr *insensitive, - enum DrivenPoint drivenPoint) : +OPIcon::OPIcon(const Cairo::RefPtr &normal, + const Cairo::RefPtr &active, + const Cairo::RefPtr &prelight, + const Cairo::RefPtr &dragged, + const Cairo::RefPtr &insensitive, + DrivenPoint drivenPoint) : drivenPoint(drivenPoint) { if (normal) { - normalImg = *normal; + normalImg = normal; } if (prelight) { - prelightImg = *prelight; + prelightImg = prelight; } if (active) { - activeImg = *active; + activeImg = active; } if (dragged) { - draggedImg = *active; + draggedImg = active; } if (insensitive) { - insensitiveImg = *insensitive; + insensitiveImg = insensitive; } } OPIcon::OPIcon(Glib::ustring normalImage, Glib::ustring activeImage, Glib::ustring prelightImage, - Glib::ustring draggedImage, Glib::ustring insensitiveImage, enum DrivenPoint drivenPoint) : drivenPoint(drivenPoint) + Glib::ustring draggedImage, Glib::ustring insensitiveImage, DrivenPoint drivenPoint) : drivenPoint(drivenPoint) { if (!normalImage.empty()) { normalImg = Cairo::ImageSurface::create_from_png( RTImage::findIconAbsolutePath(normalImage) ); @@ -854,28 +854,28 @@ OPIcon::OPIcon(Glib::ustring normalImage, Glib::ustring activeImage, Glib::ustri } } -Cairo::RefPtr OPIcon::getNormalImg() +const Cairo::RefPtr OPIcon::getNormalImg() { return normalImg; } -Cairo::RefPtr OPIcon::getPrelightImg() +const Cairo::RefPtr OPIcon::getPrelightImg() { return prelightImg; } -Cairo::RefPtr OPIcon::getActiveImg() +const Cairo::RefPtr OPIcon::getActiveImg() { return activeImg; } -Cairo::RefPtr OPIcon::getDraggedImg() +const Cairo::RefPtr OPIcon::getDraggedImg() { return draggedImg; } -Cairo::RefPtr OPIcon::getInsensitiveImg() +const Cairo::RefPtr OPIcon::getInsensitiveImg() { return insensitiveImg; } -void OPIcon::drawImage(Cairo::RefPtr img, +void OPIcon::drawImage(const Cairo::RefPtr &img, Cairo::RefPtr &cr, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem) { @@ -901,7 +901,7 @@ void OPIcon::drawImage(Cairo::RefPtr img, cr->fill(); } -void OPIcon::drawMOImage(Cairo::RefPtr img, Cairo::RefPtr &cr, +void OPIcon::drawMOImage(const Cairo::RefPtr &img, Cairo::RefPtr &cr, unsigned short id, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem) { // test of F_HOVERABLE has already been done @@ -1078,27 +1078,27 @@ void EditSubscriber::switchOffEditMode() unsubscribe(); } -const EditUniqueID EditSubscriber::getEditID() +EditUniqueID EditSubscriber::getEditID() { return ID; } -const EditType EditSubscriber::getEditingType() +EditType EditSubscriber::getEditingType() { return editingType; } -const BufferType EditSubscriber::getPipetteBufferType() +BufferType EditSubscriber::getPipetteBufferType() { return bufferType; } -const bool EditSubscriber::isDragging() +bool EditSubscriber::isDragging() { return action == ES_ACTION_DRAGGING; } -const bool EditSubscriber::isPicking() +bool EditSubscriber::isPicking() { return action == ES_ACTION_PICKING; } diff --git a/rtgui/edit.h b/rtgui/edit.h index c4213af40..5b1a8a63c 100644 --- a/rtgui/edit.h +++ b/rtgui/edit.h @@ -400,7 +400,7 @@ public: class OPIcon : public Geometry // OP stands for "On Preview" { -protected: +private: Cairo::RefPtr normalImg; Cairo::RefPtr prelightImg; Cairo::RefPtr activeImg; @@ -411,22 +411,26 @@ protected: static void updateImages(); void changeImage(Glib::ustring &newImage); static Glib::ustring findIconAbsolutePath(const Glib::ustring &iconFName); - void drawImage (Cairo::RefPtr img, Cairo::RefPtr &cr, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); - void drawMOImage (Cairo::RefPtr img, Cairo::RefPtr &cr, unsigned short id, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); - void drivenPointToRectangle(rtengine::Coord &pos, rtengine::Coord &topLeft, rtengine::Coord &bottomRight, int W, int H); + void drawImage (const Cairo::RefPtr &img, Cairo::RefPtr &cr, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); + void drawMOImage (const Cairo::RefPtr &img, Cairo::RefPtr &cr, unsigned short id, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); + void drivenPointToRectangle(const rtengine::Coord &pos, rtengine::Coord &topLeft, rtengine::Coord &bottomRight, int W, int H); public: - enum DrivenPoint drivenPoint; + DrivenPoint drivenPoint; rtengine::Coord position; - OPIcon (Cairo::RefPtr *normal, Cairo::RefPtr *active, Cairo::RefPtr *prelight = NULL, Cairo::RefPtr *dragged = NULL, Cairo::RefPtr *insensitive = NULL, - enum DrivenPoint drivenPoint = DP_CENTERCENTER); - OPIcon (Glib::ustring normalImage, Glib::ustring activeImage, Glib::ustring prelightImage = "", Glib::ustring draggedImage = "", Glib::ustring insensitiveImage = "", enum DrivenPoint drivenPoint = DP_CENTERCENTER); - Cairo::RefPtr getNormalImg(); - Cairo::RefPtr getPrelightImg(); - Cairo::RefPtr getActiveImg(); - Cairo::RefPtr getDraggedImg(); - Cairo::RefPtr getInsensitiveImg(); + OPIcon (const Cairo::RefPtr &normal, + const Cairo::RefPtr &active, + const Cairo::RefPtr &prelight = Cairo::RefPtr (), + const Cairo::RefPtr &dragged = Cairo::RefPtr (), + const Cairo::RefPtr &insensitive = Cairo::RefPtr (), + DrivenPoint drivenPoint = DP_CENTERCENTER); + OPIcon (Glib::ustring normalImage, Glib::ustring activeImage, Glib::ustring prelightImage = "", Glib::ustring draggedImage = "", Glib::ustring insensitiveImage = "", DrivenPoint drivenPoint = DP_CENTERCENTER); + const Cairo::RefPtr getNormalImg(); + const Cairo::RefPtr getPrelightImg(); + const Cairo::RefPtr getActiveImg(); + const Cairo::RefPtr getDraggedImg(); + const Cairo::RefPtr getInsensitiveImg(); void drawOuterGeometry (Cairo::RefPtr &cr, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); void drawInnerGeometry (Cairo::RefPtr &cr, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); void drawToMOChannel (Cairo::RefPtr &cr, unsigned short id, ObjectMOBuffer *objectBuffer, EditCoordSystem &coordSystem); @@ -469,11 +473,11 @@ public: virtual void subscribe(); virtual void unsubscribe(); virtual void switchOffEditMode (); /// Occurs when the user want to stop the editing mode - const EditUniqueID getEditID(); - const EditType getEditingType(); - const BufferType getPipetteBufferType(); - const bool isDragging(); /// Returns true if something is being dragged and drag events has to be sent (object mode only) - const bool isPicking(); /// Returns true if something is being picked + EditUniqueID getEditID(); + EditType getEditingType(); + BufferType getPipetteBufferType(); + bool isDragging(); /// Returns true if something is being dragged and drag events has to be sent (object mode only) + bool isPicking(); /// Returns true if something is being picked /** @brief Get the cursor to be displayed when above handles @param objectID object currently "hovered" */