From 52ddc63f5406ff16c13e393cf2d61caa235f7697 Mon Sep 17 00:00:00 2001
From: heckflosse <heckflosse67@gmx.de>
Date: Fri, 23 Nov 2018 00:33:30 +0100
Subject: [PATCH] Fix coverity issues

---
 rtengine/eahd_demosaic.cc |  2 +-
 rtexif/rtexif.cc          | 12 ++++++++----
 rtgui/main-cli.cc         |  4 +++-
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/rtengine/eahd_demosaic.cc b/rtengine/eahd_demosaic.cc
index 4ebeb2d66..816f4bf55 100644
--- a/rtengine/eahd_demosaic.cc
+++ b/rtengine/eahd_demosaic.cc
@@ -163,7 +163,7 @@ inline void RawImageSource::interpolate_row_rb (float* ar, float* ab, float* pg,
             n++;
         }
 
-        nonGreen2[j] = cg[j] + nonGreen / n;
+        nonGreen2[j] = cg[j] + nonGreen / std::max(n, 1);
 
         // linear R-G interp. horizontally
         float val1;
diff --git a/rtexif/rtexif.cc b/rtexif/rtexif.cc
index bea091b66..39d85ace9 100644
--- a/rtexif/rtexif.cc
+++ b/rtexif/rtexif.cc
@@ -1207,8 +1207,8 @@ Tag::Tag (TagDirectory* p, FILE* f, int base)
     } else {
         // read value
         value = new unsigned char [valuesize + 1];
-        fread (value, 1, valuesize, f);
-        value[valuesize] = '\0';
+        auto readSize = fread (value, 1, valuesize, f);
+        value[readSize] = '\0';
     }
 
     // seek back to the saved position
@@ -2149,10 +2149,14 @@ void ExifManager::parseCIFF (int length, TagDirectory* root)
     char buffer[1024];
     Tag* t;
 
-    fseek (f, rml->ciffBase + length - 4, SEEK_SET);
+    if (fseek(f, rml->ciffBase + length - 4, SEEK_SET)) {
+        return;
+    }
 
     int dirStart = get4 (f, INTEL) + rml->ciffBase;
-    fseek (f, dirStart, SEEK_SET);
+    if (fseek(f, dirStart, SEEK_SET)) {
+        return;
+    }
 
     int numOfTags = get2 (f, INTEL);
 
diff --git a/rtgui/main-cli.cc b/rtgui/main-cli.cc
index 66e0b9cfc..be225378e 100644
--- a/rtgui/main-cli.cc
+++ b/rtgui/main-cli.cc
@@ -203,7 +203,9 @@ int main (int argc, char **argv)
 
     // Move the old path to the new one if the new does not exist
     if (Glib::file_test (Glib::build_filename (options.rtdir, "cache"), Glib::FILE_TEST_IS_DIR) && !Glib::file_test (options.cacheBaseDir, Glib::FILE_TEST_IS_DIR)) {
-        g_rename (Glib::build_filename (options.rtdir, "cache").c_str (), options.cacheBaseDir.c_str ());
+        if (g_rename (Glib::build_filename (options.rtdir, "cache").c_str (), options.cacheBaseDir.c_str ()) == -1) {
+            std::cout << "g_rename " <<  Glib::build_filename (options.rtdir, "cache").c_str () << " => " << options.cacheBaseDir.c_str () << " failed." << std::endl;
+        }
     }
 
 #endif