liz/rawTherapee
liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Lensfun: Reading pp3 with applied LCP doesn't set the LCP radio button. Fixes #4088

Browse Source
This commit is contained in:
heckflosse 2017-09-17 15:53:57 +02:00
parent fb06a75c81
commit 658087e270
3 changed files with 27 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rtengine/procparams.cc
View File

@ -52,7 +52,7 @@ const int br = (int) options.rtSettings.bot_right;
const int tl = (int) options.rtSettings.top_left; const int tl = (int) options.rtSettings.top_left;
const int bl = (int) options.rtSettings.bot_left; const int bl = (int) options.rtSettings.bot_left;
const char *LensProfParams::methodstring[static_cast<size_t>(LensProfParams::eLcMode::LC_LCP) + 1u] = {"none", "lfauto", "lfmanual", "lcp"}; const char *LensProfParams::methodstring[static_cast<size_t>(LensProfParams::LcMode::LCP) + 1u] = {"none", "lfauto", "lfmanual", "lcp"};
const char *RAWParams::BayerSensor::methodstring[RAWParams::BayerSensor::numMethods] = {"amaze", "igv", "lmmse", "eahd", "hphd", "vng4", "dcb", "ahd", "fast", "mono", "none", "pixelshift" }; const char *RAWParams::BayerSensor::methodstring[RAWParams::BayerSensor::numMethods] = {"amaze", "igv", "lmmse", "eahd", "hphd", "vng4", "dcb", "ahd", "fast", "mono", "none", "pixelshift" };
const char *RAWParams::XTransSensor::methodstring[RAWParams::XTransSensor::numMethods] = {"3-pass (best)", "1-pass (medium)", "fast", "mono", "none" }; const char *RAWParams::XTransSensor::methodstring[RAWParams::XTransSensor::numMethods] = {"3-pass (best)", "1-pass (medium)", "fast", "mono", "none" };
@ -920,7 +920,7 @@ void ToneCurveParams::setDefaults()
void LensProfParams::setDefaults() void LensProfParams::setDefaults()
{ {
lcMode = eLcMode::LC_NOCORRECTION; lcMode = LcMode::NONE;
lcpFile = ""; lcpFile = "";
useDist = useVign = true; useDist = useVign = true;
useCA = false; useCA = false;
@ -5836,7 +5836,7 @@ int ProcParams::load (const Glib::ustring &fname, ParamsEdited* pedited)
} }
if(ppVersion < 327 && !lensProf.lcpFile.empty()) { if(ppVersion < 327 && !lensProf.lcpFile.empty()) {
lensProf.lcMode = LensProfParams::eLcMode::LC_LCP; lensProf.lcMode = LensProfParams::LcMode::LCP;
} }
} }

32
rtengine/procparams.h
View File

@ -829,15 +829,15 @@ class LensProfParams
{ {
public: public:
enum class eLcMode { enum class LcMode {
LC_NOCORRECTION, // No lens correction NONE, // No lens correction
LC_LENSFUNAUTOMATCH, // Lens correction using auto matched lensfun database entry LENSFUNAUTOMATCH, // Lens correction using auto matched lensfun database entry
LC_LENSFUNMANUAL, // Lens correction using manually selected lensfun database entry LENSFUNMANUAL, // Lens correction using manually selected lensfun database entry
LC_LCP // Lens correction using lcp file LCP // Lens correction using lcp file
}; };
static const char *methodstring[static_cast<size_t>(eLcMode::LC_LCP) + 1u]; static const char *methodstring[static_cast<size_t>(LcMode::LCP) + 1u];
eLcMode lcMode; LcMode lcMode;
Glib::ustring lcpFile; Glib::ustring lcpFile;
bool useDist, useVign, useCA; bool useDist, useVign, useCA;
Glib::ustring lfCameraMake; Glib::ustring lfCameraMake;
@ -852,37 +852,37 @@ public:
bool useLensfun() const bool useLensfun() const
{ {
return lcMode == eLcMode::LC_LENSFUNAUTOMATCH || lcMode == eLcMode::LC_LENSFUNMANUAL; return lcMode == LcMode::LENSFUNAUTOMATCH || lcMode == LcMode::LENSFUNMANUAL;
} }
bool lfAutoMatch() const bool lfAutoMatch() const
{ {
return lcMode == eLcMode::LC_LENSFUNAUTOMATCH; return lcMode == LcMode::LENSFUNAUTOMATCH;
} }
bool useLcp() const bool useLcp() const
{ {
return lcMode == eLcMode::LC_LCP && lcpFile.length() > 0; return lcMode == LcMode::LCP && lcpFile.length() > 0;
} }
bool lfManual() const bool lfManual() const
{ {
return lcMode == eLcMode::LC_LENSFUNMANUAL; return lcMode == LcMode::LENSFUNMANUAL;
} }
Glib::ustring getMethodString(eLcMode mode) const Glib::ustring getMethodString(LcMode mode) const
{ {
return methodstring[static_cast<size_t>(mode)]; return methodstring[static_cast<size_t>(mode)];
} }
eLcMode getMethodNumber(const Glib::ustring &mode) const LcMode getMethodNumber(const Glib::ustring &mode) const
{ {
for(size_t i = 0; i < static_cast<size_t>(eLcMode::LC_LCP); ++i) { for(size_t i = 0; i <= static_cast<size_t>(LcMode::LCP); ++i) {
if(methodstring[i] == mode) { if(methodstring[i] == mode) {
return static_cast<eLcMode>(i); return static_cast<LcMode>(i);
} }
} }
return eLcMode::LC_NOCORRECTION; return LcMode::NONE;
} }
}; };

16
rtgui/lensprofile.cc
View File

@ -161,16 +161,16 @@ void LensProfilePanel::read(const rtengine::procparams::ProcParams* pp, const Pa
corrLensfunAuto->set_sensitive(true); corrLensfunAuto->set_sensitive(true);
switch(pp->lensProf.lcMode) { switch(pp->lensProf.lcMode) {
case procparams::LensProfParams::eLcMode::LC_LCP : case procparams::LensProfParams::LcMode::LCP :
corrLcpFile->set_active(true); corrLcpFile->set_active(true);
break; break;
case procparams::LensProfParams::eLcMode::LC_LENSFUNAUTOMATCH : case procparams::LensProfParams::LcMode::LENSFUNAUTOMATCH :
corrLensfunAuto->set_active(true); corrLensfunAuto->set_active(true);
break; break;
case procparams::LensProfParams::eLcMode::LC_LENSFUNMANUAL : case procparams::LensProfParams::LcMode::LENSFUNMANUAL :
corrLensfunManual->set_active(true); corrLensfunManual->set_active(true);
break; break;
case procparams::LensProfParams::eLcMode::LC_NOCORRECTION : case procparams::LensProfParams::LcMode::NONE :
corrOff->set_active(true); corrOff->set_active(true);
} }
@ -274,13 +274,13 @@ void LensProfilePanel::setRawMeta(bool raw, const rtengine::ImageMetaData* pMeta
void LensProfilePanel::write( rtengine::procparams::ProcParams* pp, ParamsEdited* pedited) void LensProfilePanel::write( rtengine::procparams::ProcParams* pp, ParamsEdited* pedited)
{ {
if (corrLcpFile->get_active()) { if (corrLcpFile->get_active()) {
pp->lensProf.lcMode = procparams::LensProfParams::eLcMode::LC_LCP; pp->lensProf.lcMode = procparams::LensProfParams::LcMode::LCP;
} else if(corrLensfunManual->get_active()) { } else if(corrLensfunManual->get_active()) {
pp->lensProf.lcMode = procparams::LensProfParams::eLcMode::LC_LENSFUNMANUAL; pp->lensProf.lcMode = procparams::LensProfParams::LcMode::LENSFUNMANUAL;
} else if(corrLensfunAuto->get_active()) { } else if(corrLensfunAuto->get_active()) {
pp->lensProf.lcMode = procparams::LensProfParams::eLcMode::LC_LENSFUNAUTOMATCH; pp->lensProf.lcMode = procparams::LensProfParams::LcMode::LENSFUNAUTOMATCH;
} else if(corrOff->get_active()) { } else if(corrOff->get_active()) {
pp->lensProf.lcMode = procparams::LensProfParams::eLcMode::LC_NOCORRECTION; pp->lensProf.lcMode = procparams::LensProfParams::LcMode::NONE;
} }
if (LCPStore::getInstance()->isValidLCPFileName(fcbLCPFile->get_filename())) { if (LCPStore::getInstance()->isValidLCPFileName(fcbLCPFile->get_filename())) {