liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the PPM fix. It broke the jpeg embedded thumbs, they weren't being shrunk.

Browse Source
This commit is contained in:
Steve Herrell
2010-12-03 15:36:39 -05:00
parent bccd35122e
commit 687ba597c2
2 changed files with 66 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
rtengine/rtthumbnail.cc
View File

@@ -49,76 +49,6 @@ my_jpeg_stdio_src (j_decompress_ptr cinfo, FILE * infile);
namespace rtengine { namespace rtengine {
Thumbnail* Thumbnail::loadFromMemory (const char* image, int length, int &w, int &h, int fixwh,
bool swap_order, int bps) {
Image16* img = new Image16 ();
int err = 1;
if ( (unsigned char)image[1] == 0xd8 )
{
err = img->loadJPEGFromMemory(image,length);
}
else
{
err = img->loadPPMFromMemory(image,w,h,swap_order,bps);
}
if (err) {
printf("loadfromMemory: error\n");
delete img;
return NULL;
}
Thumbnail* tpp = new Thumbnail ();
tpp->camwbRed = 1.0;
tpp->camwbGreen = 1.0;
tpp->camwbBlue = 1.0;
tpp->embProfileLength = 0;
unsigned char* data;
img->getEmbeddedProfileData (tpp->embProfileLength, data);
if (data && tpp->embProfileLength) {
tpp->embProfileData = new unsigned char [tpp->embProfileLength];
memcpy (tpp->embProfileData, data, tpp->embProfileLength);
}
else {
tpp->embProfileLength = 0;
tpp->embProfileData = NULL;
}
tpp->redMultiplier = 1.0;
tpp->greenMultiplier = 1.0;
tpp->blueMultiplier = 1.0;
tpp->scaleForSave = 8192;
tpp->defGain = 1.0;
tpp->gammaCorrected = false;
tpp->isRaw = 1;
memset (tpp->colorMatrix, 0, sizeof(tpp->colorMatrix));
tpp->colorMatrix[0][0] = 1.0;
tpp->colorMatrix[1][1] = 1.0;
tpp->colorMatrix[2][2] = 1.0;
if (fixwh==1) {
w = h * img->width / img->height;
tpp->scale = (double)img->height / h;
}
else {
h = w * img->height / img->width;
tpp->scale = (double)img->width / w;
}
tpp->thumbImg = img->resize (w, h, TI_Nearest);
tpp->autowbTemp=2700;
tpp->autowbGreen=1.0;
delete img;
tpp->init ();
return tpp;
}
Thumbnail* Thumbnail::loadFromImage (const Glib::ustring& fname, int &w, int &h, int fixwh) { Thumbnail* Thumbnail::loadFromImage (const Glib::ustring& fname, int &w, int &h, int fixwh) {
Image16* img = new Image16 (); Image16* img = new Image16 ();
@@ -222,24 +152,69 @@ Thumbnail* Thumbnail::loadQuickFromRaw (const Glib::ustring& fname, RawMetaDataL
rml.ciffBase = ri->get_ciffBase(); rml.ciffBase = ri->get_ciffBase();
rml.ciffLength = ri->get_ciffLen(); rml.ciffLength = ri->get_ciffLen();
rtengine::Thumbnail* tpp = 0; Image16* img = new Image16 ();
// see if it is something we support // see if it is something we support
if ( ri->is_supportedThumb() ) if ( ri->is_supportedThumb() )
{ {
w = ri->get_thumbWidth(); int err = 1;
h = ri->get_thumbHeight();
tpp = rtengine::Thumbnail::loadFromMemory((const char*)fdata(ri->get_thumbOffset(),ri->get_file()),ri->get_thumbLength(), const char* data((const char*)fdata(ri->get_thumbOffset(),ri->get_file()));
w,h,fixwh, if ( (unsigned char)data[1] == 0xd8 )
ri->get_thumbSwap(),ri->get_thumbBPS()); {
err = img->loadJPEGFromMemory(data,ri->get_thumbLength());
}
else
{
err = img->loadPPMFromMemory(data,ri->get_thumbWidth(),ri->get_thumbHeight(),ri->get_thumbSwap(),ri->get_thumbBPS());
} }
if ( tpp == 0 ) if ( err )
{ {
printf("loadfromMemory: error\n");
delete img;
delete ri; delete ri;
printf("DCRAW: failed4\n");
return NULL; return NULL;
} }
}
Thumbnail* tpp = new Thumbnail ();
tpp->camwbRed = 1.0;
tpp->camwbGreen = 1.0;
tpp->camwbBlue = 1.0;
tpp->embProfileLength = 0;
tpp->embProfile = NULL;
tpp->embProfileData = NULL;
tpp->redMultiplier = 1.0;
tpp->greenMultiplier = 1.0;
tpp->blueMultiplier = 1.0;
tpp->scaleForSave = 8192;
tpp->defGain = 1.0;
tpp->gammaCorrected = false;
tpp->isRaw = 1;
memset (tpp->colorMatrix, 0, sizeof(tpp->colorMatrix));
tpp->colorMatrix[0][0] = 1.0;
tpp->colorMatrix[1][1] = 1.0;
tpp->colorMatrix[2][2] = 1.0;
if (fixwh==1) {
w = h * img->width / img->height;
tpp->scale = (double)img->height / h;
}
else {
h = w * img->height / img->width;
tpp->scale = (double)img->width / w;
}
tpp->thumbImg = img->resize (w, h, TI_Nearest);
delete img;
tpp->autowbTemp=2700;
tpp->autowbGreen=1.0;
if (ri->get_rotateDegree() > 0) { if (ri->get_rotateDegree() > 0) {
Image16* rot = tpp->thumbImg->rotate(ri->get_rotateDegree()); Image16* rot = tpp->thumbImg->rotate(ri->get_rotateDegree());
@@ -247,6 +222,7 @@ Thumbnail* Thumbnail::loadQuickFromRaw (const Glib::ustring& fname, RawMetaDataL
tpp->thumbImg = rot; tpp->thumbImg = rot;
} }
tpp->init ();
delete ri; delete ri;
return tpp; return tpp;
@@ -1298,7 +1274,7 @@ bool Thumbnail::readEmbProfile (const Glib::ustring& fname) {
bool Thumbnail::writeEmbProfile (const Glib::ustring& fname) { bool Thumbnail::writeEmbProfile (const Glib::ustring& fname) {
if (embProfileLength) { if (embProfileData) {
FILE* f = fopen (fname.c_str(), "wb"); FILE* f = fopen (fname.c_str(), "wb");
if (f) { if (f) {
fwrite (embProfileData, 1, embProfileLength, f); fwrite (embProfileData, 1, embProfileLength, f);

2
rtengine/rtthumbnail.h
View File

@@ -75,8 +75,6 @@ namespace rtengine {
void getFinalSize (const rtengine::procparams::ProcParams& pparams, int& w, int& h); void getFinalSize (const rtengine::procparams::ProcParams& pparams, int& w, int& h);
static Thumbnail* loadQuickFromRaw (const Glib::ustring& fname, rtengine::RawMetaDataLocation& rml, int &w, int &h, int fixwh); static Thumbnail* loadQuickFromRaw (const Glib::ustring& fname, rtengine::RawMetaDataLocation& rml, int &w, int &h, int fixwh);
static Thumbnail* loadFromMemory (const char* image, int length, int &w, int &h, int fixwh,
bool swap_order, int bps);
static Thumbnail* loadFromRaw (const Glib::ustring& fname, RawMetaDataLocation& rml, int &w, int &h, int fixwh); static Thumbnail* loadFromRaw (const Glib::ustring& fname, RawMetaDataLocation& rml, int &w, int &h, int fixwh);
static Thumbnail* loadFromImage (const Glib::ustring& fname, int &w, int &h, int fixwh); static Thumbnail* loadFromImage (const Glib::ustring& fname, int &w, int &h, int fixwh);