From 6a0067d7387365fc094ed66a698b46b771e84c34 Mon Sep 17 00:00:00 2001
From: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
Date: Fri, 24 Dec 2021 16:03:58 -0800
Subject: [PATCH] Disable favorite tool cloning by default

Also add tooltip stating that tool cloning may cause a delay while
switching between tabs.
---
 rtdata/languages/default  | 1 +
 rtgui/options.cc          | 2 +-
 rtgui/toollocationpref.cc | 2 ++
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/rtdata/languages/default b/rtdata/languages/default
index bd65781a8..d409c4393 100644
--- a/rtdata/languages/default
+++ b/rtdata/languages/default
@@ -1902,6 +1902,7 @@ PREFERENCES_THUMBNAIL_INSPECTOR_RAW;Neutral raw rendering
 PREFERENCES_THUMBNAIL_INSPECTOR_RAW_IF_NO_JPEG_FULLSIZE;Embedded JPEG if fullsize, neutral raw otherwise
 PREFERENCES_TOOLPANEL_AVAILABLETOOLS;Available Tools
 PREFERENCES_TOOLPANEL_CLONE_FAVORITES;Keep favorite tools in original locations
+PREFERENCES_TOOLPANEL_CLONE_FAVORITES_TOOLTIP;If set, favorite tools will appear in both the favorites tab and their original tabs.\n\nNote: Enabling this option may result in a slight delay when switching tabs.
 PREFERENCES_TOOLPANEL_FAVORITE;Favorite
 PREFERENCES_TOOLPANEL_FAVORITESPANEL;Favorites Panel
 PREFERENCES_TOOLPANEL_TOOL;Tool
diff --git a/rtgui/options.cc b/rtgui/options.cc
index b5463949a..f597d3a1c 100644
--- a/rtgui/options.cc
+++ b/rtgui/options.cc
@@ -424,7 +424,7 @@ void Options::setDefaults()
     //crvOpen.clear ();
     parseExtensions.clear();
     favorites.clear();
-    cloneFavoriteTools = true;
+    cloneFavoriteTools = false;
     parseExtensionsEnabled.clear();
     parsedExtensions.clear();
     parsedExtensionsSet.clear();
diff --git a/rtgui/toollocationpref.cc b/rtgui/toollocationpref.cc
index cf2386257..cf25dbc34 100644
--- a/rtgui/toollocationpref.cc
+++ b/rtgui/toollocationpref.cc
@@ -532,6 +532,8 @@ ToolLocationPreference::Impl::Impl(Options &options) :
 
     // General options.
     cloneFavoriteToolsToggleWidget->set_active(options.cloneFavoriteTools);
+    cloneFavoriteToolsToggleWidget->set_tooltip_text(
+        M("PREFERENCES_TOOLPANEL_CLONE_FAVORITES_TOOLTIP"));
 
     // Tool list.
     toolListViewPtr->append_column(toolListViewColumnToolName);