From 6d447f7e0290ae2edd786b4f6bb15c17593a5b42 Mon Sep 17 00:00:00 2001 From: Hombre Date: Sun, 29 Nov 2015 02:41:07 +0100 Subject: [PATCH] Issue 2990: Fix possible memory leak ; at least, let the Windows version w/ Gtk3.18 start w/o crashing --- rtgui/thumbbrowserentrybase.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/rtgui/thumbbrowserentrybase.cc b/rtgui/thumbbrowserentrybase.cc index 913ee120f..5f928a737 100644 --- a/rtgui/thumbbrowserentrybase.cc +++ b/rtgui/thumbbrowserentrybase.cc @@ -64,7 +64,13 @@ void ThumbBrowserEntryBase::updateBackBuffer () return; } - backBuffer = Glib::RefPtr ( new BackBuffer (exp_width, exp_height, win) ); + if (backBuffer && (backBuffer->getWidth() != exp_width || backBuffer->getHeight() != exp_height )) { + // deleting the existing BackBuffer + backBuffer.reset(); + } + if (!backBuffer) { + backBuffer = Glib::RefPtr ( new BackBuffer (exp_width, exp_height, win) ); + } // If thumbnail is hidden by a filter, drawing to it will crash // if either with or height is zero then return early