liz/rawTherapee
liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix possible infinite loop in dcraw

Browse Source 
Use same type for variable comparison in loop condition. Fixes CodeQL
alert 96.
This commit is contained in:
Lawrence Lee 2024-03-02 20:55:07 -08:00
parent 65a14051fe
commit 6daf3f6a23
No known key found for this signature in database
GPG Key ID: 048FF2B76A63895F
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rtengine/libraw/src/decoders/decoders_dcraw.cpp
View File

@ -345,7 +345,10 @@ int LibRaw::ljpeg_start(struct jhead *jh, int info_only)
if (jh->sraw) if (jh->sraw)
{ {
FORC(4) jh->huff[2 + c] = jh->huff[1]; FORC(4) jh->huff[2 + c] = jh->huff[1];
FORC(jh->sraw) jh->huff[1 + c] = jh->huff[0]; {
int c;
FORC(jh->sraw) jh->huff[1 + c] = jh->huff[0];
}
} }
jh->row = (ushort *)calloc(jh->wide * jh->clrs, 16); jh->row = (ushort *)calloc(jh->wide * jh->clrs, 16);
return zero_after_ff = 1; return zero_after_ff = 1;