Fixed a lot of issues reported by cppcheck 1.78

2017-04-08 22:41:46 +02:00
parent 73e14702dd
commit 6e55f6bab5
41 changed files with 226 additions and 254 deletions
--- a/rtgui/editorpanel.cc
+++ b/rtgui/editorpanel.cc
@@ -2113,12 +2113,6 @@ void EditorPanel::updateHistogramPosition (int oldPosition, int newPosition)
        // No histogram
        if (!oldPosition) {
            // An histogram actually exist, we delete it
-            if      (oldPosition == 1) {
-                removeIfThere (leftbox, histogramPanel, false);
-            } else if (oldPosition == 2) {
-                removeIfThere (vboxright, histogramPanel, false);
-            }
-
            delete histogramPanel;
            histogramPanel = nullptr;
        }