Code cleanup: size() vs empty(), possible memleaks, initialization list order. On behalf of lebedev.ri, see issue 1195

2012-01-08 17:35:33 +00:00
parent 02e6d9e9a5
commit 977094a912
54 changed files with 342 additions and 198 deletions
--- a/rtgui/diagonalcurveeditorsubgroup.cc
+++ b/rtgui/diagonalcurveeditorsubgroup.cc
@@ -501,7 +501,7 @@ void DiagonalCurveEditorSubGroup::restoreDisplayedHistogram() {
 }

 void DiagonalCurveEditorSubGroup::storeCurveValues (CurveEditor* ce, const std::vector<double>& p) {
-	if (p.size()) {
+	if (!p.empty()) {
 		DiagonalCurveType t = (DiagonalCurveType)p[0];
 		for (int i=0; i<(int)p.size(); i++)