liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some coverity issues

Browse Source
This commit is contained in:
heckflosse
2017-06-12 23:57:18 +02:00
parent 69664430e2
commit a6cf24bc13
5 changed files with 31 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
rtengine/rtthumbnail.cc
View File

@@ -1988,21 +1988,25 @@ bool Thumbnail::writeData (const Glib::ustring& fname)
bool Thumbnail::readEmbProfile (const Glib::ustring& fname)
{
FILE* f = g_fopen (fname.c_str (), "rb");
embProfileData = nullptr;
embProfile = nullptr;
embProfileLength = 0;
if (!f) {
embProfileData = nullptr;
embProfile = nullptr;
embProfileLength = 0;
} else {
fseek (f, 0, SEEK_END);
embProfileLength = ftell (f);
fseek (f, 0, SEEK_SET);
embProfileData = new unsigned char[embProfileLength];
fread (embProfileData, 1, embProfileLength, f);
FILE* f = g_fopen (fname.c_str (), "rb");
if (f) {
if(!fseek (f, 0, SEEK_END)) {
int profileLength = ftell (f);
if(profileLength > 0) {
embProfileLength = profileLength;
if(!fseek (f, 0, SEEK_SET)) {
embProfileData = new unsigned char[embProfileLength];
fread (embProfileData, 1, embProfileLength, f);
embProfile = cmsOpenProfileFromMem (embProfileData, embProfileLength);
}
}
}
fclose (f);
embProfile = cmsOpenProfileFromMem (embProfileData, embProfileLength);
return true;
return embProfile != nullptr;
}
return false;