From ac663bfd9f23fb50294c67a24c1b8d8d47061d67 Mon Sep 17 00:00:00 2001 From: heckflosse Date: Tue, 13 Jun 2017 17:00:07 +0200 Subject: [PATCH] Fix coverity issues in tonemapping --- rtengine/EdgePreservingDecomposition.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rtengine/EdgePreservingDecomposition.cc b/rtengine/EdgePreservingDecomposition.cc index 5e91eae9d..1424af1b3 100644 --- a/rtengine/EdgePreservingDecomposition.cc +++ b/rtengine/EdgePreservingDecomposition.cc @@ -425,7 +425,10 @@ bool MultiDiagonalSymmetricMatrix::CreateIncompleteCholeskyFactorization(int Max //Initialize the decomposition - setup memory, start rows, etc. MultiDiagonalSymmetricMatrix *ic = new MultiDiagonalSymmetricMatrix(n, mic); - ic->CreateDiagonal(0, 0); //There's always a main diagonal in this type of decomposition. + if(!ic->CreateDiagonal(0, 0)) { //There's always a main diagonal in this type of decomposition. + delete ic; + return false; + } mic = 1; for(int ii = 1; ii < m; ii++) { @@ -659,7 +662,7 @@ void MultiDiagonalSymmetricMatrix::CholeskyBackSolve(float* RESTRICT x, float* R } } -EdgePreservingDecomposition::EdgePreservingDecomposition(int width, int height) +EdgePreservingDecomposition::EdgePreservingDecomposition(int width, int height) : a0(nullptr) , a_1(nullptr), a_w(nullptr), a_w_1(nullptr), a_w1(nullptr) { w = width; h = height;