From aea1d805f78ddcc005c88d666d6af9dcbc879e2b Mon Sep 17 00:00:00 2001 From: rom9 <4711834+rom9@users.noreply.github.com> Date: Wed, 21 Apr 2021 21:53:37 +0200 Subject: [PATCH] Fixes #6213 : when both fattal and filmNegative tools are enabled, copy data from `baseCrop`, to avoid using the fresh buffer from `getImage` (un-doing the previous negative inversion). This minimal change might not be the most correct solution, but it cannot be harmful: at worst, it can only break when both filmNeg and fattal are enabled (a situation wich is already broken). --- rtengine/dcrop.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtengine/dcrop.cc b/rtengine/dcrop.cc index 790a2bf0d..852ba0ba7 100644 --- a/rtengine/dcrop.cc +++ b/rtengine/dcrop.cc @@ -720,7 +720,7 @@ void Crop::update(int todo) parent->imgsrc->getImage(parent->currWB, tr, f, pp, params.toneCurve, params.raw); parent->imgsrc->convertColorSpace(f, params.icm, parent->currWB); - if (params.dirpyrDenoise.enabled) { + if (params.dirpyrDenoise.enabled || params.filmNegative.enabled) { // copy the denoised crop int oy = trafy / skip; int ox = trafx / skip;