diff --git a/rtgui/filmsimulation.cc b/rtgui/filmsimulation.cc index 907f5578a..e1cbd4966 100644 --- a/rtgui/filmsimulation.cc +++ b/rtgui/filmsimulation.cc @@ -143,16 +143,15 @@ ClutComboBox::ClutColumns::ClutColumns() add( clutFilename ); } -int ClutComboBox::fillFromDir( Glib::ustring path ) +int ClutComboBox::fillFromDir (const Glib::ustring& path) { - int result = 0; + m_model = Gtk::TreeStore::create (m_columns); + set_model (m_model); - if ( !path.empty() ) { - m_model.clear(); - m_model = Gtk::TreeStore::create( m_columns ); - set_model( m_model ); - result = parseDir( path, 0 ); - pack_start( m_columns.label, false ); + const auto result = parseDir (path, nullptr); + + if (result > 0) { + pack_start (m_columns.label, false); } return result; diff --git a/rtgui/filmsimulation.h b/rtgui/filmsimulation.h index 89e9f6fa3..a463bdf60 100644 --- a/rtgui/filmsimulation.h +++ b/rtgui/filmsimulation.h @@ -11,7 +11,7 @@ class ClutComboBox : public MyComboBox { public: - int fillFromDir( Glib::ustring path ); + int fillFromDir (const Glib::ustring& path); Glib::ustring getSelectedClut(); void setSelectedClut( Glib::ustring filename ); void addUnchangedEntry();