From 5edf870c138a93114b51bf62cff741182aed8d2e Mon Sep 17 00:00:00 2001 From: kaesa Date: Thu, 13 Feb 2025 10:51:19 +0200 Subject: [PATCH 1/2] Fix for DCPProfile constructor not respecting verbose on all printf occurrences. --- rtengine/dcp.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rtengine/dcp.cc b/rtengine/dcp.cc index c6eab3b2a..989afadb3 100644 --- a/rtengine/dcp.cc +++ b/rtengine/dcp.cc @@ -1131,13 +1131,17 @@ DCPProfile::DCPProfile(const Glib::ustring& filename) : }); if (file == nullptr) { - printf ("Unable to load DCP profile '%s' !", filename.c_str()); + if (settings->verbose) { + printf ("Unable to load DCP profile '%s' !", filename.c_str()); + } return; } DCPMetadata md(file.get()); if (!md.parse()) { - printf ("Unable to load DCP profile '%s'.", filename.c_str()); + if (settings->verbose) { + printf ("Unable to load DCP profile '%s'.", filename.c_str()); + } return; } From 883ae67a569cbcff3eda2a62146d601aa486600c Mon Sep 17 00:00:00 2001 From: kaesa Date: Thu, 13 Feb 2025 11:34:22 +0200 Subject: [PATCH 2/2] Added missing newlines to keep verbose output more readable. --- rtengine/dcp.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rtengine/dcp.cc b/rtengine/dcp.cc index 989afadb3..3c6c54d33 100644 --- a/rtengine/dcp.cc +++ b/rtengine/dcp.cc @@ -1132,7 +1132,7 @@ DCPProfile::DCPProfile(const Glib::ustring& filename) : if (file == nullptr) { if (settings->verbose) { - printf ("Unable to load DCP profile '%s' !", filename.c_str()); + printf ("Unable to load DCP profile '%s' !\n", filename.c_str()); } return; } @@ -1140,7 +1140,7 @@ DCPProfile::DCPProfile(const Glib::ustring& filename) : DCPMetadata md(file.get()); if (!md.parse()) { if (settings->verbose) { - printf ("Unable to load DCP profile '%s'.", filename.c_str()); + printf ("Unable to load DCP profile '%s'.\n", filename.c_str()); } return; }