Fix all - 2 cppcheck performance hints

2016-07-06 13:04:24 +02:00
parent a991d53bf3
commit c8779c04f5
43 changed files with 114 additions and 146 deletions
--- a/rtengine/processingjob.h
+++ b/rtengine/processingjob.h
@@ -34,15 +34,11 @@ public:
    procparams::ProcParams pparams;

    ProcessingJobImpl (const Glib::ustring& fn, bool iR, const procparams::ProcParams& pp)
-        : fname(fn), isRaw(iR), initialImage(NULL)
-    {
-        pparams = pp;
-    }
+        : fname(fn), isRaw(iR), initialImage(NULL), pparams(pp) {}

    ProcessingJobImpl (InitialImage* iImage, const procparams::ProcParams& pp)
-        : fname(""), initialImage(iImage)
+        : fname(""), initialImage(iImage), pparams(pp)
    {
-        pparams = pp;
        iImage->increaseRef();
    }