liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix all - 2 cppcheck performance hints

Browse Source
This commit is contained in:
heckflosse
2016-07-06 13:04:24 +02:00
parent a991d53bf3
commit c8779c04f5
43 changed files with 114 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rtexif/rtexif.cc
View File

@@ -336,7 +336,7 @@ bool TagDirectory::CPBDump (const Glib::ustring &commFName, const Glib::ustring
return true;
}
Glib::ustring TagDirectory::getDumpKey (int tagID, const Glib::ustring tagName)
Glib::ustring TagDirectory::getDumpKey (int tagID, const Glib::ustring &tagName)
{
Glib::ustring key;
@@ -2841,7 +2841,7 @@ int ExifManager::createJPEGMarker (const TagDirectory* root, const rtengine::pro
cl = new TagDirectory (NULL, ifdAttribs, INTEL);
}
for (rtengine::procparams::ExifPairs::const_iterator i = changeList.begin(); i != changeList.end(); i++) {
for (rtengine::procparams::ExifPairs::const_iterator i = changeList.begin(); i != changeList.end(); ++i) {
cl->applyChange (i->first, i->second);
}
@@ -2927,7 +2927,7 @@ int ExifManager::createTIFFHeader (const TagDirectory* root, const rtengine::pro
}
// apply list of changes
for (rtengine::procparams::ExifPairs::const_iterator i = changeList.begin(); i != changeList.end(); i++) {
for (rtengine::procparams::ExifPairs::const_iterator i = changeList.begin(); i != changeList.end(); ++i) {
cl->applyChange (i->first, i->second);
}

6
rtexif/rtexif.h
View File

@@ -101,7 +101,7 @@ protected:
const TagAttrib* attribs; // descriptor table to decode the tags
ByteOrder order; // byte order
TagDirectory* parent; // parent directory (NULL if root)
static Glib::ustring getDumpKey (int tagID, const Glib::ustring tagName);
static Glib::ustring getDumpKey (int tagID, const Glib::ustring &tagName);
public:
TagDirectory ();
@@ -495,7 +495,7 @@ protected:
* Get the lens info (min/man focal, min/max aperture) and compare them to the possible choice
*/
if (lensInfoArray) {
for ( r = choices.lower_bound( lensID ); r != choices.upper_bound(lensID); r++ ) {
for ( r = choices.lower_bound( lensID ); r != choices.upper_bound(lensID); ++r ) {
if( !extractLensInfo( r->second , f1, f2, a1, a2) ) {
continue;
}
@@ -532,7 +532,7 @@ protected:
std::ostringstream candidates;
double deltaMin = 1000.;
for ( r = choices.lower_bound( lensID ); r != choices.upper_bound(lensID); r++ ) {
for ( r = choices.lower_bound( lensID ); r != choices.upper_bound(lensID); ++r ) {
double lensAperture, dif;
if( !extractLensInfo( r->second , f1, f2, a1, a2) ) {