From ccf4b4c84313c33c88b1007e40f1b3f845611859 Mon Sep 17 00:00:00 2001 From: Ingo Weyrich Date: Wed, 23 Oct 2019 23:14:08 +0200 Subject: [PATCH] flatfield: code review --- rtengine/rawflatfield.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/rtengine/rawflatfield.cc b/rtengine/rawflatfield.cc index 8d8ed0873..f1c0222f0 100644 --- a/rtengine/rawflatfield.cc +++ b/rtengine/rawflatfield.cc @@ -15,7 +15,8 @@ * * You should have received a copy of the GNU General Public License * along with RawTherapee. If not, see . - */ +*/ + #include #include @@ -73,7 +74,7 @@ void cfaboxblur(float** riFlatFile, float* cfablur, int boxH, int boxW, int H, i #pragma omp for #endif - for (int row = 0; row < H; row++) { + for (int row = 0; row < H; ++row) { int len = boxW / 2 + 1; cfatmp[row * W + 0] = riFlatFile[row][0] / len; cfatmp[row * W + 1] = riFlatFile[row][1] / len; @@ -199,7 +200,7 @@ void cfaboxblur(float** riFlatFile, float* cfablur, int boxH, int boxW, int H, i #pragma omp single #endif - for (int col = W - (W % 8); col < W; col++) { + for (int col = W - (W % 8); col < W; ++col) { int len = boxH / 2 + 1; cfablur[0 * W + col] = srcVertical[0 * W + col] / len; cfablur[1 * W + col] = srcVertical[1 * W + col] / len; @@ -215,7 +216,7 @@ void cfaboxblur(float** riFlatFile, float* cfablur, int boxH, int boxW, int H, i len ++; } - for (int row = boxH + 2; row < H - boxH; row++) { + for (int row = boxH + 2; row < H - boxH; ++row) { cfablur[row * W + col] = cfablur[(row - 2) * W + col] + (srcVertical[(row + boxH) * W + col] - srcVertical[(row - boxH - 2) * W + col]) / len; } @@ -235,7 +236,7 @@ void cfaboxblur(float** riFlatFile, float* cfablur, int boxH, int boxW, int H, i #pragma omp for #endif - for (int col = 0; col < W; col++) { + for (int col = 0; col < W; ++col) { int len = boxH / 2 + 1; cfablur[0 * W + col] = srcVertical[0 * W + col] / len; cfablur[1 * W + col] = srcVertical[1 * W + col] / len; @@ -251,7 +252,7 @@ void cfaboxblur(float** riFlatFile, float* cfablur, int boxH, int boxW, int H, i len ++; } - for (int row = boxH + 2; row < H - boxH; row++) { + for (int row = boxH + 2; row < H - boxH; ++row) { cfablur[row * W + col] = cfablur[(row - 2) * W + col] + (srcVertical[(row + boxH) * W + col] - srcVertical[(row - boxH - 2) * W + col]) / len; }