liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Limited exif user comment to 65535 chars

Browse Source
This commit is contained in:
heckflosse
2017-01-09 16:19:19 +01:00
parent 1998e2c6d2
commit f203f284d6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rtexif/stdattribs.cc
View File

@@ -447,12 +447,12 @@ public:
{ {
int count = t->getCount(); int count = t->getCount();
if(count <= 8) { if(count <= 8) {
return ""; return std::string();
} }
count = std::min(count, 65535); // limit to 65535 chars to avoid crashes in case of corrupted metadata
char *buffer = new char[count - 7]; char *buffer = new char[count - 7];
if (!strncmp((char*)t->getValue(), "ASCII\0\0\0", 8)) { // TODO: this compares only up to the first \0, remaining \0\0 are ignored if (!memcmp((char*)t->getValue(), "ASCII\0\0\0", 8)) {
strncpy (buffer, (char*)t->getValue() + 8, count - 8); strncpy (buffer, (char*)t->getValue() + 8, count - 8);
buffer[count - 8] = '\0'; buffer[count - 8] = '\0';
} else { } else {