A few more minor fixes geared towards lgtm.com alerts (#6127)

* Remove unfilled formatting placeholders in KLT parser.
* Fix presumably unintentionally missing reference on PlanatPtr and ChunkyPtr call operators.
* Fix catching pointer and make use-after-free of workimg easier to spot.
Make sure all of our thrown exceptions derive from std::exception and then catch
by reference instead of by pointer.
* Fix mismatch between array form new and non-array form delete.
* Simplify memory management of embedded color profiles by unifying allocation to use operator new.
This commit is contained in:
Adam Reichold
2021-03-17 08:37:19 +01:00
committed by GitHub
parent 537fa73d3f
commit fae40a137a
9 changed files with 22 additions and 37 deletions

View File

@@ -220,7 +220,7 @@ public:
#endif
return ptrs[row][col];
}
const T operator() (size_t row, size_t col) const
const T& operator() (size_t row, size_t col) const
{
#if CHECK_BOUNDS
assert (row < height_ && col < width_);
@@ -1274,7 +1274,7 @@ public:
#endif
return ptr[3 * (row * width + col)];
}
const T operator() (size_t row, size_t col) const
const T& operator() (size_t row, size_t col) const
{
#if CHECK_BOUNDS
assert (row < height_ && col < width_);