* Show min raw values in console, #5769
* Speedup
* outsourced calculation of raw min values
* First try GUI
* Improve GUI
* Clean code
* Change behavior GUI
* First step GUI Xtrans
* Second step GUI Xtrans
* Last step X-trans black dehaze
* Appimage and windows yml poordeha
* disabled sliders R G B when dehaze enabled
* Remove idle_register autoblackchanged
* Changes suggested by Lawrence37 to improve double processing
* Remove yml appaimage windows
---------
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
* Improve Itcwb with non-raw files
* Change pre-dev builds wbrefinement
* Change template in pre-dev
* Improvment improccordinator.cc
* Forgotten observer convert
* Reenable wbauto autogrey as 5.8
* Remove wrong code
* Missing getrgbloc references
* Fixed bug due to bias in queu with temperaure correlation issue 6911
* Simpleprocess queue compatibility tif-jpg
* Preserve AWB edits from 5.9
In 5.9 for non-raw files,
1. RGB grey uses the unit multipliers with temperature bias applied.
2. Temperature correlation uses the equivalent of temperature 5000,
green 1, and red/blue equalizer 1.
* Refactor temperature correlation AWB code
* Fix inaccurate RGB grey WB preview after using ITC
The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.
---------
Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
* Speed up preview when inpaint opposed enabled
Only reprocess from raw if the white balance is changed. Otherwise, a
cache from later in the pipeline can be used.
* Remove unused code
* Fix refresh map bit positions
* Make WB & inpaint opposed refresh less brittle
Co-authored-by: Hombre57 <natureh.510@gmail.com>
---------
Co-authored-by: Hombre57 <natureh.510@gmail.com>
* Change estimchrom estim hue final
* Itcw observer checkbox
* 8 spectral colors
* 11 spectral colors
* 6 spectral colors
* Small change to correction green
* Fixed various bad behavior - settings itcwb_deltaspec
* 4 spectral colors green
* 3 green spectral colors
* 3 spectral colors green
* 5 spectral colors red green
* 3 spectral colors red green
* 3 spectral colrs green red
* Chnage slider choice deltaE - to size color patch
* display more info in console
* Display more info in console - comment code
* Clean - comment code
* 8 spectral colors green red
* 8 spectral colors blue
* 8 spectral colors blue
* 3 spectral colors
* 6 spectral colors
* 4 spectal colors
* 2 spectral colors
* Eliminate high Y - increse temp iteration - recenter selection inside patch
* compatibility 5.9
* Modify dislay and place selected dats in patch
* Dispaly in console hue chroma image selection
* First optimization
* optimization code - clean unused variables
* Remove sorted in chroma order - some others changes
* 5.9 compatibility
* Clean and optimize code
* Clean code - more display info in console
* More info in console - set itcwb_minsize in option
* Display patch chroma in GUI
* Change some default settings
* Minsize patch GUI
* Display GUI patch size
* Chroma patch variations
* Display in GUI min and max dats found in patch
* Some adjustments
* Remove too low datas in patch
* Various improvment - ponderate
* Clean code colortemp comment spectral datas
* Comment code - correc gren
* Comment and refine code
* Fixed bug in improcoordinator
* fixes a malfunction of AWB bias in improcoordinator
* Various improvments - clean code
* 2 improvments green and find patch
* Allows parametrind ponder and Ypurple in options
* Update autowb - filter on magenta purple
* Clean and optimize code
* Read colors in GUI
* Denoise median 5x5 image datas before Itcwb
* Change to GUI
* Replace median5x5 by 2 median3x3 - clean GUI code
* Work around to recalculate wbauto
* Remove work around - change params->wb related change
* Disabled low_sampling 5.9
* First try for compatibility Low sampling 5.9
* Re-enable WB autogrey
* Change reference image to autogrey if camera settings probably out
* Clean code aand adjust settings camera out
* Format astylert rawimagesource.cc - various small adjustments
* Small correction
* Small green correction
* Change default settings - correction to autowb bias in improccoordinator
* Save provisory work
* Save provisory work 2
* Try to find good tempitc with iterate when temptitc very different 5000K
* Change 2 default settings
* Work around awb temp bias
* Limit work around bias - small other changes
* 3 spectral colors deep blue
* 4 spectral color deep blue
* 4 color spectral yellow
* 5 spectral colors neutral red-magenta
* 5 spectral color neutral red magenta
* Change threshold tempitc
* 5.9 compatibility
* Work around bad claculation Planck's formula
* Fixed bad behavior when using blackbody spectal
* 6 spectral color - checkbutton remove 2 passes
* Fixed various bugs
* Format rawimagesource.cc
* Various improvment before to find the good selection
* First new optimization (perhaps?)
* Display GUI patc deltaE
* Various optimzation and tooltip
* Default observer 2°- Simplify GUI - improve display GUI - remove too low numbers datas
* 4 spectral colors - change 2 settings
* Change calculation threshold 2 passes
* 6 spectral colors magenta
* 13 spectral colors
* Improvment GUI display
* remove checkbutton no_purple
* 2 spectral colors - remove in GUI low sampling 5.9
* Change default setting display in console
* Change behavior when temp near stdA
* 4 spectral colors - settings Itcwb_tempstdA
* Gamut control on image histogram
* Clean code and format rawimagesource.cc
* Comment and format colortemp.cc
* Remove unused fileds from GUI - change tooltips
* Add tooltips
* Various changes
* Change settings when camera temperature is out
* improvment extra and tooltip
* Small change when using auto grey as start reference
* Remove itcwb_fgreen from GUI
* Various change - and 'unsatisfactory' test to take into account Custom
* Change second temp when < 4000 - replace automatic by automatic and refinement
* Neutralize 'Use custom tempertaure and green'
* Green refinement
* Clean code - small changes
* Other clean code
* Added forgotten itcw_green in procparams.cc
* Fixed a bug dispaly deltaE
* Change threshold settings - change code for Custom
* various change in case of using camera settings
* Change way to estimate range green
* clean code and message in console
* Clean and optimize
* Disable 2 passes if custom
* Improve GUI 2 passes
* Increase sampling and number of temperature above 9400K
* Hide AWB temperature bais and green refinement when Custom temerature ans green
* marks out the code with past time markers
* Improve time processing with spectral colors temp calculations
* Replace in console msec by nsec
* Scan temp 5.9
* Change max temp and behavior if temp > 15000k
* Refine temp near 14000K
* Increase sampling temperature 132 to 167
* Increase sampling temperature
* Set in preference choice for itcwb_custom
* White point calculated with observer instead of table
* More on whitepoint calculation - informations
* Clean and format code with astyle colortemp.cc rawimagesource.cc improccoordinator.cc
* Small change tooltip
* Improve update auto-wb
* Remove 'use custom temperature and tin' - simplify sampling to 2 choice
* Small change to rand AWB bias - green refinement - tooltips
* slightly modify the parameters upstream of the algo - do not use camera in some cases
* Mixed initial green
* Refine init green and temp when no camera
* Refine temp and green in do not use camera settings
* Change tint threshold and various improvments (tooltips, wrong values..)
* Refinment and clean code
* Improve mode No use camera settings
* Init nocam
* Refine use no camera settings
* Small change
* 5.9 compatibility - and format
* Refine sampling temperature around 7000 - 8000K
* Format astylert rawimagesource colortemp
* 5.9 settings
* 5.9 settings 2
* Various change - 5.9 - format
* Improve pre and post algorithm
* Fixed correction temp > 8000K
* Fixed bad behavior Tppat.minchroma
* Change sampling choices and tooltip
* Change name wp wp2 wip to wb wb2 iwb to avoid misunderstood
* Small Change settings - limit display studgood to 0.0001
* Improvment display GUI temp
* Change default sampling
* Change ACESP0 to JDCmax
* Improve GUI abstract profile
* Allows dispaly in console xy values thanks to Reffort
* Remove bruce rgb in wp and abstract
* Change wp abstract and save itcwb with dispaly cellxy
* Change prim = 13 improccoordinator iplab2rgb
* remove display datas in console - fixed wrong display Y xyY
* Fixed ifferences in GUI maxhist minhist
* Change limits x y in function sampling
* fixed a dizziness
* Change after algorithm rule when temp > 6000K
* Harmonize limx limy for oldsampling 5.9
* Added Cam xyz matrix to sampling - thanks to Reffort
* Display in console xyz matrix
* Forgotten instruction when mix camera and autowb grey
* Change rgbloc with Camera matrix Dcraw when no input profile
* Change rep to repref in rgbxyz
* Remove message in console
* 5.9 compat
* 5.9 compat 2
* 5.9 compat 3
* 5.9 compat 4
* 5.9 compat 5 format
* 5.9 compta 6
* Improve code
* Diasble itcwb_sampling in GUI
* Comment code
* Clean and comment code
* 5 spectral colors
* 9 spectral colors
* 2 spectral colors
* Various improvments
* 5 spectral colors
* 5 spectral colors
* First changes review lawrence37
* Second changes review Lawrence37
* 3rd changes review Lawrence37
* 4th changes review Lawrence37
* Change windows and appimage yml
* Re-enable Rtv4_Bruce in procparams.cc
* test for 5.9 compatibility
* Try to fixed crash
* Slightly improve the management of 5.9
* test for 5.9 compatibility by passing parameters via the GUI
* Forgotten parameter
* Change ref_spec limit and remove pac_start for itcwb_sampling
* Puts back the old Planck formula - the same as in dev
* Revert "test for 5.9 compatibility by passing parameters via the GUI"
This reverts commit d6b5a8feda31b93a5574cee6ebf4d3e9d58bbcfb.
* Switch to new ITCWB only when changing WB method
Prevents sudden changing of the white balance if ITCWB is selected and
the image is reopened.
* Fix spelling in comment
* Suggested change from Lawrence37 to whitebalance - small change to improcoordinator
* tempbias Set_sentive(false) if itcwb_smapling - clean whitebalance
* Another clean whitebalance.cc
---------
Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
File browser thumbnails for raw images start with a minimally-processed
images. These images are cached and image adjustments are applied on
top. The black level is "baked-into" the cached image. Therefore, to
reflect the black level adjustments in the thumbnail, one of two options
are required:
1. Cache an image before the black level is applied and process the
black level on top of this image.
2. Recreate the base image with the new black level and cache it.
The first option yields better performance when the user changes the
black level. However, it requires other base adjustments to be applied
every time, such as the camera multipliers. The second option requires
the base image to be recreated every time the black level is changed.
This commit implements the second option. It minimizes code changes, and
therefore possible bugs. It does add a performance penalty when the
black level changes, but the black level adjustment is rarely used.
* Change Preferences for observer whitebalance
* Change label white balance preferences
* Added Preferences 2 parameters Whitebalance auto correlation
* Add Preference Temperature correlation - sort and tooltip
* Change to rtengine cmakelist
* Apply patch from Lawrence37
* Small comment code
* Change defaut order prefrences wba
* Added force extra algoritm to Preferences
* Harmonize itcwb sorted
* Add fields to Preferences Itcwb
* Change settings precision Itcwb in Preferences
* Change tooltip Itcwb preferences
* First stage Itwcwb settings in main with pp3 and selction in preferences
* Second stage Itwcwb settings in main with pp3 and selction in preferences
* Third stage Itwcwb settings in main with pp3 and selction in preferences
* Add itcwb_fgreen student - green optimize
* Add Itcwb green range
* Itcwb history msg - first tooltips
* Remove force-extra because always used
* reused force-extra to use entire CIExy for sampling datas
* Removed inwanted text in console
* Set sensitive for Itcwbframe
* Various change - comment ..
* Small code review - chnage tooltips
* Remove settings itcwb_delta in Rawimagesource.cc to simplify
* Remove Itcwb Observer - put a single observer for everything - general - itcwb
* Fixed conflicts in colortemp.cc
* Various change - fixed bug - simplify
* Fixed limits for settings pp3 - chnage tooltip
* Clean unused code
* Put itcwb_findgreen in GUI
* Added checkbox 'Low sampling' to find the settings of 5.9
* Set Observer to Observer 10° - preferences default
* Missing setting Low sampling
* Show white balance multipliers
* Change default settings - Itcwb_sorted
* Move observer from preferences to WB
* Make observer selectable for camera WB
* Ensure observer checkbox is in sync with PP3
* Set default ITCWB low sampling for PP3s from <=5.9
Ensure temperature correlation white balance algorithm 1 is used when
opening edits from versions 5.9 and earlier.
* Removed unused White-balance frame in Preferences
* Comment some GUI sliders checkbox
* Removed all GUI itcwb in preferences and whitebalance
* Removed forgotten code in preferences
* Remove labels tooltips history Itcwb
---------
Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
* Essai HL
* Try Inpaint opposed
* Code improvment
* Add file
* Improvment to process inpaint opposed and color propagation
* Clean code
* Change Blend to Coloropp in Profile pp3
* Enable BENCHFUN hilite_recon
* Clean rtengine cmakelist
* Comment unused code
* Neutralise unused code
* Change bad Exposure in Pop2Lab.pp3
* Try to fix bug when Inpaint Opposed is used and White balance disabled
* Changes to refreshmap
* Change to improccoordinator M_RETINEX
* Clean unused commented code
* Force Inpaint-opposed in rawimagesouce if wb change
* Suppressed message in console
* Change events and limits to 1 the number of calls to inpaint-opposed
* Comment code
* Add gain theshold to inpaint opposed
* fixed typo in procparams.cc
* Change in option.cc itcwb_sort to true
* Change itcw sorted in options and rawimagesource.cc
* Change sampling read datas Itcwb
* Allow or not purple in WB itcwb
* Added option icwb.nopurple to bypass settings
* Added code comment Itcwb
* optimize Itcwb between green and student
* Formated code used by Itcwb with Astylert.bat
* Change color_match - thanks to Lawrence37
* Remove wrong text
* dng gainmap support, #6379
* dng GainMap: control sensitivity of checkbox, #6379
* dng GainMap: partial paste
* dng GainMap: moved isGainMapSupported() from dcraw.h to dcraw.cc
* RawImageSource::applyDngGainMap: small speedup
* Change GUI to separate gainmap from other flat-field; also reorder checkbox
Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
* Fixed artifacts thanks to Alberto
* Added blur to Color propagation
* Clean format code - small improvments
* color propagation: Enable old mode at blur = 0
* Improve GUI
* color propagation: smooth progress bar for blur > 0
* change label
* Some cleanups
* color propagation: small speedup for blur > 0
* color propagation: speedup for blur > 0 when region with clipped highlights is small
* Speed-up for blur=1 - clean GUI code
* color propagation: cleanups
* Harmonize events in tonecurve.cc
* tonecurve.cc : cleanup
* Highlight reconstruction: small changes to gui
* Use Gtk::Box instead of Gtk::VBox
* Change maximum number of blur levels to 4
* Suppress BENCHFUN
* Suppress bad commit locallabtools
Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
* Added support for non-raw files to the film negative tool. The tool is now under the "Color" tab. Moved the entire filmneg code downstream, right after input profile conversion.
Usage changes a bit: White Balance must be set to the _backlight_ color temperature. Added two more sliders to color-balance the picture after negative inversion. Legacy inversion method kept for compatibility with processing profiles saved by RT v5.7 or 5.8 (only if Film Negative was enabled). Should be removed in a future version.
There is still an issue with DCP profiles that need the look table to be active to work properly. Using a simple matrix input profile (or just camera standard) is recommended for now.
* The user can now choose to perform inversion before or after input colorspace conversion.
Seamless backwards compatibility with previous processing profiles; upgrading from a previous version now gives an (almost) identical output as before.
Generalised the concept of film base values: the processing profile now contains a pair of RGB triplets, "reference input" and "reference output", which makes it much more straightforward to compute the output multipliers.
* Added support for `RGB` data type to putToKeyFile, removed the now unused `RGB::toVector()` method. Some cleanup.
* Spot balance picker now stays active indefinitely. Can be disabled by right-clicking, too.
* Removed film negative from `filterRawRefresh` condition, since the new version does not require raw rendering anymore.
* The Output Level slider is now exponential, so it should feel more familiar to use (similar to the exposure compensation slider).
* Removed old `RedBase`, `GreenBase`, `BlueBase` keys from the PP3 file after params upgrade. Keys are only kept if the file only undergoes batch edit (hence no params upgrade was done).
* Made the balance sliders exponential and centered at zero. Now they should be a bit smoother and possibly more user-friendly.
* Changed adjusters' step to more useful values, they were too fine-grained and hard to adjust using the +/- spinbutton.
Increased max ratio value from 3 to 5, as i found an old negative needing a very high blue channel exponent.
* Added an initial processing profile for film negative inversion, to be provided as a bundled profile.
* Removed Output Level and balance sliders when in batch mode: since the effect of these sliders is dependent on the reference input values, those values needed to be copied as well. And, touching any of the sliders needed to flag all three as dirty. All this felt more confusing than useful.
It should be sufficient (and clearer) to copy/paste the params, and then fine-tune the balance on individual pictures when needed.
* Set bayer demosaic method to RCD in the bundled "Film Negative" processing profile. RCD seems to play a bit better with Capture Sharpening in the presence of film grain, compared to Amaze.
This will favor new users starting with all-defaults settings, hence having Capture Sharpening enabled by default.
* Removed incorrect "contrast" term from the "Reference exponent" label. This parameter adjusts the image _gamma_, not its contrast.
* Added new feature to calculate channel multipliers from crop area. This also saves the crop area channel medians to the processing profiles, in order to get a more consistent color balance when batch-applying the same profile to multiple pictures from the same film roll.
* Fixed wrong initialization of array, and missing check for the result of `getFilmNegativeMedians()`.
Moved `ImProcCoordinator::translateCoord()` from private member to anonymous namespace.
Fixed some whitespace and formatting issues.
* Fixed some formatting issues
* Passed `ipf` parameter as const in `translateCoord`.
Narrowed `using namespace` to single class `Coord2D`.
* Added `scaleGain` entry to thumbnail metadata file, to make `scale_mul` multipliers available in thumbnail processing phase. This simplifies multiplier calculations, so that "faking" thumbnail multipliers in the main image processing is not necessary anymore. This way, output values are immune to slight variations of multipliers between successive shots taken with in-camera AWB turned on.
Shifted multipliers so that the output channel medians are balanced when "Camera WB" is selected. This way, just computing multipliers from crop and setting "Camera WB" (which is the default) gives a pretty well balanced image as a starting point.
* New channel scaling method, based on a film base color sample instead of crop area channel medians. Channels are scaled so that the converted film base values are equal to 1/512th of the output range (65k). This giver better black levels in the output, and more consistency when batch-processing multiple negatives.
The output is now compensated for a known fixed WB value, so that the film base will appear grey when WB is set to 3500K, Green=1.
Added PPVERSION 347 to preserve backwards compatibility: when a processing profile saved by RT 5.7 is loaded (PPVERSION=346), the new fields are initialized to the special value -1, which will instruct the main processing to follow the old channel scaling behaviour. The old channel scaling multipliers will then be converted to the new film base values so that the resulting image is the same, and the fields will be overwritten as soon as the PP is saved again. This will transparently upgrade the processing profile.
When the new behaviour is used, but the film base values are still unset, they are estimated based on channel medians, excluding a 20% border around the image. This should give a better result out-of-the-box for pictures containing a large film holder.
* Code cleanup from review
* Run astyle on film neg source files
* Fixed automated build failure caused by incompatible libraries on my dev PC.
* Simplified `Thumbnail::processFilmNegative` method signature. There is no need to pass in `rmi`,`gmi`,`bmi` multipliers from the caller, i can do the same with my own internal multipliers.
* Added `FilmNegListener` class to pass estimeted film base values to the GUI after first processing. Removed old `filmBaseValues` instance variable from RawImageSource.
* Code cleanup
* Forgot to set baseValues flag in `PartialPasteDlg::applyPaste`
Fixed `filmBaseValuesLabel` not updating when reading zero baseValues. Normally not needed (the label is updated later by the listener), but when the user is browsing through pictures the listener won't fire, so the label must be updated to show values are unset.
* Overwritten channel scaling multipliers by calling `get_colorsCoeff` with `forceAutoWB=false`.
Initially, in `RawImageSource::load`, channels are auto-balanced by averaging the whole picture when computing multipliers.
This can give different multipliers for multiple shots of the same camera, which will lead to inconsistent conversions when batch-processing multiple negatives.
This commit re-sets `scale_mul`, `ref_pre_mul`, etc., in order to "undo" the auto-WB and use the normal camera multipliers.
* Found an easier way to get stable overall multipliers, removed the (horrible) on-the-fly mutation of scaling instance variables.
